llvm-project

shylie/llvm-project

Fork 0

Commit Graph

Author	SHA1	Message	Date
Chuanqi Xu	dc4e85bd79	[C++20] [Modules] Remove hardcoded path to imported module in BMIs Close https://github.com/llvm/llvm-project/issues/62707 As we discussed before, we'll forbid the use of implicit generated path for C++20 modules. And as I mentioned in https://github.com/llvm/llvm-project/issues/62707, we've emitted a warning for clang17 and we'll make it a hard error in clang18. And the patch addresses the decision.	2024-01-12 13:47:59 +08:00
Iain Sandoe	bc2a6defc8	[C++20][Modules] Allow for redeclarations in partitions. The existing provision is not sufficient, it did not allow for the cases where an implementation partition includes the primary module interface, or for the case that an exported interface partition is contains a decl that is then implemented in a regular implementation unit. It is somewhat unfortunate that we have to compare top level module names to achieve this, since built modules are not necessarily available. TODO: It might be useful to cache a hash of the primary module name if this test proves to be a significant load. Differential Revision: https://reviews.llvm.org/D127624	2022-07-08 19:02:59 +01:00

Author

SHA1

Message

Date

Chuanqi Xu

dc4e85bd79

[C++20] [Modules] Remove hardcoded path to imported module in BMIs

Close https://github.com/llvm/llvm-project/issues/62707

As we discussed before, we'll forbid the use of implicit generated path
for C++20 modules. And as I mentioned in
https://github.com/llvm/llvm-project/issues/62707, we've emitted a
warning for clang17 and we'll make it a hard error in clang18. And the
patch addresses the decision.

2024-01-12 13:47:59 +08:00

Iain Sandoe

bc2a6defc8

[C++20][Modules] Allow for redeclarations in partitions.

The existing provision is not sufficient, it did not allow for the cases
where an implementation partition includes the primary module interface,
or for the case that an exported interface partition is contains a decl
that is then implemented in a regular implementation unit.

It is somewhat unfortunate that we have to compare top level module names
to achieve this, since built modules are not necessarily available.

TODO: It might be useful to cache a hash of the primary module name if
this test proves to be a  significant load.

Differential Revision: https://reviews.llvm.org/D127624

2022-07-08 19:02:59 +01:00

2 Commits