12 Commits

Author SHA1 Message Date
Duo Wang
b2477765db
[clang][test] Fix instantiation-depth-default.cpp under ubsan config on Windows (#91021)
Clang test `instantiation-depth-default.cpp` fails on Windows when built
with `ubsan` due to extra warnings printed by the compiler:
```console
File instantiation-depth-default.cpp Line 11: stack nearly exhausted; compilation time may suffer, and crashes due to stack overflow are likely
```

Originally in https://github.com/llvm/llvm-project/pull/75254 this test
was enabled for `asan` as well but later started to cause failures in
Linux ASAN buildbots. I have excluded `asan` from this change.
2024-05-07 16:51:12 +01:00
Mitch Phillips
bcac3edac8 Revert "[NFC][clang][test][asan] Make instantiation-depth-default.cpp a valid test case under asan and ubsan configs (#75254)"
Disables the recursive template expansion test under ASan again. This
patch re-enabled this test with sanitizers, but it's started spuriously
failing with a stack overflow again on AArch64+ASan:
https://lab.llvm.org/buildbot/#/builders/239/builds/6363

This reverts commit c458f928fad7bbcf08ab1da9949eb2969fc9f89c.
2024-04-02 16:15:45 +02:00
Duo Wang
c458f928fa
[NFC][clang][test][asan] Make instantiation-depth-default.cpp a valid test case under asan and ubsan configs (#75254)
Clang test `instantiation-depth-default.cpp` fails on Windows when built
with `ubsan` due to extra warnings printed by the compiler:
```console
File instantiation-depth-default.cpp Line 11: stack nearly exhausted; compilation time may suffer, and crashes due to stack overflow are likely
```
The test case was disabled for `asan` in 571a647 because of the extra
stack usage. Since `ubsan` also increases stack usage, seems like the
two configs should be treated uniformly.

On the other hand, we might be able to re-enable this test case for
`asan`. During some preliminary testing on Windows, Linux, and macOS
with the host compiler being as old as clang-10, the test case exited
successfully if the `stack-exhausted` warnings are suppressed, though I
haven't done exhaustive testing across platforms and clang versions. Any
insights into whether this change will introduce any risks to existing
buildbots is appreciated.

Enabling this test case for `asan` helps to improve our test coverage,
but if it causes problems on any buildbot, marking it as unsupported for
`ubsan` is also a viable solution.
2024-01-05 09:59:26 +00:00
Fangrui Song
0aa4af711e [Driver] Change some Separate CC1 options to use the Joined = form
-f{constexpr,macro,template}-backtrace-limit=, -fspell-checking-limit=, -ftemplate-depth=
2023-06-06 13:50:04 -07:00
Paul Robinson
f2c0c7299b [Windows] Convert clang/test/Modules tests to check 'target=<triple>'
Part of the project to eliminate special handling for triples in lit
expressions.
2022-11-29 12:17:36 -08:00
Eric Christopher
259a9b1039 Update line number after previous patch added an additional unsupported
and comment lines.
2019-12-12 14:45:05 -08:00
Michał Górny
4c6c1d0f43 [clang] [test] Disable the test exhausting stack on NetBSD
Disable the instantiation-depth-default.cpp test on NetBSD since it
requires more stack space than we have by default on NetBSD.

Differential Revision: https://reviews.llvm.org/D71419
2019-12-12 22:23:20 +01:00
Paul Robinson
d5d4df98bb Replace 'REQUIRES: not_?san' with 'UNSUPPORTED: ?san' as that better
expresses the intent of the exclusion.

llvm-svn: 360447
2019-05-10 17:57:22 +00:00
Petr Hosek
eb46c95c3e [CMake] Use normalized Windows target triples
Changes the default Windows target triple returned by
GetHostTriple.cmake from the old environment names (which we wanted to
move away from) to newer, normalized ones. This also requires updating
all tests to use the new systems names in constraints.

Differential Revision: https://reviews.llvm.org/D47381

llvm-svn: 339307
2018-08-09 02:16:18 +00:00
NAKAMURA Takumi
c37dc82d0b Disable clang/test/SemaTemplate/instantiation-depth-default.cpp temporarily for targeting mingw32. It crashes. Investigating.
llvm-svn: 280104
2016-08-30 15:38:18 +00:00
Richard Smith
571a647853 Disable test under asan: it uses a lot of stack, and asan increases the
per-frame stack usage enough to cause it to hit our stack limit. This is not
ideal; we should find a better way of dealing with this, such as increasing
our stack allocation when built with ASan.

llvm-svn: 279668
2016-08-24 21:30:00 +00:00
Richard Smith
269762dad3 Add test missed from r278983.
llvm-svn: 278984
2016-08-17 21:42:10 +00:00