4 Commits

Author SHA1 Message Date
Roman Lebedev
08cb876024
[NFC] Port all GlobalDCE tests to -passes= syntax 2022-12-08 02:38:44 +03:00
Matt Arsenault
8570893cfd GlobalDCE: Convert tests to opaque pointers
The script mangled both virtual-functions-base-pointer-call.ll and
virtual-functions-derived-pointer-call.ll pretty badly, deleting the
run line and most of the block comment.

Replaced the bitcast with and addrspacecast in 2002-07-17-CastRef.ll,
based on the apparent intent of the test.

For 2003-07-01-SelfReference.ll, the script produced "call ptr ()
@getfunc" which surprisingly parses as valid.
2022-11-27 21:07:27 -05:00
Kuba Mracek
6b53ad298e [GlobalDCE] [VFE] Avoid dropping vfunc dependencies when an invalid vtable entry is present
When we scan vtables for a particular vload in ScanVTableLoad and an entry in
one possible vtable is invalid (null or non-fptr), we bail in a wrong way -- we
completely stop the scanning of vtables and this results in dropped dependencies
and incorrectly removed vfuncs from vtables. Let's fix that by correcting the
bailing logic to keep iterating and only skip the invalid entries.

Differential Revision: https://reviews.llvm.org/D120006
2022-02-17 19:41:46 -08:00
Kuba Mracek
21e5a5f0cf [GlobalDCE] [VFE] Add a test for incorrect VFE behavior in presence of null/invalid vtable entries
Add a test for VFE where there's several vtables, and one of them contains an
invalid entry (from VFE's perspective), and which causes VFE to incorrectly skip
scanning subsequent vtables and drop their dependencies.
2022-02-17 10:46:54 -08:00