Craig Topper
cbce6e9e63
[C++11] Add 'override' keyword to virtual methods that override their base class.
...
llvm-svn: 203543
2014-03-11 06:22:39 +00:00
Craig Topper
3164f33f8f
[C++11] Add 'override' keyword to virtual methods that override their base class.
...
llvm-svn: 203537
2014-03-11 03:39:26 +00:00
Aaron Ballman
8cbf633715
[C++11] Adding override specifiers where appropriate, and removing virtual specifiers where not needed.
...
No functional changes intended.
llvm-svn: 203122
2014-03-06 15:09:50 +00:00
Aaron Ballman
8f1439bd0c
[C++11] Using std::unique_ptr to ensure that Argument objects do not leak (since clang-tblgen isn't long-lived, the old leak is probably acceptable, but it offended my senses nonetheless).
...
llvm-svn: 202989
2014-03-05 16:49:55 +00:00
Benjamin Kramer
9299637dc0
Pass llvm::Triple objects by const reference.
...
Copying isn't cheap as it contains a std::string.
llvm-svn: 202880
2014-03-04 19:31:42 +00:00
Chandler Carruth
757fcd6d1f
[cleanup] Re-sort includes with llvm/utils/sort_includes.py and fix
...
a missing include from CLog.h.
CLog.h referenced most of the core libclang types but never directly
included Index.h that provides them. Previously it got lucky and other
headers were always included first but with the sorting it ended up
first in one case and stopped compiling. Adding the Index.h include
fixes it right up.
llvm-svn: 202810
2014-03-04 10:05:20 +00:00
Aaron Ballman
b097f7fe9a
Simplifying attribute generation with range-based for loops. No functional changes intended.
...
llvm-svn: 202654
2014-03-02 17:38:37 +00:00
Benjamin Kramer
167e999be9
[C++11] Replace llvm::next and llvm::prior with std::next and std::prev.
...
llvm-svn: 202635
2014-03-02 12:20:24 +00:00
Aaron Ballman
ea6668c4e8
Moving the documentation for the type safety checking attributes into AttrDocs. If a custom heading is provided, do not automatically generate the alternate spelling list. This is necessary because some attributes have distinct semantic spellings and meanings, but use the same semantic attribute internally. Such attributes should have multiple elements in their documentation list, but not show all spellings. At some point, it would be nice to have a way to attach the documentation element to a specific spelling for these cases.
...
llvm-svn: 201851
2014-02-21 14:14:04 +00:00
Aaron Ballman
4de1b584cd
Refactored the way attribute category headers are handled so that it is possible to use custom categories. This allows for moving the consumable attributes (consumable, callable_when, return_typestate, etc) to be grouped together, with a content heading, like they were in the language extensions documentation. Moved the consumable attribute documentation from the language extensions into the attribute documentation table.
...
llvm-svn: 201732
2014-02-19 22:59:32 +00:00
Aaron Ballman
c7962868a2
Added a documentation category for statement attributes so that things like clang::fallthrough can be documented.
...
llvm-svn: 201714
2014-02-19 20:55:42 +00:00
Aaron Ballman
06bd44b3e8
Forcing it to be an error when there is no Documentation list specified for an attribute. This is a bit of a (harmless) hack, but the FIXME explains why and when this hack can be removed. It's a justified hack because this prevents attribute authors from forgetting to add documentation when they add a new attribute.
...
llvm-svn: 201524
2014-02-17 18:23:02 +00:00
Aaron Ballman
1a3e5858b9
The default assignment operator could not be generated by all of the bots, but it's required by std::vector to operate properly.
...
llvm-svn: 201518
2014-02-17 16:18:32 +00:00
Aaron Ballman
51d40111b4
Removing a C++11'ism to also fix the build bots.
...
llvm-svn: 201517
2014-02-17 15:59:37 +00:00
Aaron Ballman
a66b574b28
Fixing build bot breakage due to using a local type as a template argument.
...
llvm-svn: 201516
2014-02-17 15:36:08 +00:00
Aaron Ballman
97dba048a3
Implements a declarative approach to documenting individual attributes in Clang via a Documentation tablegen class. Also updates the internals manual with information about how to use this new, required, documentation feature.
...
This patch adds some very, very sparse initial documentation for some attributes. Additional effort from attribute authors is greatly appreciated.
llvm-svn: 201515
2014-02-17 15:27:10 +00:00
Reid Kleckner
f06b266bfa
Attributes: Avoid a big useless copy in the emitter
...
llvm-svn: 201251
2014-02-12 19:26:24 +00:00
Reid Kleckner
f526b94858
Attributes: Emit enumerators in td file declaration order
...
llvm-svn: 201246
2014-02-12 18:22:18 +00:00
David Majnemer
4bb0980d96
MS ABI: Add support for #pragma pointers_to_members
...
Introduce a notion of a 'current representation method' for
pointers-to-members.
When starting out, this is set to 'best case' (representation method is
chosen by examining the class, selecting the smallest representation
that would work given the class definition or lack thereof).
This pragma allows the translation unit to dictate exactly what
representation to use, similar to how the inheritance model keywords
operate.
N.B. PCH support is forthcoming.
Differential Revision: http://llvm-reviews.chandlerc.com/D2723
llvm-svn: 201105
2014-02-10 19:50:15 +00:00
Aaron Ballman
35db2b3d4c
Consolidating several table-generated files containing parser-related string switches into a single file. This reduces build-related complexity by replacing four separate projects (and table-gen instantiations) with a single one.
...
No functional changes intended.
llvm-svn: 200424
2014-01-29 22:13:45 +00:00
Aaron Ballman
c669cc0d77
Add a new attribute meta-spelling called "GCC" -- it widens into being a GNU spelling, and a CXX11 spelling with the namespace "gnu". It also sets a bit on the spelling certifying that it is known to GCC. From this, we can warn about the extension appropriately. As a consequence, the FunctionDefinition functionality is completely removed.
...
Replacing the functionality from r199676, which didn't solve the problem as elegantly.
llvm-svn: 200252
2014-01-27 22:10:04 +00:00
Aaron Ballman
81cb8cbfa6
Adds a getSemanticSpelling function to semantic attribute subclasses which have a meaningful semantic spelling. Adds a sibling function to parsed attribtues (via AttributeList) for getting the semantic spelling, if one were to exist. This can be used for cleaner code that deals directly with the semantic spellings (such as the MSInheritance attribute).
...
llvm-svn: 200041
2014-01-24 21:32:49 +00:00
Aaron Ballman
bc909618f2
If an attribute has a semantically meaningful spelling (such as ArgumentWithTypeTagAttr or MSInheritanceAttr), display the spelling used for the attribute as part of the AST dump. This should ease debugging the AST for these attributes. Attributes without semantically meaningful spelling variations are not affected.
...
llvm-svn: 199834
2014-01-22 21:51:20 +00:00
Aaron Ballman
b9023ed0f6
Exposed a declarative way to specify that an attribute can be duplicated when merging attributes on a declaration. This replaces some hard-coded functionality from Sema.
...
llvm-svn: 199677
2014-01-20 18:07:09 +00:00
Aaron Ballman
9a99e0da5a
Remove some hard-coded specialness for thread-safety attributes from the parser, and made it more declarative. If an attribute is allowed to appear on a function definition when late parsed, it can now use the FunctionDefinition attribute subject. It's treated as a FunctionDecl for most purposes, except it also gets exposed on the AttributeList so that it can be used while parsing.
...
llvm-svn: 199676
2014-01-20 17:18:35 +00:00
Alp Toker
96cf758d3a
Fix comment typos
...
llvm-svn: 199563
2014-01-18 21:49:37 +00:00
Aaron Ballman
07c3d53c88
When generating Spelling enumeration values, do not generate identifiers in the reserved namespace. Strip underscores as appropriate, taking care to not create duplicate identifiers.
...
llvm-svn: 199414
2014-01-16 19:44:01 +00:00
Aaron Ballman
4755304fd1
Fixing a warning that causes the sanitizer build disliked about mixing && and ||. Since this is generated code, the && has been removed from the expression entirely.
...
llvm-svn: 199392
2014-01-16 14:32:03 +00:00
Aaron Ballman
12b9f6535b
Factored some function-like type reasoning out of SemaDeclAttr and onto Decl itself. This allows for more declarative subjects in attribute tablegen where the attribute appertains to something function-like, but not strictly a FunctionDecl.
...
llvm-svn: 199387
2014-01-16 13:55:42 +00:00
Aaron Ballman
36a5350e51
Distinguish between attributes explicitly written at the request of the user, and attributes implicitly generated to assist in bookkeeping by the compiler. This is done so by table generating a CreateImplicit method for each attribute.
...
Additionally, remove the optional nature of the spelling list index when creating attributes. This is supported by table generating a Spelling enumeration when the spellings for an attribute are distinct enough to warrant it.
llvm-svn: 199378
2014-01-16 13:03:14 +00:00
Aaron Ballman
09e98ffa5b
When determining the attribute's parsed kind, pay attention to the syntax used. This fixes bugs where an attribute has differing GNU and Declspec spellings, but they are treated as the same. Eg) __declspec(aligned) when it should be __attribute__((aligned)), and __attribute__((align)) when it should be __declspec(align).
...
llvm-svn: 199144
2014-01-13 21:42:39 +00:00
Aaron Ballman
0fa06d879a
__has_attribute now understands target-specific attributes. So when you ask whether an ARM target has the "interrupt" attribute, it will return true for ARM and MSP430 targets, and false for others.
...
llvm-svn: 198897
2014-01-09 22:57:44 +00:00
Aaron Ballman
ab7691c4ce
Removing the notion of TargetAttributesSema and replacing it with one where the parsed attributes are responsible for knowing their target-specific nature, instead of letting Sema figure it out. This is necessary so that __has_attribute can eventually determine whether a parsed attribute applies to the given target or not.
...
llvm-svn: 198896
2014-01-09 22:48:32 +00:00
Aaron Ballman
15b27b97b7
Removing a bit of custom parsing functionality used by the thread safety analysis APIs. Now using tablegen to determine whether an attribute's arguments should be parsed in an unevaluated context instead of relying on a separate, hard-coded list of attributes.
...
llvm-svn: 198883
2014-01-09 19:39:35 +00:00
Chandler Carruth
5553d0d4ca
Sort all the #include lines with LLVM's utils/sort_includes.py which
...
encodes the canonical rules for LLVM's style. I noticed this had drifted
quite a bit when cleaning up LLVM, so wanted to clean up Clang as well.
llvm-svn: 198686
2014-01-07 11:51:46 +00:00
Aaron Ballman
0e468c02bc
This helper method isn't needed, and it's unsafe for it to use StringRef in the first place. Replaced the unsafe code with the proper accessor.
...
llvm-svn: 198569
2014-01-05 21:08:29 +00:00
DeLesley Hutchins
bb79c338ed
Update DataRecursiveASTVisitor so that it visits attributes.
...
llvm-svn: 198249
2013-12-30 21:03:02 +00:00
DeLesley Hutchins
c4a82438a7
Update RecursiveASTVisitor so that it visits attributes. This is currently
...
important for thread safety attributes, which contain expressions that were
not being visited, and were thus invisible to various tools. There are now
Visit*Attr methods that can be overridden for every attribute.
llvm-svn: 198224
2013-12-30 17:24:36 +00:00
Aaron Ballman
3e424b5070
Teach the diagnostics engine about the Attr type to make reporting on semantic attributes easier (and not require hard-coded strings). This requires a getSpelling() function on the Attr class, which is table-driven. Updates a handful of cases where a hard-coded string was being used to test the functionality out. Updating associated test cases for the improved quoting.
...
llvm-svn: 198055
2013-12-26 18:30:57 +00:00
Aaron Ballman
aa47d24a47
Reverting r197715 -- it appears that MSVC is happy with the code, but clang is not.
...
llvm-svn: 197716
2013-12-19 19:39:25 +00:00
Aaron Ballman
ced10529fe
No longer leaking Argument objects after calling createArgument. However, since an OwningPtr cannot live in a std::vector yet, there are some manual deletions that have a FIXME attached to them. These will go away once C++11 support is allowed.
...
llvm-svn: 197715
2013-12-19 19:33:35 +00:00
Aaron Ballman
e615393356
Removing the SourceLocation unused attribute argument type.
...
llvm-svn: 197707
2013-12-19 18:10:57 +00:00
Aaron Ballman
8edb5c2081
Refactor the Microsoft inheritance attribute handling so that it no longer has special treatment. Also fixes a minor bug where the attributes were being parsed as though they were GNU-style attributes when they were in fact keyword attributes.
...
llvm-svn: 197629
2013-12-18 23:44:18 +00:00
Aaron Ballman
64e6986e39
Allow target-specific attributes to share a spelling between different attributes via the ParseKind field. Attributes will be given a common parsed attribute identifier (the AttributeList::AT_* enum), but retain distinct Attr subclasses.
...
This new functionality is used to implement the ARM and MSP430 interrupt attribute.
Patch reviewed by Richard Smith over IRC.
llvm-svn: 197343
2013-12-15 13:05:48 +00:00
Ted Kremenek
d980da2290
Enhance attribute machinery to include ObjCProtocols as "subjects" in attribute declarations.
...
llvm-svn: 196954
2013-12-10 19:43:42 +00:00
Aaron Ballman
00dcc43b56
Typo caught by Alp Toker: s/appertain/appertains
...
llvm-svn: 196273
2013-12-03 13:45:50 +00:00
Aaron Ballman
93b5cc6db8
Rectifying style issues with generated code. No functional change intended.
...
llvm-svn: 196142
2013-12-02 19:36:42 +00:00
Aaron Ballman
3aff633590
Automate attribute language option checking by specifying the list of options to test in tablegen.
...
llvm-svn: 196138
2013-12-02 19:30:36 +00:00
Aaron Ballman
604dfec8dc
Re-enabled support for the Subjects for the weak attribute. This changes the diagnostic involved to be more accurate -- for C++ code, it will now report that weak applies to variables, functions or classes. Added additional test case for this.
...
llvm-svn: 196120
2013-12-02 17:07:07 +00:00
Aaron Ballman
a358c9051e
Using the proper set key when determining whether a SubsetSubject helper method has been previously generated.
...
llvm-svn: 196103
2013-12-02 14:58:17 +00:00