4 Commits

Author	SHA1	Message	Date
Paul Robinson	7fc871591f	[unittests] Use GTEST_SKIP() instead of return when appropriate ... Basically NFC: A TEST/TEST_F/etc that bails out early (usually because setup failed or some other runtime condition wasn't met) generally should use GTEST_SKIP() to report its status correctly, unless it takes steps to report another status (e.g., FAIL()). I did see a handful of tests show up as SKIPPED after this change, which is not unexpected. The status seemed appropriate in all the new cases.	2023-01-25 13:59:01 -08:00
James Henderson	2150a6d0d6	[Object][unittest] Skip tests on machines with non-64 bit size_t ... Speculative fix for build bot failures such as http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/14317/	2020-03-11 15:31:30 +00:00
Hubert Tong	b94d4b1903	[unittests][Object] Use matching signedness for expected value ... Speculative fix for buildbot breakage: http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/1899/steps/ninja%20check%201/logs/stdio D75742 introduces checks that cause bots to complain about comparing values where the integer types mismatch on signedness. This patch makes the expected value unsigned in various cases (since the value being tested is unsigned).	2020-03-11 09:58:10 -04:00
James Henderson	326bc1da45	[Object] Fix handling of large archive members ... The archive library truncated the size of archive members whose size was greater than max uint32_t. This patch fixes the issue and adds some unit tests to verify. Reviewed by: ruiu, MaskRay, grimar, rupprecht Differential Revision: https://reviews.llvm.org/D75742	2020-03-11 10:29:45 +00:00