Markus Böck
78c033b541
[sanitizers][windows] Correctly override functions with backward jmps
...
To reproduce: Download and run the latest Firefox ASAN build (https://firefox-ci-tc.services.mozilla.com/api/index/v1/task/gecko.v2.mozilla-central.latest.firefox.win64-asan-opt/artifacts/public/build/target.zip ) on Windows 11 (version 10.0.22621 Build 22621); it will crash on launch. Note that this doesn't seem to crash on another Windows 11 VM I've tried, so I'm not sure how reproducible it is across machines, but it reproduces on my machine every time.
The problem seems to be that when overriding the memset function in OverrideFunctionWithRedirectJump(), the relative_offset is stored as a uptr. Per the Intel x64 instruction set reference (https://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-instruction-set-reference-manual-325383.pdf - warning: large PDF), on page 646 the jmp instruction (specifically the near jump flavors that start with E9, which are the ones the OverrideFunctionWithRedirectJump() considers) treats the offset as a signed displacement. This causes an incorrect value to be stored for REAL(memset) which points to uninitialized memory, and a crash the next time that gets called.
The fix is to simply treat that offset as signed. I have also added a test case.
Fixes https://github.com/llvm/llvm-project/issues/58846
Differential Revision: https://reviews.llvm.org/D137788
2022-12-12 11:45:43 +01:00
Mariusz Borsa
8246b2e156
[Sanitizers][Darwin] Replace SANITIZER_MAC with SANITIZER_APPLE in source files
...
This is a follow up to [Sanitizers][Darwin] Rename Apple macro SANITIZER_MAC -> SANITIZER_APPLE (D125816)
Performed a global search/replace as in title against LLVM sources
Differential Revision: https://reviews.llvm.org/D126263
2022-05-24 12:59:27 -07:00
Martin Storsjö
aa45fc41c8
[sanitizers] Silence warnings about unused variables in i386 build. NFC.
2022-01-28 12:30:38 +02:00
Alexandre Ganea
7cd109b92c
[asan] Additionnal prologue decoding for WinSDK 10.0.22000
...
Fixes interception of atoi() entry point.
2021-12-30 20:11:45 -05:00
Toshihito Kikuchi
22ea0cea59
[compiler-rt] [windows] Add more assembly patterns for interception
...
To intercept the functions in Win11's ntdll.dll, we need to use the trampoline
technique because there are bytes other than 0x90 or 0xcc in the gaps between
exported functions. This patch adds more patterns that appear in ntdll's
functions.
Bug: https://bugs.llvm.org/show_bug.cgi?id=51721
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D109941
2021-09-21 15:51:58 -07:00
Kazuaki Ishizaki
a1e7e401d2
[compiler-rt] NFC: Fix trivial typo
...
Reviewed By: xgupta
Differential Revision: https://reviews.llvm.org/D77457
2021-09-04 14:12:58 +05:30
Martin Storsjö
979c38cc74
[compiler-rt] [windows] Add UNUSED attributes on variables/functions only used for 64 bit targets
...
This fixes warnings when building for 32 bit targets.
Differential Revision: https://reviews.llvm.org/D91852
2021-01-05 08:59:08 +02:00
Vitaly Buka
d2af368aee
[compiler-rt] Remove some cpplint filters
...
llvm-svn: 371704
2019-09-12 02:20:36 +00:00
Nico Weber
ebbce04c14
compiler-rt: Rename .cc files in lib/interception to .cpp.
...
See https://reviews.llvm.org/D58620 for discussion, and for the commands
I ran. In addition I also ran
for f in $(svn diff | diffstat | grep .cc | cut -f 2 -d ' '); do rg $f . ; done
and manually updated references to renamed files found by that.
llvm-svn: 367456
2019-07-31 18:01:55 +00:00
