llvm-project

shylie/llvm-project

Fork 0

Commit Graph

Author	SHA1	Message	Date
nerix	b38ed00495	[LLDB][PDB] Relax check for resolving breakpoint (#169932 ) The test was flaky, because it assumed that the breakpoint was always resolved before `r` was executed (https://github.com/llvm/llvm-project/pull/169728#issuecomment-3589799783). This PR removes the check for this order. It still checks that the breakpoint is resolved before it is hit.	2025-11-28 18:14:59 +01:00
nerix	cc72171322	[LLDB][PDB] Access object file through module (#169728 ) When a PDB is loaded through `target symbols add <pdb-path>`, its `m_objectfile_sp` is an `ObjectFilePDB` instead of `ObjectFilePECOFF` (the debugged module). In both the native and DIA plugin, some paths assumed that `m_objectfile_sp` is the debugged module. With this PR, they go through `m_objfile_sp->GetModule()->GetObjectFile()`. For the DIA plugin, this lead to an assertion failure (https://github.com/llvm/llvm-project/issues/169628#issuecomment-3582555277) and for both plugins, it meant that the symbol table wasn't loaded.	2025-11-28 14:58:32 +01:00

Author

SHA1

Message

Date

nerix

b38ed00495

[LLDB][PDB] Relax check for resolving breakpoint (#169932 )

The test was flaky, because it assumed that the breakpoint was always
resolved before `r` was executed
(https://github.com/llvm/llvm-project/pull/169728#issuecomment-3589799783).
This PR removes the check for this order. It still checks that the
breakpoint is resolved before it is hit.

2025-11-28 18:14:59 +01:00

nerix

cc72171322

[LLDB][PDB] Access object file through module (#169728 )

When a PDB is loaded through `target symbols add <pdb-path>`, its
`m_objectfile_sp` is an `ObjectFilePDB` instead of `ObjectFilePECOFF`
(the debugged module). In both the native and DIA plugin, some paths
assumed that `m_objectfile_sp` is the debugged module. With this PR,
they go through `m_objfile_sp->GetModule()->GetObjectFile()`.

For the DIA plugin, this lead to an assertion failure
(https://github.com/llvm/llvm-project/issues/169628#issuecomment-3582555277)
and for both plugins, it meant that the symbol table wasn't loaded.

2025-11-28 14:58:32 +01:00

2 Commits