shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
136,553 Commits 1,712 Branches 298 Tags
Commit Graph

108 Commits

Author SHA1 Message Date
Chandler Carruth
7ec5085e01 Revert the series of commits starting with r166578 which introduced the 
getIntPtrType support for multiple address spaces via a pointer type,
and also introduced a crasher bug in the constant folder reported in
PR14233.

These commits also contained several problems that should really be
addressed before they are re-committed. I have avoided reverting various
cleanups to the DataLayout APIs that are reasonable to have moving
forward in order to reduce the amount of churn, and minimize the number
of commits that were reverted. I've also manually updated merge
conflicts and manually arranged for the getIntPtrType function to stay
in DataLayout and to be defined in a plausible way after this revert.

Thanks to Duncan for working through this exact strategy with me, and
Nick Lewycky for tracking down the really annoying crasher this
triggered. (Test case to follow in its own commit.)

After discussing with Duncan extensively, and based on a note from
Micah, I'm going to continue to back out some more of the more
problematic patches in this series in order to ensure we go into the
LLVM 3.2 branch with a reasonable story here. I'll send a note to
llvmdev explaining what's going on and why.

Summary of reverted revisions:

r166634: Fix a compiler warning with an unused variable.
r166607: Add some cleanup to the DataLayout changes requested by
         Chandler.
r166596: Revert "Back out r166591, not sure why this made it through
         since I cancelled the command. Bleh, sorry about this!
r166591: Delete a directory that wasn't supposed to be checked in yet.
r166578: Add in support for getIntPtrType to get the pointer type based
         on the address space.
llvm-svn: 167221
 2012-11-01 08:07:29 +00:00
Duncan Sands
e2395dc27b Fix isEliminableCastPair to work correctly in the presence of pointers 
with different sizes.

llvm-svn: 167018
 2012-10-30 16:03:32 +00:00
Micah Villmow
12d9127833 Add in support for getIntPtrType to get the pointer type based on the address space. 
This checkin also adds in some tests that utilize these paths and updates some of the
clients.

llvm-svn: 166578
 2012-10-24 15:52:52 +00:00
Micah Villmow
4bb926d91d Resubmit the changes to llvm core to update the functions to support different pointer sizes on a per address space basis. 
llvm-svn: 165941
 2012-10-15 16:24:29 +00:00
Micah Villmow
0c61134d8d Revert 165732 for further review. 
llvm-svn: 165747
 2012-10-11 21:27:41 +00:00
Micah Villmow
083189730e Add in the first iteration of support for llvm/clang/lldb to allow variable per address space pointer sizes to be optimized correctly. 
llvm-svn: 165726
 2012-10-11 17:21:41 +00:00
Micah Villmow
cdfe20b97f Move TargetData to DataLayout. 
llvm-svn: 165402
 2012-10-08 16:38:25 +00:00
Sylvestre Ledru
91ce36c986 Revert 'Fix a typo 'iff' => 'if''. iff is an abreviation of if and only if. See: http://en.wikipedia.org/wiki/If_and_only_if Commit 164767 
llvm-svn: 164768
 2012-09-27 10:14:43 +00:00
Sylvestre Ledru
721cffd53a Fix a typo 'iff' => 'if' 
llvm-svn: 164767
 2012-09-27 09:59:43 +00:00
Jakob Stoklund Olesen
c5c4e96f3e Revert remaining part of r93200: "Disable folding sext(trunc(x)) -> x" 
This fixes PR5997.

These transforms were disabled because codegen couldn't deal with other
uses of trunc(x). This is now handled by the peephole pass.

This causes no regressions on x86-64.

llvm-svn: 159003
 2012-06-22 16:36:43 +00:00
Nuno Lopes
3fa32f2452 replace usage of EmitGEPOffset() with TargetData::getIndexedOffset() when the GEP offset is known to be constant. 
With this change, we avoid relying on the IR Builder to constant fold the operations.

No functionality change intended.

llvm-svn: 158829
 2012-06-20 17:30:51 +00:00
Stepan Dyatkovskiy
cb2a1a34e2 Small fix in InstCombineCasts.cpp. Restored "alloca + bitcast" reducing for case when alloca's size is calculated within the "add/sub/... nsw". 
Also added fix to 2011-06-13-nsw-alloca.ll test.

llvm-svn: 156231
 2012-05-05 07:09:40 +00:00
Rafael Espindola
ba0a6cabb8 Always compute all the bits in ComputeMaskedBits. 
This allows us to keep passing reduced masks to SimplifyDemandedBits, but
know about all the bits if SimplifyDemandedBits fails. This allows instcombine
to simplify cases like the one in the included testcase.

llvm-svn: 154011
 2012-04-04 12:51:34 +00:00
Chris Lattner
8213c8af29 Remove some dead code and tidy things up now that vectors use ConstantDataVector 
instead of always using ConstantVector.

llvm-svn: 149912
 2012-02-06 21:56:39 +00:00
David Blaikie
46a9f016c5 More dead code removal (using -Wunreachable-code) 
llvm-svn: 148578
 2012-01-20 21:51:11 +00:00
Dan Gohman
518cda42b9 The powers that be have decided that LLVM IR should now support 16-bit 
"half precision" floating-point with a first-class type.

This patch adds basic IR support (but not codegen support).

llvm-svn: 146786
 2011-12-17 00:04:22 +00:00
Chad Rosier
e6de63dfc5 Last bit of TargetLibraryInfo propagation. Also fixed a case for TargetData 
where it appeared beneficial to pass.
More of rdar://10500969

llvm-svn: 145630
 2011-12-01 21:29:16 +00:00
Chad Rosier
385d9f6c24 Whitespace. 
llvm-svn: 145470
 2011-11-30 01:59:59 +00:00
Chad Rosier
82e1bd8e94 Add support for sqrt, sqrtl, and sqrtf in TargetLibraryInfo. Disable 
(fptrunc (sqrt (fpext x))) -> (sqrtf x) transformation if -fno-builtin is 
specified.
rdar://10466410

llvm-svn: 145460
 2011-11-29 23:57:10 +00:00
Benjamin Kramer
547b6c5ecd Stop emitting instructions with the name "tmp" they eat up memory and have to be uniqued, without any benefit. 
If someone prefers %tmp42 to %42, run instnamer.

llvm-svn: 140634
 2011-09-27 20:39:19 +00:00
Nadav Rotem
5fc81ffbac Fixes following the CR by Chris and Duncan: 
Optimize chained bitcasts of the form A->B->A.
Undo r138722 and change isEliminableCastPair to allow this case.

llvm-svn: 138756
 2011-08-29 19:58:36 +00:00
Nadav Rotem
52600ee8c3 Bitcasts are transitive. Bitcast-Bitcast-X becomes Bitcast-X. 
llvm-svn: 138722
 2011-08-28 11:51:08 +00:00
Jay Foad
d1b7849d49 Convert GetElementPtrInst to use ArrayRef. 
llvm-svn: 135904
 2011-07-25 09:48:08 +00:00
Jay Foad
040dd82f44 Convert IRBuilder::CreateGEP and IRBuilder::CreateInBoundsGEP to use 
ArrayRef.

llvm-svn: 135761
 2011-07-22 08:16:57 +00:00
Eli Friedman
911e12f505 Clean up includes of llvm/Analysis/ConstantFolding.h so it's included where it's used and not included where it isn't. 
llvm-svn: 135628
 2011-07-20 21:57:23 +00:00
Chris Lattner
229907cd11 land David Blaikie's patch to de-constify Type, with a few tweaks. 
llvm-svn: 135375
 2011-07-18 04:54:35 +00:00
Evan Cheng
b94674b325 It's not safe to fold (fptrunc (sqrt (fpext x))) to (sqrtf x) if there is another use of sqrt. rdar://9763193 
llvm-svn: 135058
 2011-07-13 19:08:16 +00:00
Bob Wilson
3c68b626e7 Reapply a fixed version of r133285. 
This tightens up checking for overflow in alloca sizes, based on feedback
from Duncan and John about the change in r132926.

llvm-svn: 134749
 2011-07-08 22:09:33 +00:00
Chad Rosier
c76b9d8c2f Revert r133285. Causing odd failures on Dragonegg. 
llvm-svn: 133301
 2011-06-17 22:08:25 +00:00
Stuart Hastings
23be986a0c Relocate NUW test to cover all binary ops in a dynamic alloca expr. 
Followup to 132926.  rdar://problem/9265821

llvm-svn: 133285
 2011-06-17 20:21:52 +00:00
Stuart Hastings
351a3f881f Avoid fusing bitcasts with dynamic allocas if the amount-to-allocate 
might overflow.  Re-typing the alloca to a larger type (e.g. double)
hoists a shift into the alloca, potentially exposing overflow in the
expression.  rdar://problem/9265821

llvm-svn: 132926
 2011-06-13 18:48:49 +00:00
Eli Friedman
35211c6091 Final step of instcombine debuginfo; switch a couple more places over to InsertNewInstWith, and use setDebugLoc for the cases which can't be easily handled by the automated mechanisms. 
llvm-svn: 132167
 2011-05-27 00:19:40 +00:00
Eli Friedman
1754a25977 More instcombine simplifications towards better debug locations. 
llvm-svn: 131596
 2011-05-18 23:11:30 +00:00
Eli Friedman
b9ed18f2cb Use ReplaceInstUsesWith instead of replaceAllUsesWith where appropriate in instcombine. 
llvm-svn: 131512
 2011-05-18 00:32:01 +00:00
Benjamin Kramer
50a281a871 While SimplifyDemandedBits constant folds this, we can't rely on it here. 
It's possible to craft an input that hits the recursion limits in a way
that SimplifyDemandedBits doesn't simplify the icmp but ComputeMaskedBits
can infer which bits are zero.

No test case as it depends on too many other things. Fixes PR9609.

llvm-svn: 128777
 2011-04-02 18:50:58 +00:00
Benjamin Kramer
8b94c295c3 Fix comment. 
llvm-svn: 128745
 2011-04-01 22:29:18 +00:00
Benjamin Kramer
5cad45307e Tweaks to the icmp+sext-to-shifts optimization to address Frits' comments: 
- Localize the check if an icmp has one use to a place where we know we're
  introducing something that's likely more expensive than a sext from i1.
- Add an assert to make sure a case that would lead to a miscompilation is
  folded away earlier.
- Fix a typo.

llvm-svn: 128744
 2011-04-01 22:22:11 +00:00
Benjamin Kramer
ac2d5657a6 Fix build. 
llvm-svn: 128733
 2011-04-01 20:15:16 +00:00
Benjamin Kramer
d121765e64 InstCombine: Turn icmp + sext into bitwise/integer ops when the input has only one unknown bit. 
int test1(unsigned x) { return (x&8) ? 0 : -1; }
int test3(unsigned x) { return (x&8) ? -1 : 0; }

before (x86_64):
_test1:
	andl	$8, %edi
	cmpl	$1, %edi
	sbbl	%eax, %eax
	ret
_test3:
	andl	$8, %edi
	cmpl	$1, %edi
	sbbl	%eax, %eax
	notl	%eax
	ret

after:
_test1:
	shrl	$3, %edi
	andl	$1, %edi
	leal	-1(%rdi), %eax
	ret
_test3:
	shll	$28, %edi
	movl	%edi, %eax
	sarl	$31, %eax
	ret

llvm-svn: 128732
 2011-04-01 20:09:10 +00:00
Benjamin Kramer
398b8c5faf InstCombine: Move (sext icmp) transforms into their own method. No intended functionality change. 
llvm-svn: 128731
 2011-04-01 20:09:03 +00:00
Jay Foad
52131344a2 Remove PHINode::reserveOperandSpace(). Instead, add a parameter to 
PHINode::Create() giving the (known or expected) number of operands.

llvm-svn: 128537
 2011-03-30 11:28:46 +00:00
Jay Foad
e0938d8a87 (Almost) always call reserveOperandSpace() on newly created PHINodes. 
llvm-svn: 128535
 2011-03-30 11:19:20 +00:00
Devang Patel
fbb482b314 llvm.dbg.declare intrinsic does not use any llvm::Values. It's magic! 
llvm-svn: 127282
 2011-03-08 22:12:11 +00:00
Chris Lattner
69229316aa convert ConstantVector::get to use ArrayRef. 
llvm-svn: 125537
 2011-02-15 00:14:00 +00:00
Chris Lattner
34442e6ebf revert my ConstantVector patch, it seems to have made the llvm-gcc 
builders unhappy.

llvm-svn: 125504
 2011-02-14 18:15:46 +00:00
Chris Lattner
d9f5b88548 Switch ConstantVector::get to use ArrayRef instead of a pointer+size 
idiom.  Change various clients to simplify their code.

llvm-svn: 125487
 2011-02-14 07:55:32 +00:00
Chris Lattner
9c10d587f6 implement an instcombine xform that canonicalizes casts outside of and-with-constant operations. 
This fixes rdar://8808586 which observed that we used to compile:


union xy {
        struct x { _Bool b[15]; } x;
        __attribute__((packed))
        struct y {
                __attribute__((packed)) unsigned long b0to7;
                __attribute__((packed)) unsigned int b8to11;
                __attribute__((packed)) unsigned short b12to13;
                __attribute__((packed)) unsigned char b14;
        } y;
};

struct x
foo(union xy *xy)
{
        return xy->x;
}

into:

_foo:                                   ## @foo
	movq	(%rdi), %rax
	movabsq	$1095216660480, %rcx    ## imm = 0xFF00000000
	andq	%rax, %rcx
	movabsq	$-72057594037927936, %rdx ## imm = 0xFF00000000000000
	andq	%rax, %rdx
	movzbl	%al, %esi
	orq	%rdx, %rsi
	movq	%rax, %rdx
	andq	$65280, %rdx            ## imm = 0xFF00
	orq	%rsi, %rdx
	movq	%rax, %rsi
	andq	$16711680, %rsi         ## imm = 0xFF0000
	orq	%rdx, %rsi
	movl	%eax, %edx
	andl	$-16777216, %edx        ## imm = 0xFFFFFFFFFF000000
	orq	%rsi, %rdx
	orq	%rcx, %rdx
	movabsq	$280375465082880, %rcx  ## imm = 0xFF0000000000
	movq	%rax, %rsi
	andq	%rcx, %rsi
	orq	%rdx, %rsi
	movabsq	$71776119061217280, %r8 ## imm = 0xFF000000000000
	andq	%r8, %rax
	orq	%rsi, %rax
	movzwl	12(%rdi), %edx
	movzbl	14(%rdi), %esi
	shlq	$16, %rsi
	orl	%edx, %esi
	movq	%rsi, %r9
	shlq	$32, %r9
	movl	8(%rdi), %edx
	orq	%r9, %rdx
	andq	%rdx, %rcx
	movzbl	%sil, %esi
	shlq	$32, %rsi
	orq	%rcx, %rsi
	movl	%edx, %ecx
	andl	$-16777216, %ecx        ## imm = 0xFFFFFFFFFF000000
	orq	%rsi, %rcx
	movq	%rdx, %rsi
	andq	$16711680, %rsi         ## imm = 0xFF0000
	orq	%rcx, %rsi
	movq	%rdx, %rcx
	andq	$65280, %rcx            ## imm = 0xFF00
	orq	%rsi, %rcx
	movzbl	%dl, %esi
	orq	%rcx, %rsi
	andq	%r8, %rdx
	orq	%rsi, %rdx
	ret

We now compile this into:

_foo:                                   ## @foo
## BB#0:                                ## %entry
	movzwl	12(%rdi), %eax
	movzbl	14(%rdi), %ecx
	shlq	$16, %rcx
	orl	%eax, %ecx
	shlq	$32, %rcx
	movl	8(%rdi), %edx
	orq	%rcx, %rdx
	movq	(%rdi), %rax
	ret

A small improvement :-)

llvm-svn: 123520
 2011-01-15 06:32:33 +00:00
Bill Wendling
5e3605552e Whitespace fixes. No functionality change. 
llvm-svn: 122110
 2010-12-17 23:27:41 +00:00
Nate Begeman
7aa18bf46a Add vector versions of some existing scalar transforms to aid codegen in matching psign & pblend operations to the IR produced by clang/gcc for their C idioms. 
llvm-svn: 122105
 2010-12-17 23:12:19 +00:00
Chris Lattner
6e27b3e004 Fix a serious performance regression introduced by r108687 on linux: 
turning (fptrunc (sqrt (fpext x))) -> (sqrtf x)  is great, but we have
to delete the original sqrt as well.  Not doing so causes us to do 
two sqrt's when building with -fmath-errno (the default on linux).

llvm-svn: 113260
 2010-09-07 20:01:38 +00:00