3 Commits

Author SHA1 Message Date
Joel E. Denny
a89a54190c Fix test introduced by d29fdfbc4e3b
It breaks builds like:

https://lab.llvm.org/buildbot/#/builders/190/builds/744
2024-06-26 15:36:00 -04:00
Joel E. Denny
d29fdfbc4e
[LTO] Avoid assert fail on failed pass plugin load (#96691)
Without this patch, passing -load-pass-plugin=nonexistent.so to
llvm-lto2 produces a backtrace because LTOBackend.cpp does not handle
the error correctly:

```
Failed to load passes from 'nonexistant.so'. Request ignored.
Expected<T> must be checked before access or destruction.
Unchecked Expected<T> contained error:
Could not load library 'nonexistant.so': nonexistant.so: cannot open shared object file: No such file or directoryPLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
```

Any tool using `lto::Config::PassPlugins` should suffer similarly.

Based on the message "Request ignored" and the continue statement, the
intention was apparently to continue on failure to load a plugin.
However, no one appears to rely on that behavior now given that it
crashes instead, and terminating is consistent with opt.
2024-06-26 14:51:24 -04:00
Arthur Eubanks
8fe7e88386
[opt] Properly report errors when loading pass plugins (#69745)
All error messages here already contain the path to the plugin, so no
need to repeat it in opt.cpp.
2023-10-23 09:55:29 -07:00