shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity
525,695 Commits 1,713 Branches 298 Tags
Commit Graph

186 Commits

Author SHA1 Message Date
Timm Baeder
a34a087fc5
[clang][bytecode] Handle non-primitive vector element types (#124926) 
By rejecting them. We would crash before.
 2025-01-29 16:39:02 +01:00
Timm Baeder
51c7338cc6
[clang][bytecode] Fix dummy handling for p2280r4 (#124396) 
This makes some other problems show up like the fact that we didn't
suppress diagnostics during __builtin_constant_p evaluation.
 2025-01-29 09:32:35 +01:00
Timm Baeder
2c934dc5e1
[clang][bytecode] Always compile most recent function decl (#124722) 2025-01-28 11:43:02 +01:00
Timm Baeder
e6030d3895
[clang][bytecode] Use std::allocator calls for Descriptor source (#123900) 
... for the dynamic blocks created for operator new calls. This way we
get the type of memory allocated right. As a side-effect, the
diagnostics now point to the std::allocator calls, which is an
improvement.
 2025-01-24 11:50:56 +01:00
Timm Baeder
886adf8fb3
[clang][ExprConst] Let diagnostics point to std::allocator calls (#123744) 
Instead of the underlying operator new calls. This fixes a longstanding
FIXME comment in cxx2a-constexpr-dynalloc.cpp.
 2025-01-24 08:40:49 +01:00
Corentin Jabot
28c819cf8c [Clang] Fix tests broken by 0a9c08c 2025-01-22 10:32:54 +01:00
Timm Baeder
e8674af6f4
[clang][bytecode] Diagnose IntegralToPointer casts to non-void (#123619) 
But keep evaluating. This is what the current interpreter does as well.
 2025-01-20 17:41:18 +01:00
Timm Baeder
d70f54f248
[clang][bytecode] Fix reporting failed local constexpr initializers (#123588) 
We need to emit the 'initializer of X is not a constant expression' note
for local constexpr variables as well.
 2025-01-20 13:25:50 +01:00
Timm Baeder
1be64c27f1
[clang][bytecode] Fix diagnostic mismatch with current interpreter (#123571) 
Don't report dead pointers if we've checking for a potential constant
expression.
 2025-01-20 10:48:38 +01:00
Timm Baeder
6972788bf3
[clang][bytecode] Fix discarding DerivedToBase casts (#123523) 2025-01-20 08:55:54 +01:00
Timm Baeder
0ab1f5772c
[clang][bytecode] Register decomposition holding vars (#123515) 2025-01-19 16:29:56 +01:00
Timm Baeder
c7ea4c18af
[clang][bytecode] Revisit global variables separately (#123358) 
Call `EvaluateAsInitializer()` explicitly here, so we don't abort the
evaluation of the `DeflRefExpr` just because the initializer of that
global variable failed.
 2025-01-17 18:55:24 +01:00
Timm Baeder
0171e56ed0
[clang][bytecode] Fix rejecting invalid sizeof expressions (#123332) 
Emit the invalid note instead of nothing.
 2025-01-17 15:14:47 +01:00
Timm Baeder
7075eee6bd
[clang][bytecode] Add InitLinkScope for toplevel Expr temporary (#123319) 2025-01-17 12:58:15 +01:00
Timm Bäder
a0bd40e5a3 Revert "[clang][bytecode] Mark global decls with diagnostics invalid (#122895)" 
This reverts commit c1de9b920935e7d2fcc8dd7b39c1b7285783e948.

It looks like this breaks the memory-sanitizer builder:
https://lab.llvm.org/buildbot/#/builders/94/builds/3745
 2025-01-14 18:37:36 +01:00
Timm Baeder
58fa55c04b
[clang][bytecode] Add init link for the RVO ptr (#122904) 2025-01-14 17:18:04 +01:00
Timm Baeder
c1de9b9209
[clang][bytecode] Mark global decls with diagnostics invalid (#122895) 
Even if their evaluation succeeds, mark them as invalid. This fixes some
long standing differences to the ast walker interpeter.
 2025-01-14 15:10:48 +01:00
Timm Baeder
ac857f9bdd
[clang][bytecode] Change the way we do init chains (#122871) 
See the comment in Compiler<>::VisitCXXThisExpr.
We need to mark the InitList explicitly, so we later know what to refer
to when the init chain is active.
 2025-01-14 10:57:36 +01:00
Timm Baeder
fd6baa477f
[clang][ExprConst] Add diagnostics for invalid binary arithmetic (#118475) 
... between unrelated declarations or literals.

Leaving this small (I haven't run the whole test suite locally) to get
some feedback on the wording and implementation first.

The output of the sample in
https://github.com/llvm/llvm-project/issues/117409 is now:
```console
./array.cpp:57:6: warning: expression result unused [-Wunused-value]
   57 |   am - aj.af();
      |   ~~ ^ ~~~~~~~
./array.cpp:70:8: error: call to consteval function 'L::L<bx>' is not a constant expression
   70 |   q(0, [] {
      |        ^
./array.cpp:57:6: note: arithmetic on addresses of literals has unspecified value
   57 |   am - aj.af();
      |      ^
./array.cpp:62:5: note: in call to 'al(&""[0], {&""[0]})'
   62 |     al(bp.af(), k);
      |     ^~~~~~~~~~~~~~
./array.cpp:70:8: note: in call to 'L<bx>({})'
   70 |   q(0, [] {
      |        ^~~~
   71 |     struct bx {
      |     ~~~~~~~~~~~
   72 |       constexpr operator ab<g<l<decltype(""[0])>::e>::e>() { return t(""); }
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   73 |     };
      |     ~~
   74 |     return bx();
      |     ~~~~~~~~~~~~
   75 |   }());
      |   ~~~
```

The output for 
```c++
int a, b;
constexpr int n = &b - &a
```

is now:
```console
./array.cpp:80:15: error: constexpr variable 'n' must be initialized by a constant expression
   80 | constexpr int n = &b - &a;
      |               ^   ~~~~~~~
./array.cpp:80:22: note: arithmetic involving '&b' and '&a' has unspecified value
   80 | constexpr int n = &b - &a;
      |                      ^
1 error generated.

```
 2025-01-09 11:42:35 +01:00
Timm Baeder
02b30128e8
[clang][bytecode] Always return false for invalid bcp results (#121467) 2025-01-02 13:44:45 +01:00
Timm Baeder
34097c07e1
[clang][bytecode] Consider unknown-size arrays in memcpy/memcmp (#121462) 
When emitting diagnostics for the number of elements.
 2025-01-02 10:59:08 +01:00
Timm Baeder
d5c8af492f
[clang][bytecode] Consider start index when copying composite array (#121461) 
... elements.
 2025-01-02 10:31:49 +01:00
Timm Baeder
f0d60170cc
[clang][bytecode] Check memove/memcpy for available elements (#121383) 
Both destination and source pointer need to have at least as many
elements as requested.
 2024-12-31 12:14:27 +01:00
Timm Baeder
e86b68ff56
[clang][bytecode] Add support for typeid pointers (#121251) 
Add it as another kind of pointer, saving both a `Type*` for the result
of the typeid() expression as well as one for the type of the typeid
expression.
 2024-12-28 14:07:01 +01:00
Timm Baeder
acb7dfaa01
[clang][bytecode] Create local scopes for if then/else statements (#120852) 
In case those aren't compound statements.
 2024-12-22 08:04:49 +01:00
Timm Baeder
1f2d934525
[clang][bytecode] Support pointers in __builtin_mem{move,cpy} (#120560) 
Unfortunately, that means we can't use the __builtin_bit_cast
implementation for this.
 2024-12-19 16:38:58 +01:00
Timm Baeder
56fd46edb3
[clang][bytecode] Remove a bitcast nullptr_t special case (#120188) 
We still need to check the input pointer, so let this go through
BitCastPrim.
 2024-12-17 13:23:14 +01:00
Timm Baeder
056cd12284
[clang][bytecode] Don't check returned pointers for liveness (#120107) 
We're supposed to let them through and then later diagnose reading from
them, but returning dead pointers is fine.
 2024-12-17 06:20:14 +01:00
Timm Baeder
dd6f6a096a
[clang][bytecode] Handle builtin_wmemcmp (#120070) 2024-12-16 13:41:14 +01:00
Timm Bäder
2503a66596 Reapply "[clang][bytecode] Fix some shift edge cases (#119895)" 
This reverts commit a6636ce4d124176856c3913d4bf6c3ceff1f5a1f.

This original commit failed on hosts with signed wchar_t. Care for
this in the test.
 2024-12-16 10:01:46 +01:00
Timm Bäder
a6636ce4d1 Revert "[clang][bytecode] Fix some shift edge cases (#119895)" 
This reverts commit 49c2207f21c0922aedb6c70471f8ea068977eb30.

This breaks on big-endian, again:
https://lab.llvm.org/buildbot/#/builders/154/builds/9018
 2024-12-14 06:28:12 +01:00
Timm Baeder
49c2207f21
[clang][bytecode] Fix some shift edge cases (#119895) 
Around shifting negative values.
 2024-12-14 06:15:56 +01:00
Mariya Podchishchaeva
1d65c35ce1
[clang] Reject _Complex _BitInt (#119402) 
The C standard doesn't require support for these types and Codegen for
these types is incorrect ATM.
See https://github.com/llvm/llvm-project/issues/119352
 2024-12-12 12:19:48 +01:00
Timm Baeder
98470c0b2e
[clang][bytecode] Handle __builtin_bcmp (#119678) 
... the same as `__builtin_memcmp`. Also fix a bug we still had when we
couldn't find a difference in the two inputs after `Size` bytes.
 2024-12-12 10:57:39 +01:00
Timm Baeder
8713914d76
[clang][bytecode] Handle __builtin_memcmp (#119544) 2024-12-12 08:59:35 +01:00
Timm Baeder
4dde52d76b
[clang][bytecode] Check for overlapping memcpy regions (#119535) 2024-12-11 12:06:56 +01:00
Timm Baeder
0fb06172f1
[clang][bytecode] Check vector element types for eligibility (#119385) 
Like we do in ExprConstant.cpp.
 2024-12-10 17:56:48 +01:00
Timm Baeder
ce1587346b
[clang][bytecode] Allow checking builtin functions... (#119328) 
... in checkingPotentialConstantExpression mode. This is what the
current interpreter does, yet it doesn't do so for
`__builtin_operator_new`.
 2024-12-10 07:42:13 +01:00
Timm Baeder
6168739f00
[clang][bytecode] Reject memcpy sizes with element size remainder (#119209) 2024-12-09 16:57:49 +01:00
Timm Baeder
d17e51f306
[clang][bytecode] Handle __builtin_strncmp (#119208) 2024-12-09 16:17:39 +01:00
Timm Baeder
00b50c917b
[clang][bytecode] Handle __builtin_wcslen (#119187) 
Handle different char widths in builtin_strlen.
 2024-12-09 12:34:25 +01:00
Timm Baeder
1fbbf4c418
[clang][bytecode] Pass (float) BitWidth to DoBitCast (#119119) 
In certain cases (i.e. long double on x86), the bit with we get from the
floating point semantics is different than the type size we compute for
the BitCast instruction. Pass this along to DoBitCast, so in there we
can check only the relevant bits for being initialized.

This also fixes a weirdness we still had in DoBitCast.
 2024-12-08 18:54:08 +01:00
Timm Baeder
b4150ed128
[clang][bytecode] Check composite bitcasts for indeterminate bits (#118988) 2024-12-07 13:06:00 +01:00
Timm Baeder
2f9cd43a73
[clang][bytecode] Check primitive bit casts for indeterminate bits (#118954) 
Record bits ranges of initialized bits and check them in
allInitialized().
 2024-12-06 15:50:59 +01:00
Timm Baeder
b6217f67a4
[clang][bytecode] Fix bitcasting from null pointers (#116999) 2024-12-05 13:13:59 +01:00
Timm Bäder
17dfdd3a86 [clang][bytecode][tests] Specify triple in bitfields tests 
This still breaks on 32bit hosts otherwise.
See https://github.com/llvm/llvm-project/pull/116843
 2024-12-05 11:10:58 +01:00
Timm Baeder
abc27039be
[clang][bytecode] Pass __builtin_memcpy size along (#118649) 
To DoBitCastPtr, so we know how many bytes we want to read.
 2024-12-05 06:55:18 +01:00
Timm Baeder
44be794658
[clang][bytecode] Not all null pointers are 0 (#118601) 
Get the Value from the ASTContext instead.
 2024-12-05 06:03:50 +01:00
Timm Baeder
7aec6dc477
[clang][bytecode] Initialize bases when bitcasting (#117179) 
Base pointers do not get passed to the callback, so initialize them when iterating bases.
 2024-12-04 16:49:03 +01:00
Timm Bäder
12ca72ba7f Reapply "[clang][bytecode] Handle bitcasts involving bitfields (#116843)" 
This reverts commit 54db16221c92eb52efbea90ad5b5d2a1d00cda3e.

Check for existence of __SIZOEF_INT128__ so we don't run those
tests on targets that don't have int128.
 2024-12-04 11:53:37 +01:00