3 Commits

Author SHA1 Message Date
royitaqi
26670e7fa4
[lldb] Correctly fix a usage of PATH_MAX, and fix unit tests (#104502)
# Part 1: Correctly fix a usage of `PATH_MAX`

TL;DR: Adding a typedef `lldb_private::PathSmallString` which contains a
hardcoded initial size (128).

# Part 2: Fix unit tests

After https://github.com/llvm/llvm-project/pull/104493 fixed the build
break for Windows, unit test failure showed up for Windows. The
root-cause is that the `FileSpec`'s in the unit tests are not
style-specific. The fix is to apply either `WindowsSpec` or `PosixSpec`
specifically.
2024-08-15 17:24:39 -07:00
royitaqi
f377edb96a
(lldb) Fix PATH_MAX for Windows (#104493)
The build break was caused by a [previous
patch](https://github.com/llvm/llvm-project/pull/102223) using
`PATH_MAX` which is undefined in Windows.
2024-08-15 13:14:26 -07:00
royitaqi
47721d4618
[lldb] Realpath symlinks for breakpoints (#102223)
Improve the chance of resolving file/line breakpoints by realpath'ing the support files before doing a second match attempt, with some conditions applied.

A working [hello-world example](https://github.com/royitaqi/lldb_demos/blob/main/realpath/README.md).

See [patch](https://github.com/llvm/llvm-project/pull/102223) for more info about problem/motivation, details of the feature, new settings, telemetries and tests.
2024-08-15 11:26:24 -07:00