shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity
419,937 Commits 1,713 Branches 298 Tags
Commit Graph

12 Commits

Author SHA1 Message Date
Saar Raz
c83d9bedc0 [Concept] Fix incorrect check for containsUnexpandedParameterPack in CSE 
We previously checked for containsUnexpandedParameterPack in CSEs by observing the property
in the converted arguments of the CSE. This may not work if the argument is an expanded
type-alias that contains a pack-expansion (see added test).

Check the as-written arguments when determining containsUnexpandedParameterPack and isInstantiationDependent.
 2020-01-30 20:45:44 +02:00
Saar Raz
df061c3e2b [Concepts] Constrained partial specializations and function overloads. 
Added support for constraint satisfaction checking and partial ordering of constraints in constrained partial specialization and function template overloads.
Re-commit after fixing another crash (added regression test).

Differential Revision: https://reviews.llvm.org/D41910
 2019-12-23 08:37:35 +02:00
Reid Kleckner
79cc9e9b30 Revert "[Concepts] Constrained partial specializations and function overloads." 
This reverts commit d3f5769d5e93b30d4a8b4696381d5e4a304992fa.

Causes crashes on Chromium. Have reproducer, will reduce and send along.
 2019-12-22 11:40:07 -08:00
Saar Raz
d3f5769d5e [Concepts] Constrained partial specializations and function overloads. 
Added support for constraint satisfaction checking and partial ordering of constraints in constrained partial specialization and function template overloads.
Re-commit after fixing some crashes and warnings.

Differential Revision: https://reviews.llvm.org/D41910
 2019-12-22 13:15:38 +02:00
Vedant Kumar
5094e6dad6 Revert concepts changes from D41910 
These changes caused LibcxxVariantDataFormatterTestCase in lldb to fail
with an assert:

Assertion failed: (Idx < size() && "Out-of-bounds Bit access."),
function operator[], file
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/ADT/SmallBitVector.h,
line 452.

In:

7  clang-10                 0x00000001094b79d9 isAtLeastAsSpecializedAs(clang::Sema&, clang::SourceLocation, clang::FunctionTemplateDecl*, clang::FunctionTemplateDecl*, clang::TemplatePartialOrderingContext, unsigned int) + 1865
8  clang-10                 0x00000001094b7111 clang::Sema::getMoreSpecializedTemplate(clang::FunctionTemplateDecl*, clang::FunctionTemplateDecl*, clang::SourceLocation, clang::TemplatePartialOrderingContext, unsigned int, unsigned int) + 97
9  clang-10                 0x000000010939bf88 clang::isBetterOverloadCandidate(clang::Sema&, clang::OverloadCandidate const&, clang::OverloadCandidate const&, clang::SourceLocation, clang::OverloadCandidateSet::CandidateSetKind) + 1128

Revert "[Concepts] Fix incorrect move out of temporary in D41910"

This reverts commit 11d5fa6e87e3584f72056ecc2b17f88c58323dde.

Revert "[Concepts] Fix crash in D41910"

This reverts commit 12038be20ee6a903cdbd3fddce65535ef683e31d.

Revert "[Concepts] Constrained partial specializations and function overloads."

This reverts commit fc0731b98a67c793862288f8ae334322666214dc.
 2019-12-18 15:02:39 -08:00
Saar Raz
fc0731b98a [Concepts] Constrained partial specializations and function overloads. 
Added support for constraint satisfaction checking and partial ordering of constraints in constrained partial specialization and function template overloads.

Phabricator: D41910
 2019-12-18 21:01:31 +02:00
Saar Raz
fdf80e86a5 [Concepts] Constraint Enforcement & Diagnostics 
Part of the C++20 concepts implementation effort.
- Associated constraints (requires clauses, currently) are now enforced when instantiating/specializing templates and when considering partial specializations and function overloads.
- Elaborated diagnostics give helpful insight as to why the constraints were not satisfied.
Phabricator: D41569

Re-commit, after fixing some memory bugs.
 2019-12-06 01:34:20 +02:00
Vlad Tsyrklevich
38839d08b8 Revert "[Concepts] Constraint Enforcement & Diagnostics" 
This reverts commit ffa214ef22892d75340dc6720271863901dc2c90, it was
causing ASAN test failures on sanitizer-x86_64-linux-bootstrap.
 2019-10-28 15:00:40 -07:00
Saar Raz
ffa214ef22 [Concepts] Constraint Enforcement & Diagnostics 
Part of the C++20 concepts implementation effort.
- Associated constraints (requires clauses, currently) are now enforced when instantiating/specializing templates and when considering partial specializations and function overloads.
- Elaborated diagnostics give helpful insight as to why the constraints were not satisfied.
Phabricator: D41569
 2019-10-25 00:19:51 +03:00
Saar Raz
5d98ba6077 [Concepts] Concept Specialization Expressions 
Part of C++20 Concepts implementation effort. Added Concept Specialization Expressions that are created when a concept is refe$

D41217 on Phabricator.

(recommit after fixing failing Parser test on windows)

llvm-svn: 374903
 2019-10-15 15:24:26 +00:00
Nico Weber
b4638f9ff0 Revert 374882 "[Concepts] Concept Specialization Expressions" 
This reverts commit ec87b003823d63f3342cf648f55a134c1522e612.
The test fails on Windows, see e.g.
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11533/steps/stage%201%20check/logs/stdio

Also revert follow-up r374893.

llvm-svn: 374899
 2019-10-15 14:46:39 +00:00
Saar Raz
ec87b00382 [Concepts] Concept Specialization Expressions 
Part of C++20 Concepts implementation effort. Added Concept Specialization Expressions that are created when a concept is referenced with arguments, and tests thereof.

llvm-svn: 374882
 2019-10-15 11:48:58 +00:00