shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity
298,797 Commits 1,713 Branches 298 Tags
Commit Graph

20610 Commits

Author SHA1 Message Date
Chris Lattner
6c3e8c78cf FunctionPass's should not define their own 'run' method. 
Require 'simplified' loops, not just raw natural loops.  This fixes
CodeExtractor/2004-03-13-LoopExtractorCrash.ll

llvm-svn: 12381
 2004-03-14 04:01:06 +00:00
Chris Lattner
d078812f96 If a block is dead, dominators will not be calculated for it. Because of this 
loop information won't see it, and we could have unreachable blocks pointing to
the non-header node of blocks in a natural loop.  This isn't tidy, so have the
loopsimplify pass clean it up.

llvm-svn: 12380
 2004-03-14 03:59:22 +00:00
Chris Lattner
3684469326 Verify functions as they are produced if -debug is specified. Reduce 
curly braceage

llvm-svn: 12378
 2004-03-14 03:17:22 +00:00
Chris Lattner
78a996aec4 Move prototype to IPO.h instead of Scalar.h 
Make sure that the file interface header (IPO.h) is included first
remove dead #incldue

llvm-svn: 12375
 2004-03-14 02:37:16 +00:00
Chris Lattner
692a47aeb9 Indent anon namespace properly, add copyright block 
llvm-svn: 12373
 2004-03-14 02:34:07 +00:00
Chris Lattner
41ec709e00 Move to the IPO library. Utils shouldn't contain passes. 
llvm-svn: 12372
 2004-03-14 02:32:27 +00:00
Chris Lattner
8eebc49884 DemoteRegToStack got moved from DemoteRegToStack.h to Local.h 
llvm-svn: 12368
 2004-03-14 02:13:38 +00:00
Chris Lattner
7d2a539735 Add some debugging output 
Fix InstCombine/2004-03-13-InstCombineInfLoop.ll which caused an infinite
loop compiling (I think) povray.

llvm-svn: 12365
 2004-03-13 23:54:27 +00:00
Chris Lattner
2dc85b27e4 This change makes two big adjustments. 
* Be a lot more accurate about what the effects will be when inlining a call
   to a function when an argument is an alloca.
 * Dramatically reduce the penalty for inlining a call in a large function.
   This heuristic made it almost impossible to inline a function into a large
   function, no matter how small the callee is.

llvm-svn: 12363
 2004-03-13 23:15:45 +00:00
Chris Lattner
797cb2f6c1 This little patch speeds up the loop used to update the dominator set analysis. 
On the testcase from GCC PR12440, which has a LOT of loops (1392 of which require
preheaders to be inserted), this speeds up the loopsimplify pass from 1.931s to
0.1875s.  The loop in question goes from 1.65s -> 0.0097s, which isn't bad. All of
these times are a debug build.

This adds a dependency on DominatorTree analysis that was not there before, but
we always had dominatortree available anyway, because LICM requires both loop
simplify and DT, so this doesn't add any extra analysis in practice.

llvm-svn: 12362
 2004-03-13 22:01:26 +00:00
Chris Lattner
022167f13b Implement sub.ll:test14 
llvm-svn: 12355
 2004-03-13 00:11:49 +00:00
Chris Lattner
92295c5031 Implement InstCombine/sub.ll:test12 & test13 
llvm-svn: 12353
 2004-03-12 23:53:13 +00:00
Chris Lattner
cb015ee6c0 Add constant folding wrapper support for select instructions. 
llvm-svn: 12319
 2004-03-12 05:53:03 +00:00
Chris Lattner
59db22dcd4 Add sccp support for select instructions 
llvm-svn: 12318
 2004-03-12 05:52:44 +00:00
Chris Lattner
b909e8b0d4 Add trivial optimizations for select instructions 
llvm-svn: 12317
 2004-03-12 05:52:32 +00:00
Chris Lattner
721264aecc Initial support for edge profiling 
llvm-svn: 12225
 2004-03-08 17:54:34 +00:00
Chris Lattner
dae48f93b0 Split utility functions out of BlockProfiling.cpp 
llvm-svn: 12224
 2004-03-08 17:06:13 +00:00
Chris Lattner
d91e676700 finegrainify namespacification 
llvm-svn: 12221
 2004-03-08 16:45:53 +00:00
Chris Lattner
fe6f2e3e80 Implement ArgumentPromotion/aggregate-promote.ll 
This allows pointers to aggregate objects, whose elements are only read, to
be promoted and passed in by element instead of by reference.  This can
enable a LOT of subsequent optimizations in the caller function.

It's worth pointing out that this stuff happens a LOT of C++ programs, because
objects in templates are generally passed around by reference.  When these
templates are instantiated on small aggregate or scalar types, however, it is
more efficient to pass them in by value than by reference.

This transformation triggers most on C++ codes (e.g. 334 times on eon), but
does happen on C codes as well.  For example, on mesa it triggers 72 times,
and on gcc it triggers 35 times.  this is amazingly good considering that
we are using 'basicaa' so far.

llvm-svn: 12202
 2004-03-08 01:04:36 +00:00
Chris Lattner
cc544e57f3 Implement: ArgumentPromotion/chained.ll 
llvm-svn: 12200
 2004-03-07 22:52:53 +00:00
Chris Lattner
64b8d697ad Fix another minor bug, exposed by perlbmk 
llvm-svn: 12198
 2004-03-07 22:43:27 +00:00
Chris Lattner
538fee7aa2 Since 'load null' is undefined, we can make it do whatever we want. Returning 
a zero value is the most likely way to cause further simplification, so we do it.

llvm-svn: 12197
 2004-03-07 22:16:24 +00:00
Chris Lattner
6770842b67 Fix a minor bug and turn debug output into, well, debug output. 
llvm-svn: 12195
 2004-03-07 21:54:50 +00:00
Chris Lattner
483ae01c9c New LLVM pass: argument promotion. This version only handles simple scalar 
variables.

llvm-svn: 12193
 2004-03-07 21:29:54 +00:00
Chris Lattner
7abcc387de Don't emit things like malloc(16*1). Allocation instructions are fixed arity now. 
llvm-svn: 12086
 2004-03-03 01:40:53 +00:00
Misha Brukman
f44acae31e Implement ExtractCodeRegion() 
llvm-svn: 12070
 2004-03-02 00:20:57 +00:00
Misha Brukman
f272f9b3d5 Make a note that this is usually used via bugpoint. 
llvm-svn: 12068
 2004-03-02 00:19:09 +00:00
Misha Brukman
5af2be7d09 * Add implementation of ExtractBasicBlock() 
* Add comments to ExtractLoop()

llvm-svn: 12053
 2004-03-01 18:28:34 +00:00
Chris Lattner
5cf39339d1 Disable tail duplication in a case that breaks on Olden/tsp 
llvm-svn: 12021
 2004-03-01 01:12:13 +00:00
Misha Brukman
c91e1ff50d * Remove function to find "main" in a Module, there's a method for that 
* Removing extraneous empty space and empty comment lines

llvm-svn: 12014
 2004-02-29 23:09:10 +00:00
Chris Lattner
2de229f31b Fix bug: test/Regression/Transforms/LowerInvoke/2004-02-29-PHICrash.llx 
... which tickled the lowerinvoke pass because it used the BCE routines.

llvm-svn: 12012
 2004-02-29 22:24:41 +00:00
Chris Lattner
bf2963ef91 Fix PR255: [tailduplication] Single basic block loops are very rare 
Note that this is a band-aid put over a band-aid.  This just undisables
tail duplication in on very specific case that it seems to work in.

llvm-svn: 11989
 2004-02-29 06:41:20 +00:00
Chris Lattner
d3e6ae263c Implement switch->br and br->switch folding by ripping out the switch->switch 
and br->br code and generalizing it.  This allows us to compile code like this:

int test(Instruction *I) {
  if (isa<CastInst>(I))
    return foo(7);
  else if (isa<BranchInst>(I))
    return foo(123);
  else if (isa<UnwindInst>(I))
    return foo(1241);
  else if (isa<SetCondInst>(I))
    return foo(1);
  else if (isa<VAArgInst>(I))
    return foo(42);
  return foo(-1);
}

into:

int %_Z4testPN4llvm11InstructionE("struct.llvm::Instruction"* %I) {
entry:
        %tmp.1.i.i.i.i.i.i.i = getelementptr "struct.llvm::Instruction"* %I, long 0, ubyte 4            ; <uint*> [#uses=1]
        %tmp.2.i.i.i.i.i.i.i = load uint* %tmp.1.i.i.i.i.i.i.i          ; <uint> [#uses=2]
        %tmp.2.i.i.i.i.i.i = seteq uint %tmp.2.i.i.i.i.i.i.i, 27                ; <bool> [#uses=0]
        switch uint %tmp.2.i.i.i.i.i.i.i, label %endif.0 [
                 uint 27, label %then.0
                 uint 2, label %then.1
                 uint 5, label %then.2
                 uint 14, label %then.3
                 uint 15, label %then.3
                 uint 16, label %then.3
                 uint 17, label %then.3
                 uint 18, label %then.3
                 uint 19, label %then.3
                 uint 32, label %then.4
        ]
...

As well as handling the cases in 176.gcc and many other programs more effectively.

llvm-svn: 11964
 2004-02-28 21:28:10 +00:00
Chris Lattner
772eafa332 if there is already a prototype for malloc/free, use it, even if it's incorrect. 
Do not just inject a new prototype.

llvm-svn: 11951
 2004-02-28 18:51:45 +00:00
Chris Lattner
51ea127bf3 Rename AddUsesToWorkList -> AddUsersToWorkList, as that is what it does. 
Create a new AddUsesToWorkList method
optimize memmove/set/cpy of zero bytes to a noop.

llvm-svn: 11941
 2004-02-28 05:22:00 +00:00
Chris Lattner
f3a366062c Turn 'free null' into nothing 
llvm-svn: 11940
 2004-02-28 04:57:37 +00:00
Misha Brukman
8a2c28fdda Right, it's really Extractor, not Extraction. 
llvm-svn: 11939
 2004-02-28 03:37:58 +00:00
Misha Brukman
03a11340ff A pass that uses the generic CodeExtractor to rip out *every* loop in every 
function, as long as the loop isn't the only one in that function. This should
help debugging passes easier with BugPoint.

llvm-svn: 11936
 2004-02-28 03:33:01 +00:00
Misha Brukman
caa1a5abeb A generic code extractor: given a list of BasicBlocks, it will rip them out into 
a new function, taking care of inputs and outputs.

llvm-svn: 11935
 2004-02-28 03:26:20 +00:00
Chris Lattner
e82c217b2f setcond instructions don't have aliasing implications. 
llvm-svn: 11919
 2004-02-27 18:09:25 +00:00
Chris Lattner
4f7accab96 Implement test/Regression/Transforms/InstCombine/canonicalize_branch.ll 
This is a really minor thing, but might help out the 'switch statement induction'
code in simplifycfg.

llvm-svn: 11900
 2004-02-27 06:27:46 +00:00
Chris Lattner
79636d7cd5 Since LLVM uses structure type equivalence, it isn't useful to keep around 
multiple type names for the same structural type.  Make DTE eliminate all
but one of the type names

llvm-svn: 11879
 2004-02-26 20:02:23 +00:00
Chris Lattner
21e941fbfd turn things like: 
if (X == 0 || X == 2)

...where the comparisons and branches are in different blocks... into a switch
instruction.  This comes up a lot in various programs, and works well with
the switch/switch merging code I checked earlier.  For example, this testcase:

int switchtest(int C) {
  return C == 0 ? f(123) :
         C == 1 ? f(3123) :
         C == 4 ? f(312) :
         C == 5 ? f(1234): f(444);
}

is converted into this:
        switch int %C, label %cond_false.3 [
                 int 0, label %cond_true.0
                 int 1, label %cond_true.1
                 int 4, label %cond_true.2
                 int 5, label %cond_true.3
        ]

instead of a whole bunch of conditional branches.

Admittedly the code is ugly, and incomplete.  To be complete, we need to add
br -> switch merging and switch -> br merging.  For example, this testcase:

struct foo { int Q, R, Z; };
#define A (X->Q+X->R * 123)
int test(struct foo *X) {
  return A  == 123 ? X1() :
        A == 12321 ? X2():
        (A == 111 || A == 222) ? X3() :
        A == 875 ? X4() : X5();
}

Gets compiled to this:
        switch int %tmp.7, label %cond_false.2 [
                 int 123, label %cond_true.0
                 int 12321, label %cond_true.1
                 int 111, label %cond_true.2
                 int 222, label %cond_true.2
        ]
...
cond_false.2:           ; preds = %entry
        %tmp.52 = seteq int %tmp.7, 875         ; <bool> [#uses=1]
        br bool %tmp.52, label %cond_true.3, label %cond_false.3

where the branch could be folded into the switch.

This kind of thing occurs *ALL OF THE TIME*, especially in programs like
176.gcc, which is a horrible mess of code.  It contains stuff like *shudder*:

#define SWITCH_TAKES_ARG(CHAR) \
  (   (CHAR) == 'D' \
   || (CHAR) == 'U' \
   || (CHAR) == 'o' \
   || (CHAR) == 'e' \
   || (CHAR) == 'u' \
   || (CHAR) == 'I' \
   || (CHAR) == 'm' \
   || (CHAR) == 'L' \
   || (CHAR) == 'A' \
   || (CHAR) == 'h' \
   || (CHAR) == 'z')

and

#define CONST_OK_FOR_LETTER_P(VALUE, C)                 \
  ((C) == 'I' ? SMALL_INTVAL (VALUE)                    \
   : (C) == 'J' ? SMALL_INTVAL (-(VALUE))               \
   : (C) == 'K' ? (unsigned)(VALUE) < 32                \
   : (C) == 'L' ? ((VALUE) & 0xffff) == 0               \
   : (C) == 'M' ? integer_ok_for_set (VALUE)            \
   : (C) == 'N' ? (VALUE) < 0                           \
   : (C) == 'O' ? (VALUE) == 0                          \
   : (C) == 'P' ? (VALUE) >= 0                          \
   : 0)

and

#define LEGITIMIZE_ADDRESS(X,OLDX,MODE,WIN)                     \
{                                                               \
  if (GET_CODE (X) == PLUS && CONSTANT_ADDRESS_P (XEXP (X, 1))) \
    (X) = gen_rtx (PLUS, SImode, XEXP (X, 0),                   \
                   copy_to_mode_reg (SImode, XEXP (X, 1)));     \
  if (GET_CODE (X) == PLUS && CONSTANT_ADDRESS_P (XEXP (X, 0))) \
    (X) = gen_rtx (PLUS, SImode, XEXP (X, 1),                   \
                   copy_to_mode_reg (SImode, XEXP (X, 0)));     \
  if (GET_CODE (X) == PLUS && GET_CODE (XEXP (X, 0)) == MULT)   \
    (X) = gen_rtx (PLUS, SImode, XEXP (X, 1),                   \
                   force_operand (XEXP (X, 0), 0));             \
  if (GET_CODE (X) == PLUS && GET_CODE (XEXP (X, 1)) == MULT)   \
    (X) = gen_rtx (PLUS, SImode, XEXP (X, 0),                   \
                   force_operand (XEXP (X, 1), 0));             \
  if (GET_CODE (X) == PLUS && GET_CODE (XEXP (X, 0)) == PLUS)   \
    (X) = gen_rtx (PLUS, Pmode, force_operand (XEXP (X, 0), NULL_RTX),\
                   XEXP (X, 1));                                \
  if (GET_CODE (X) == PLUS && GET_CODE (XEXP (X, 1)) == PLUS)   \
    (X) = gen_rtx (PLUS, Pmode, XEXP (X, 0),                    \
                   force_operand (XEXP (X, 1), NULL_RTX));      \
  if (GET_CODE (X) == SYMBOL_REF || GET_CODE (X) == CONST       \
           || GET_CODE (X) == LABEL_REF)                        \
    (X) = legitimize_address (flag_pic, X, 0, 0);               \
  if (memory_address_p (MODE, X))                               \
    goto WIN; }

and others.  These macros get used multiple times of course.  These are such
lovely candidates for macros, aren't they?  :)

This code also nicely handles LLVM constructs that look like this:

  if (isa<CastInst>(I))
   ...
  else if (isa<BranchInst>(I))
   ...
  else if (isa<SetCondInst>(I))
   ...
  else if (isa<UnwindInst>(I))
   ...
  else if (isa<VAArgInst>(I))
   ...

where the isa can obviously be a dyn_cast as well.  Switch instructions are a
good thing.

llvm-svn: 11870
 2004-02-26 07:13:46 +00:00
Chris Lattner
8d1da1abee My faith in programmers has been found to be totally misplaced. One would 
assume that if they don't intend to write to a global variable, that they
would mark it as constant.  However, there are people that don't understand
that the compiler can do nice things for them if they give it the information
it needs.

This pass looks for blatently obvious globals that are only ever read from.
Though it uses a trivially simple "alias analysis" of sorts, it is still able
to do amazing things to important benchmarks.  253.perlbmk, for example,
contains several ***GIANT*** function pointer tables that are not marked
constant and should be.  Marking them constant allows the optimizer to turn
a whole bunch of indirect calls into direct calls.  Note that only a link-time
optimizer can do this transformation, but perlbmk does have several strings
and other minor globals that can be marked constant by this pass when run
from GCCAS.

176.gcc has a ton of strings and large tables that are marked constant, both
at compile time (38 of them) and at link time (48 more).  Other benchmarks
give similar results, though it seems like big ones have disproportionally
more than small ones.

This pass is extremely quick and does good things.  I'm going to enable it
in gccas & gccld.  Not bad for 50 SLOC.

llvm-svn: 11836
 2004-02-25 21:34:36 +00:00
Chris Lattner
9c6833c5ca Fix incorrect debug code 
llvm-svn: 11821
 2004-02-25 15:15:04 +00:00
Chris Lattner
8ee0593f0d Fix a faulty optimization on FP values 
llvm-svn: 11801
 2004-02-24 18:10:14 +00:00
Chris Lattner
90ea78edba If a block is made dead, make sure to promptly remove it. 
llvm-svn: 11799
 2004-02-24 16:09:21 +00:00
Chris Lattner
a2ab489135 Implement SimplifyCFG/switch_switch_fold.ll 
This case occurs many times in various benchmarks, especially when combined
with the previous patch.  This allows it to get stuff like:
  if (X == 4 || X == 3)
    if (X == 5 || X == 8)

and

switch (X) {
case 4: case 5: case 6:
  if (X == 4 || X == 5)

llvm-svn: 11797
 2004-02-24 07:23:58 +00:00
Chris Lattner
3cd98f054a Rearrange code a bit 
llvm-svn: 11793
 2004-02-24 05:54:22 +00:00
Chris Lattner
6f4b45acf5 Implement: test/Regression/Transforms/SimplifyCFG/switch_create.ll 
This turns code like this:
  if (X == 4 | X == 7)
and
  if (X != 4 & X != 7)
into switch instructions.

llvm-svn: 11792
 2004-02-24 05:38:11 +00:00