3 Commits

Author	SHA1	Message	Date
Jacques Pienaar	7d273fde11	[mlir] Populate default attributes on op creation ... Default attributes were only handled by ODS accessors generated with the intention that these behave as if set attributes. This addresses the long standing TODO to address this inconsistency. Moving the initialization to construction vs every access. Removing need for duplicated default attribute population in python bindings. Switch some of the OpenMP ones to optional attribute with default as the currently set default values are not legal. May need to dig more there. Switched LinAlg generated ones to optional attribute with default as its quite widely used and unclear where it falls on two different interpretations. Differential Revision: https://reviews.llvm.org/D130916	2022-08-22 16:49:46 -07:00
Jeff Niu	5c5af910fe	[mlir][LLVMIR] "Modernize" Insert/ExtractValueOp ... This patch "modernizes" the LLVM `insertvalue` and `extractvalue` operations to use DenseI64ArrayAttr, since they only require an array of indices and previously there was confusion about whether to use i32 or i64 arrays, and to use assembly format. Reviewed By: ftynse Differential Revision: https://reviews.llvm.org/D131537	2022-08-10 12:51:11 -04:00
Min-Yih Hsu	00fcf9e95a	[mlir][LLVMIR] Add support for importing struct-type ConstantAggregate(Zero) ... And move importer test files from `test/Target/LLVMIR` into `test/Target/LLVMIR/Import`. We simply translate struct-type ConstantAggregate(Zero) into a serious of `llvm.insertvalue` operations against a `llvm.undef` root. Note that this doesn't affect the original logics on translating vector/array-type ConstantAggregate values. Differential Revision: https://reviews.llvm.org/D124399	2022-04-27 09:42:26 -07:00