It was expressed in some reviews that Clang folks didn't want to hold
off other testing jobs in case clang-format failed. This patch makes
it so that the basic clang testing jobs will run even if clang-format
fails on the patch. The overall build will still be marked as failed,
but it will be possible to see the failures in clang tests so at least
there will be some feedback available.
The whole pipeline was originally blocked on clang-format because we
inherited that pipeline definition from libc++, where we want to block
on clang-format for capacity reasons.
Differential Revision: https://reviews.llvm.org/D159197
This patch adds a CI job for Clang on Windows that is separate from
the monolithic job that gets added automatically via the Phabricator
integration with Buildkite. This way, we will retain the Windows testing
for Clang when we move to GitHub Pull Requests.
Differential Revision: https://reviews.llvm.org/D158995
We used to rely on the monorepo-wide premerge checks for running Clang
tests, but I think it makes more sense to run the Clang tests explicitly
in its CI pipeline since we want to move away from monorepo-wide checks.
Differential Revision: https://reviews.llvm.org/D158765
We made some changes to the libc++ CI pipeline that take for granted
that we're running on libc++'s own Docker images. This was necessary for
a temporary period until widely-used tools update to a version that can
handle C++20 modules.
However, this had the unintended consequence of breaking the Clang CI
pipeline, which used the libc++ CI scripts as an implementation detail.
Instead, decouple the Clang CI pipeline from the libc++ build scripts.
Differential Revision: https://reviews.llvm.org/D158690
The libc++ builders do not have the capacity to serve both libc++ and
Clang CI needs. We initially used the libc++ builders when adding
pre-commit CI for Clang as an experiment, however this setup has been
problematic for libc++ for a long time. It makes libc++ CI turnaround
way too slow, which has been a frequent source of frustration.
We didn't want to make this change before the release to avoid rocking
the boat too much in such an important time, however now that the
release has been cut, we need to make this change. This will shift
the traffic for Clang pre-commit CI from the libc++ builders to the
builders that have been used for Clang pre-commit CI defined outside
of Clang's BuildKite pipeline.
Differential Revision: https://reviews.llvm.org/D157324
This moves the formatting job to a shell script, which should also fix
the clang pre-commit CI.
Differential Revision: https://reviews.llvm.org/D153920
