//===- ADCE.cpp - Code to perform dead code elimination -------------------===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // //===----------------------------------------------------------------------===// // // This file implements the Aggressive Dead Code Elimination pass. This pass // optimistically assumes that all instructions are dead until proven otherwise, // allowing it to eliminate dead computations that other DCE passes do not // catch, particularly involving loop computations. // //===----------------------------------------------------------------------===// #include "llvm/Transforms/Scalar/ADCE.h" #include "llvm/ADT/DenseMap.h" #include "llvm/ADT/DepthFirstIterator.h" #include "llvm/ADT/GraphTraits.h" #include "llvm/ADT/PostOrderIterator.h" #include "llvm/ADT/SetVector.h" #include "llvm/ADT/SmallPtrSet.h" #include "llvm/ADT/SmallVector.h" #include "llvm/ADT/Statistic.h" #include "llvm/Analysis/CFG.h" #include "llvm/Analysis/DomTreeUpdater.h" #include "llvm/Analysis/GlobalsModRef.h" #include "llvm/Analysis/IteratedDominanceFrontier.h" #include "llvm/Analysis/MemorySSA.h" #include "llvm/Analysis/PostDominators.h" #include "llvm/IR/BasicBlock.h" #include "llvm/IR/CFG.h" #include "llvm/IR/DebugInfo.h" #include "llvm/IR/DebugInfoMetadata.h" #include "llvm/IR/DebugLoc.h" #include "llvm/IR/Dominators.h" #include "llvm/IR/Function.h" #include "llvm/IR/IRBuilder.h" #include "llvm/IR/InstIterator.h" #include "llvm/IR/Instruction.h" #include "llvm/IR/Instructions.h" #include "llvm/IR/IntrinsicInst.h" #include "llvm/IR/PassManager.h" #include "llvm/IR/Use.h" #include "llvm/IR/Value.h" #include "llvm/ProfileData/InstrProf.h" #include "llvm/Support/Casting.h" #include "llvm/Support/CommandLine.h" #include "llvm/Support/Debug.h" #include "llvm/Support/raw_ostream.h" #include "llvm/Transforms/Utils/Local.h" #include #include #include using namespace llvm; #define DEBUG_TYPE "adce" STATISTIC(NumRemoved, "Number of instructions removed"); STATISTIC(NumBranchesRemoved, "Number of branch instructions removed"); // This is a temporary option until we change the interface to this pass based // on optimization level. static cl::opt RemoveControlFlowFlag("adce-remove-control-flow", cl::init(true), cl::Hidden); // This option enables removing of may-be-infinite loops which have no other // effect. static cl::opt RemoveLoops("adce-remove-loops", cl::init(false), cl::Hidden); namespace { /// Information about basic blocks relevant to dead code elimination. struct BlockInfoType { /// True when this block contains a live instructions. bool Live = false; /// True when this block is known to have live PHI nodes. bool HasLivePhiNodes = false; /// Control dependence sources need to be live for this block. bool CFLive = false; /// Post-order numbering of reverse control flow graph. unsigned PostOrder = 0; }; struct ADCEChanged { bool ChangedAnything = false; bool ChangedNonDebugInstr = false; bool ChangedControlFlow = false; }; class AggressiveDeadCodeElimination { Function &F; // ADCE does not use DominatorTree per se, but it updates it to preserve the // analysis. DominatorTree *DT; PostDominatorTree &PDT; /// Mapping of blocks to associated information, indexed by block number. SmallVector BlockInfo; /// Set of live instructions. SmallPtrSet LiveInst; bool isLive(Instruction *I) { return LiveInst.contains(I); } /// Instructions known to be live where we need to mark /// reaching definitions as live. SmallVector Worklist; /// Debug info scopes around a live instruction. SmallPtrSet AliveScopes; /// Set of blocks with not known to have live terminators. SmallSetVector BlocksWithDeadTerminators; /// The set of blocks which we have determined whose control /// dependence sources must be live and which have not had /// those dependences analyzed. SmallPtrSet NewLiveBlocks; /// Set up auxiliary data structures for Instructions and BasicBlocks and /// initialize the Worklist to the set of must-be-live Instruscions. void initialize(); BlockInfoType &getBlockInfo(BasicBlock *BB) { return BlockInfo[BB->getNumber()]; } /// Return true for operations which are always treated as live. bool isAlwaysLive(Instruction &I); /// Return true for instrumentation instructions for value profiling. bool isInstrumentsConstant(Instruction &I); /// Propagate liveness to reaching definitions. void markLiveInstructions(); /// Mark an instruction as live. void markLive(Instruction *I); /// Mark a block as live. void markLive(BasicBlock *BB); /// Mark terminators of control predecessors of a PHI node live. void markPhiLive(PHINode *PN); /// Record the Debug Scopes which surround live debug information. void collectLiveScopes(const DILocalScope &LS); void collectLiveScopes(const DILocation &DL); /// Analyze dead branches to find those whose branches are the sources /// of control dependences impacting a live block. Those branches are /// marked live. void markLiveBranchesFromControlDependences(); /// Remove instructions not marked live, return if any instruction was /// removed. ADCEChanged removeDeadInstructions(); /// Identify connected sections of the control flow graph which have /// dead terminators and rewrite the control flow graph to remove them. bool updateDeadRegions(); /// Set the BlockInfo::PostOrder field based on a post-order /// numbering of the reverse control flow graph. void computeReversePostOrder(); /// Make the terminator of this block an unconditional branch to \p Target. void makeUnconditional(BasicBlock *BB, BasicBlock *Target); public: AggressiveDeadCodeElimination(Function &F, DominatorTree *DT, PostDominatorTree &PDT) : F(F), DT(DT), PDT(PDT) {} ADCEChanged performDeadCodeElimination(); }; } // end anonymous namespace ADCEChanged AggressiveDeadCodeElimination::performDeadCodeElimination() { initialize(); markLiveInstructions(); return removeDeadInstructions(); } void AggressiveDeadCodeElimination::initialize() { BlockInfo.resize(F.getMaxBlockNumber()); size_t NumInsts = 0; for (auto &BB : F) NumInsts += BB.size(); LiveInst.reserve(NumInsts); // Collect the set of "root" instructions that are known live. for (Instruction &I : instructions(F)) if (isAlwaysLive(I)) markLive(&I); if (!RemoveControlFlowFlag) return; if (!RemoveLoops) { // Mark all terminators that have backedges as live. SmallVector> Backedges; FindFunctionBackedges(F, Backedges); for (const auto &[Src, Dst] : Backedges) markLive(const_cast(Src->getTerminator())); } // Mark blocks live if there is no path from the block to a // return of the function. // We do this by seeing which of the postdomtree root children exit the // program, and for all others, mark the subtree live. for (const auto &PDTChild : children(PDT.getRootNode())) { auto *BB = PDTChild->getBlock(); // Real function return if (isa(BB->back())) { LLVM_DEBUG(dbgs() << "post-dom root child is a return: " << BB->getName() << '\n';); continue; } // This child is something else, like an infinite loop. for (auto *DFNode : depth_first(PDTChild)) markLive(&DFNode->getBlock()->back()); } // Treat the entry block as always live auto *BB = &F.getEntryBlock(); auto &EntryInfo = getBlockInfo(BB); EntryInfo.Live = true; if (isa(BB->back())) markLive(&BB->back()); // Build initial collection of blocks with dead terminators for (auto &BB : F) if (!isLive(&BB.back())) BlocksWithDeadTerminators.insert(&BB); } bool AggressiveDeadCodeElimination::isAlwaysLive(Instruction &I) { // TODO -- use llvm::isInstructionTriviallyDead if (I.isEHPad() || I.mayHaveSideEffects()) { // Skip any value profile instrumentation calls if they are // instrumenting constants. if (isInstrumentsConstant(I)) return false; return true; } if (!I.isTerminator()) return false; if (RemoveControlFlowFlag && isa(I)) return false; return true; } // Check if this instruction is a runtime call for value profiling and // if it's instrumenting a constant. bool AggressiveDeadCodeElimination::isInstrumentsConstant(Instruction &I) { // TODO -- move this test into llvm::isInstructionTriviallyDead if (CallInst *CI = dyn_cast(&I)) if (Function *Callee = CI->getCalledFunction()) if (Callee->getName() == getInstrProfValueProfFuncName()) if (isa(CI->getArgOperand(0))) return true; return false; } void AggressiveDeadCodeElimination::markLiveInstructions() { // Propagate liveness backwards to operands. do { // Worklist holds newly discovered live instructions // where we need to mark the inputs as live. while (!Worklist.empty()) { Instruction *LiveInst = Worklist.pop_back_val(); LLVM_DEBUG(dbgs() << "work live: "; LiveInst->dump();); for (Use &OI : LiveInst->operands()) if (Instruction *Inst = dyn_cast(OI)) markLive(Inst); if (auto *PN = dyn_cast(LiveInst)) markPhiLive(PN); } // After data flow liveness has been identified, examine which branch // decisions are required to determine live instructions are executed. markLiveBranchesFromControlDependences(); } while (!Worklist.empty()); } void AggressiveDeadCodeElimination::markLive(Instruction *I) { auto [It, Inserted] = LiveInst.insert(I); if (!Inserted) return; LLVM_DEBUG(dbgs() << "mark live: "; I->dump()); Worklist.push_back(I); // Collect the live debug info scopes attached to this instruction. if (const DILocation *DL = I->getDebugLoc()) collectLiveScopes(*DL); // Mark the containing block live BasicBlock *BB = I->getParent(); if (I == &BB->back()) { BlocksWithDeadTerminators.remove(BB); // For live terminators, mark destination blocks // live to preserve this control flow edges. if (!isa(I)) for (auto *Succ : I->successors()) markLive(Succ); } markLive(BB); } void AggressiveDeadCodeElimination::markLive(BasicBlock *BB) { auto &BBInfo = BlockInfo[BB->getNumber()]; if (BBInfo.Live) return; LLVM_DEBUG(dbgs() << "mark block live: " << BB->getName() << '\n'); BBInfo.Live = true; if (!BBInfo.CFLive) { BBInfo.CFLive = true; NewLiveBlocks.insert(BB); } // Mark unconditional branches at the end of live // blocks as live since there is no work to do for them later if (isa(BB->back())) markLive(&BB->back()); } void AggressiveDeadCodeElimination::collectLiveScopes(const DILocalScope &LS) { if (!AliveScopes.insert(&LS).second) return; if (isa(LS)) return; // Tail-recurse through the scope chain. collectLiveScopes(cast(*LS.getScope())); } void AggressiveDeadCodeElimination::collectLiveScopes(const DILocation &DL) { // Even though DILocations are not scopes, shove them into AliveScopes so we // don't revisit them. if (!AliveScopes.insert(&DL).second) return; // Collect live scopes from the scope chain. collectLiveScopes(*DL.getScope()); // Tail-recurse through the inlined-at chain. if (const DILocation *IA = DL.getInlinedAt()) collectLiveScopes(*IA); } void AggressiveDeadCodeElimination::markPhiLive(PHINode *PN) { auto &Info = getBlockInfo(PN->getParent()); // Only need to check this once per block. if (Info.HasLivePhiNodes) return; Info.HasLivePhiNodes = true; // If a predecessor block is not live, mark it as control-flow live // which will trigger marking live branches upon which // that block is control dependent. for (auto *PredBB : predecessors(PN->getParent())) { auto &Info = getBlockInfo(PredBB); if (!Info.CFLive) { Info.CFLive = true; NewLiveBlocks.insert(PredBB); } } } void AggressiveDeadCodeElimination::markLiveBranchesFromControlDependences() { if (BlocksWithDeadTerminators.empty()) return; LLVM_DEBUG({ dbgs() << "new live blocks:\n"; for (auto *BB : NewLiveBlocks) dbgs() << "\t" << BB->getName() << '\n'; dbgs() << "dead terminator blocks:\n"; for (auto *BB : BlocksWithDeadTerminators) dbgs() << "\t" << BB->getName() << '\n'; }); // The dominance frontier of a live block X in the reverse // control graph is the set of blocks upon which X is control // dependent. The following sequence computes the set of blocks // which currently have dead terminators that are control // dependence sources of a block which is in NewLiveBlocks. const SmallPtrSet BWDT(llvm::from_range, BlocksWithDeadTerminators); SmallVector IDFBlocks; ReverseIDFCalculator IDFs(PDT); IDFs.setDefiningBlocks(NewLiveBlocks); IDFs.setLiveInBlocks(BWDT); IDFs.calculate(IDFBlocks); NewLiveBlocks.clear(); // Dead terminators which control live blocks are now marked live. for (auto *BB : IDFBlocks) { LLVM_DEBUG(dbgs() << "live control in: " << BB->getName() << '\n'); markLive(BB->getTerminator()); } } //===----------------------------------------------------------------------===// // // Routines to update the CFG and SSA information before removing dead code. // //===----------------------------------------------------------------------===// ADCEChanged AggressiveDeadCodeElimination::removeDeadInstructions() { ADCEChanged Changed; // Updates control and dataflow around dead blocks Changed.ChangedControlFlow = updateDeadRegions(); LLVM_DEBUG({ for (Instruction &I : instructions(F)) { // Check if the instruction is alive. if (isLive(&I)) continue; if (auto *DII = dyn_cast(&I)) { // Check if the scope of this variable location is alive. if (AliveScopes.count(DII->getDebugLoc()->getScope())) continue; // If intrinsic is pointing at a live SSA value, there may be an // earlier optimization bug: if we know the location of the variable, // why isn't the scope of the location alive? for (Value *V : DII->location_ops()) { if (Instruction *II = dyn_cast(V)) { if (isLive(II)) { dbgs() << "Dropping debug info for " << *DII << "\n"; break; } } } } } }); // The inverse of the live set is the dead set. These are those instructions // that have no side effects and do not influence the control flow or return // value of the function, and may therefore be deleted safely. // NOTE: We reuse the Worklist vector here for memory efficiency. for (Instruction &I : llvm::reverse(instructions(F))) { // With "RemoveDIs" debug-info stored in DbgVariableRecord objects, // debug-info attached to this instruction, and drop any for scopes that // aren't alive, like the rest of this loop does. Extending support to // assignment tracking is future work. for (DbgRecord &DR : make_early_inc_range(I.getDbgRecordRange())) { // Avoid removing a DVR that is linked to instructions because it holds // information about an existing store. if (DbgVariableRecord *DVR = dyn_cast(&DR); DVR && DVR->isDbgAssign()) if (!at::getAssignmentInsts(DVR).empty()) continue; if (AliveScopes.count(DR.getDebugLoc()->getScope())) continue; I.dropOneDbgRecord(&DR); } // Check if the instruction is alive. if (isLive(&I)) continue; Changed.ChangedNonDebugInstr = true; // Prepare to delete. Worklist.push_back(&I); salvageDebugInfo(I); } for (Instruction *&I : Worklist) I->dropAllReferences(); for (Instruction *&I : Worklist) { ++NumRemoved; I->eraseFromParent(); } Changed.ChangedAnything = Changed.ChangedControlFlow || !Worklist.empty(); return Changed; } // A dead region is the set of dead blocks with a common live post-dominator. bool AggressiveDeadCodeElimination::updateDeadRegions() { LLVM_DEBUG({ dbgs() << "final dead terminator blocks: " << '\n'; for (auto *BB : BlocksWithDeadTerminators) dbgs() << '\t' << BB->getName() << (getBlockInfo(BB).Live ? " LIVE\n" : "\n"); }); // Don't compute the post ordering unless we needed it. bool HavePostOrder = false; bool Changed = false; SmallVector DeletedEdges; for (auto *BB : BlocksWithDeadTerminators) { if (isa(BB->back())) { LiveInst.insert(&BB->back()); continue; } if (!HavePostOrder) { computeReversePostOrder(); HavePostOrder = true; } // Add an unconditional branch to the successor closest to the // end of the function which insures a path to the exit for each // live edge. BasicBlock *PreferredSucc = nullptr; unsigned PreferredSuccPostOrder = 0; for (auto *Succ : successors(BB)) { unsigned SuccPostOrder = BlockInfo[Succ->getNumber()].PostOrder; if (PreferredSuccPostOrder < SuccPostOrder) { PreferredSucc = Succ; PreferredSuccPostOrder = SuccPostOrder; } } assert((PreferredSucc && PreferredSuccPostOrder > 0) && "Failed to find safe successor for dead branch"); // Collect removed successors to update the (Post)DominatorTrees. SmallPtrSet RemovedSuccessors; bool First = true; for (auto *Succ : successors(BB)) { if (!First || Succ != PreferredSucc) { Succ->removePredecessor(BB); RemovedSuccessors.insert(Succ); } else First = false; } makeUnconditional(BB, PreferredSucc); // Inform the dominators about the deleted CFG edges. for (auto *Succ : RemovedSuccessors) { // It might have happened that the same successor appeared multiple times // and the CFG edge wasn't really removed. if (Succ != PreferredSucc) { LLVM_DEBUG(dbgs() << "ADCE: (Post)DomTree edge enqueued for deletion" << BB->getName() << " -> " << Succ->getName() << "\n"); DeletedEdges.push_back({DominatorTree::Delete, BB, Succ}); } } NumBranchesRemoved += 1; Changed = true; } if (!DeletedEdges.empty()) DomTreeUpdater(DT, &PDT, DomTreeUpdater::UpdateStrategy::Eager) .applyUpdates(DeletedEdges); return Changed; } // reverse top-sort order void AggressiveDeadCodeElimination::computeReversePostOrder() { // This provides a post-order numbering of the reverse control flow graph // Note that it is incomplete in the presence of infinite loops but we don't // need numbers blocks which don't reach the end of the functions since // all branches in those blocks are forced live. // For each block without successors, extend the DFS from the block // backward through the graph SmallPtrSet Visited; unsigned PostOrder = 0; for (auto &BB : F) { if (!succ_empty(&BB)) continue; for (BasicBlock *Block : inverse_post_order_ext(&BB,Visited)) getBlockInfo(Block).PostOrder = PostOrder++; } } void AggressiveDeadCodeElimination::makeUnconditional(BasicBlock *BB, BasicBlock *Target) { Instruction *PredTerm = BB->getTerminator(); // Collect the live debug info scopes attached to this instruction. if (const DILocation *DL = PredTerm->getDebugLoc()) collectLiveScopes(*DL); // Just mark live an existing unconditional branch if (auto *BI = dyn_cast(PredTerm)) { BI->setSuccessor(Target); LiveInst.insert(PredTerm); return; } LLVM_DEBUG(dbgs() << "making unconditional " << BB->getName() << '\n'); NumBranchesRemoved += 1; IRBuilder<> Builder(PredTerm); auto *NewTerm = Builder.CreateBr(Target); LiveInst.insert(NewTerm); if (const DILocation *DL = PredTerm->getDebugLoc()) NewTerm->setDebugLoc(DL); PredTerm->eraseFromParent(); } //===----------------------------------------------------------------------===// // // Pass Manager integration code // //===----------------------------------------------------------------------===// PreservedAnalyses ADCEPass::run(Function &F, FunctionAnalysisManager &FAM) { // ADCE does not need DominatorTree, but require DominatorTree here // to update analysis if it is already available. auto *DT = FAM.getCachedResult(F); auto &PDT = FAM.getResult(F); ADCEChanged Changed = AggressiveDeadCodeElimination(F, DT, PDT).performDeadCodeElimination(); if (!Changed.ChangedAnything) return PreservedAnalyses::all(); PreservedAnalyses PA; if (!Changed.ChangedControlFlow) { PA.preserveSet(); if (!Changed.ChangedNonDebugInstr) { // Only removing debug instructions does not affect MemorySSA. // // Therefore we preserve MemorySSA when only removing debug instructions // since otherwise later passes may behave differently which then makes // the presence of debug info affect code generation. PA.preserve(); } } PA.preserve(); PA.preserve(); return PA; }