6f23ba2555
We have a de-facto policy in clang-tidy to not qualify names unless absolutely necessary. We're *mostly* consistent about that (especially in new code), but a number of deviations have accumulated over the years. We even have cases where the same name is sometimes qualified and sometimes not *in the same file*. This makes it jarring to read the code, and, I imagine, more confusing for newcomers to contribute to the project (do I qualify X or not?). This PR tries to improve the situation and regularize the codebase.
65 lines
2.6 KiB
C++
65 lines
2.6 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "IncorrectEnableSharedFromThisCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/AST/DeclCXX.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::bugprone {
|
|
|
|
void IncorrectEnableSharedFromThisCheck::registerMatchers(MatchFinder *Finder) {
|
|
const auto EnableSharedFromThis =
|
|
cxxRecordDecl(hasName("enable_shared_from_this"), isInStdNamespace());
|
|
const auto QType = hasCanonicalType(hasDeclaration(
|
|
cxxRecordDecl(
|
|
anyOf(EnableSharedFromThis.bind("enable_rec"),
|
|
cxxRecordDecl(hasAnyBase(cxxBaseSpecifier(
|
|
isPublic(), hasType(hasCanonicalType(
|
|
hasDeclaration(EnableSharedFromThis))))))))
|
|
.bind("base_rec")));
|
|
Finder->addMatcher(
|
|
cxxRecordDecl(
|
|
hasDirectBase(cxxBaseSpecifier(unless(isPublic()), hasType(QType))
|
|
.bind("base")))
|
|
.bind("derived"),
|
|
this);
|
|
}
|
|
|
|
void IncorrectEnableSharedFromThisCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
const auto *BaseSpec = Result.Nodes.getNodeAs<CXXBaseSpecifier>("base");
|
|
const auto *Base = Result.Nodes.getNodeAs<CXXRecordDecl>("base_rec");
|
|
const auto *Derived = Result.Nodes.getNodeAs<CXXRecordDecl>("derived");
|
|
const bool IsEnableSharedFromThisDirectBase =
|
|
Result.Nodes.getNodeAs<CXXRecordDecl>("enable_rec") == Base;
|
|
const bool HasWrittenAccessSpecifier =
|
|
BaseSpec->getAccessSpecifierAsWritten() != AS_none;
|
|
const auto ReplacementRange = CharSourceRange(
|
|
SourceRange(BaseSpec->getBeginLoc()), HasWrittenAccessSpecifier);
|
|
const StringRef Replacement =
|
|
HasWrittenAccessSpecifier ? "public" : "public ";
|
|
const FixItHint Hint =
|
|
IsEnableSharedFromThisDirectBase
|
|
? FixItHint::CreateReplacement(ReplacementRange, Replacement)
|
|
: FixItHint();
|
|
diag(Derived->getLocation(),
|
|
"%2 is not publicly inheriting from "
|
|
"%select{%1 which inherits from |}0'std::enable_shared_"
|
|
"from_this', "
|
|
"which will cause unintended behaviour "
|
|
"when using 'shared_from_this'; make the inheritance "
|
|
"public",
|
|
DiagnosticIDs::Warning)
|
|
<< IsEnableSharedFromThisDirectBase << Base << Derived << Hint;
|
|
}
|
|
|
|
} // namespace clang::tidy::bugprone
|