529b6fcb00
Check this error for more context
(https://github.com/compiler-research/CppInterOp/actions/runs/14749797085/job/41407625681?pr=491#step:10:531)
This fails with
```
* thread #1, name = 'CppInterOpTests', stop reason = signal SIGSEGV: address not mapped to object (fault address: 0x55500356d6d3)
* frame #0: 0x00007fffee41cfe3 libclangCppInterOp.so.21.0gitclang::PragmaNamespace::~PragmaNamespace() + 99
frame #1: 0x00007fffee435666 libclangCppInterOp.so.21.0gitclang::Preprocessor::~Preprocessor() + 3830
frame #2: 0x00007fffee20917a libclangCppInterOp.so.21.0gitstd::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() + 58
frame #3: 0x00007fffee224796 libclangCppInterOp.so.21.0gitclang::CompilerInstance::~CompilerInstance() + 838
frame #4: 0x00007fffee22494d libclangCppInterOp.so.21.0gitclang::CompilerInstance::~CompilerInstance() + 13
frame #5: 0x00007fffed95ec62 libclangCppInterOp.so.21.0gitclang::IncrementalCUDADeviceParser::~IncrementalCUDADeviceParser() + 98
frame #6: 0x00007fffed9551b6 libclangCppInterOp.so.21.0gitclang::Interpreter::~Interpreter() + 102
frame #7: 0x00007fffed95598d libclangCppInterOp.so.21.0gitclang::Interpreter::~Interpreter() + 13
frame #8: 0x00007fffed9181e7 libclangCppInterOp.so.21.0gitcompat::createClangInterpreter(std::vector<char const*, std::allocator<char const*>>&) + 2919
```
Problem :
1) The destructor currently handles no clearance for the DeviceParser
and the DeviceAct. We currently only have this
9764938224/clang/lib/Interpreter/Interpreter.cpp (L416-L419)
2) The ownership for DeviceCI currently is present in
IncrementalCudaDeviceParser. But this should be similar to how the
combination for hostCI, hostAction and hostParser are managed by the
Interpreter. As on master the DeviceAct and DeviceParser are managed by
the Interpreter but not DeviceCI. This is problematic because :
IncrementalParser holds a Sema& which points into the DeviceCI. On
master, DeviceCI is destroyed before the base class ~IncrementalParser()
runs, causing Parser::reset() to access a dangling Sema (and as Sema
holds a reference to Preprocessor which owns PragmaNamespace) we see
this
```
* frame #0: 0x00007fffee41cfe3 libclangCppInterOp.so.21.0gitclang::PragmaNamespace::~PragmaNamespace() + 99
frame #1: 0x00007fffee435666 libclangCppInterOp.so.21.0gitclang::Preprocessor::~Preprocessor() + 3830
```
55 lines
1.7 KiB
C++
55 lines
1.7 KiB
C++
//===----------- DeviceOffload.h - Device Offloading ------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file implements classes required for offloading to CUDA devices.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_CLANG_LIB_INTERPRETER_DEVICE_OFFLOAD_H
|
|
#define LLVM_CLANG_LIB_INTERPRETER_DEVICE_OFFLOAD_H
|
|
|
|
#include "IncrementalParser.h"
|
|
#include "llvm/Support/FileSystem.h"
|
|
#include "llvm/Support/VirtualFileSystem.h"
|
|
|
|
namespace clang {
|
|
struct PartialTranslationUnit;
|
|
class CompilerInstance;
|
|
class CodeGenOptions;
|
|
class TargetOptions;
|
|
|
|
class IncrementalCUDADeviceParser : public IncrementalParser {
|
|
const std::list<PartialTranslationUnit> &PTUs;
|
|
|
|
public:
|
|
IncrementalCUDADeviceParser(
|
|
CompilerInstance &DeviceInstance, CompilerInstance &HostInstance,
|
|
llvm::IntrusiveRefCntPtr<llvm::vfs::InMemoryFileSystem> VFS,
|
|
llvm::Error &Err, const std::list<PartialTranslationUnit> &PTUs);
|
|
|
|
// Generate PTX for the last PTU.
|
|
llvm::Expected<llvm::StringRef> GeneratePTX();
|
|
|
|
// Generate fatbinary contents in memory
|
|
llvm::Error GenerateFatbinary();
|
|
|
|
~IncrementalCUDADeviceParser();
|
|
|
|
protected:
|
|
int SMVersion;
|
|
llvm::SmallString<1024> PTXCode;
|
|
llvm::SmallVector<char, 1024> FatbinContent;
|
|
llvm::IntrusiveRefCntPtr<llvm::vfs::InMemoryFileSystem> VFS;
|
|
CodeGenOptions &CodeGenOpts; // Intentionally a reference.
|
|
const TargetOptions &TargetOpts;
|
|
};
|
|
|
|
} // namespace clang
|
|
|
|
#endif // LLVM_CLANG_LIB_INTERPRETER_DEVICE_OFFLOAD_H
|