7c402b8b81
The checks for the 'z' and 't' format specifiers added in the original PR #143653 had some issues and were overly strict, causing some build failures and were consequently reverted at4c85bf2fe8. In the latest commit27c58629ec, I relaxed the checks for the 'z' and 't' format specifiers, so warnings are now only issued when they are used with mismatched types. The original intent of these checks was to diagnose code that assumes the underlying type of `size_t` is `unsigned` or `unsigned long`, for example: ```c printf("%zu", 1ul); // Not portable, but not an error when size_t is unsigned long ``` However, it produced a significant number of false positives. This was partly because Clang does not treat the `typedef` `size_t` and `__size_t` as having a common "sugar" type, and partly because a large amount of existing code either assumes `unsigned` (or `unsigned long`) is `size_t`, or they define the equivalent of size_t in their own way (such as sanitizer_internal_defs.h).2e67dcfdcd/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h (L203)
62 lines
2.2 KiB
C
62 lines
2.2 KiB
C
// Check that the more specific checkers report and not the generic
|
|
// StdCLibraryFunctions checker.
|
|
|
|
// RUN: %clang_analyze_cc1 %s \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=unix.Stream \
|
|
// RUN: -analyzer-checker=unix.StdCLibraryFunctions \
|
|
// RUN: -analyzer-config unix.StdCLibraryFunctions:ModelPOSIX=true \
|
|
// RUN: -triple x86_64-unknown-linux-gnu \
|
|
// RUN: -verify
|
|
|
|
|
|
// Make sure that all used functions have their summary loaded.
|
|
|
|
// RUN: %clang_analyze_cc1 %s \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=unix.StdCLibraryFunctions \
|
|
// RUN: -analyzer-config unix.StdCLibraryFunctions:ModelPOSIX=true \
|
|
// RUN: -analyzer-config unix.StdCLibraryFunctions:DisplayLoadedSummaries=true \
|
|
// RUN: -triple x86_64-unknown-linux 2>&1 | FileCheck %s
|
|
|
|
// CHECK: Loaded summary for: int isalnum(int)
|
|
// CHECK: Loaded summary for: __size_t fread(void *restrict, size_t, size_t, FILE *restrict) __attribute__((nonnull(1)))
|
|
// CHECK: Loaded summary for: int fileno(FILE *stream)
|
|
|
|
void initializeSummaryMap(void);
|
|
// We analyze this function first, and the call expression inside initializes
|
|
// the summary map. This way we force the loading of the summaries. The
|
|
// summaries would not be loaded without this because during the first bug
|
|
// report in WeakDependency::checkPreCall we stop further evaluation. And
|
|
// StdLibraryFunctionsChecker lazily initializes its summary map from its
|
|
// checkPreCall.
|
|
void analyzeThisFirst(void) {
|
|
initializeSummaryMap();
|
|
}
|
|
|
|
typedef __typeof(sizeof(int)) size_t;
|
|
struct FILE;
|
|
typedef struct FILE FILE;
|
|
|
|
int isalnum(int);
|
|
size_t fread(void *restrict, size_t, size_t, FILE *restrict) __attribute__((nonnull(1)));
|
|
int fileno(FILE *stream);
|
|
|
|
void test_uninit_arg(void) {
|
|
int v;
|
|
int r = isalnum(v); // \
|
|
// expected-warning{{1st function call argument is an uninitialized value [core.CallAndMessage]}}
|
|
(void)r;
|
|
}
|
|
|
|
void test_notnull_arg(FILE *F) {
|
|
int *p = 0;
|
|
fread(p, sizeof(int), 5, F); // \
|
|
expected-warning{{Null pointer passed to 1st parameter expecting 'nonnull' [core.NonNullParamChecker]}}
|
|
}
|
|
|
|
void test_notnull_stream_arg(void) {
|
|
fileno(0); // \
|
|
// expected-warning{{Stream pointer might be NULL [unix.Stream]}}
|
|
}
|