0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
92 lines
3.1 KiB
Objective-C
92 lines
3.1 KiB
Objective-C
// Note: the run lines follow their respective tests, since line/column numbers
|
|
// matter in this test.
|
|
// This test is for when property accessors do not have their own code
|
|
// completion comments. Use those in their properties in this case.
|
|
|
|
@interface AppDelegate
|
|
/**
|
|
\brief This is ReadonlyProperty
|
|
*/
|
|
@property (readonly, getter = ReadonlyGetter) id MyProperty;
|
|
|
|
/**
|
|
\brief This is GeneralProperty
|
|
*/
|
|
@property int GeneralProperty;
|
|
|
|
/**
|
|
\brief This is PropertyInPrimaryClass
|
|
*/
|
|
@property (copy, nonatomic) id PropertyInPrimaryClass;
|
|
|
|
- (void) setThisRecord : (id)arg;
|
|
- (id) Record;
|
|
@end
|
|
|
|
|
|
@interface AppDelegate()
|
|
- (id) GetterInClassExtension;
|
|
/**
|
|
\brief This is Record
|
|
*/
|
|
@property (copy, setter = setThisRecord:) id Record;
|
|
@end
|
|
|
|
@interface AppDelegate()
|
|
/**
|
|
\brief This is PropertyInClassExtension
|
|
*/
|
|
@property (copy, getter = GetterInClassExtension) id PropertyInClassExtension;
|
|
|
|
- (id) PropertyInPrimaryClass;
|
|
@end
|
|
|
|
@implementation AppDelegate
|
|
- (id) PropertyInPrimaryClass {
|
|
id p = [self ReadonlyGetter];
|
|
p = [self GetterInClassExtension];
|
|
p = [self PropertyInPrimaryClass];
|
|
p = [self Record];
|
|
[self setThisRecord : (id)0 ];
|
|
p = self.GetterInClassExtension;
|
|
return 0;
|
|
}
|
|
@end
|
|
// RUN: env CINDEXTEST_COMPLETION_BRIEF_COMMENTS=1 c-index-test -code-completion-at=%s:46:16 %s | FileCheck -check-prefix=CHECK-CC1 %s
|
|
// CHECK-CC1: {TypedText ReadonlyGetter}{{.*}}(brief comment: This is ReadonlyProperty)
|
|
|
|
// RUN: env CINDEXTEST_COMPLETION_BRIEF_COMMENTS=1 c-index-test -code-completion-at=%s:47:13 %s | FileCheck -check-prefix=CHECK-CC2 %s
|
|
// CHECK-CC2: {TypedText GetterInClassExtension}{{.*}}(brief comment: This is PropertyInClassExtension)
|
|
|
|
// RUN: env CINDEXTEST_COMPLETION_BRIEF_COMMENTS=1 c-index-test -code-completion-at=%s:48:13 %s | FileCheck -check-prefix=CHECK-CC3 %s
|
|
// CHECK-CC3: {TypedText PropertyInPrimaryClass}{{.*}}(brief comment: This is PropertyInPrimaryClass)
|
|
|
|
// RUN: env CINDEXTEST_COMPLETION_BRIEF_COMMENTS=1 c-index-test -code-completion-at=%s:49:13 %s | FileCheck -check-prefix=CHECK-CC4 %s
|
|
// CHECK-CC4: {TypedText Record}{{.*}}(brief comment: This is Record)
|
|
|
|
// RUN: env CINDEXTEST_COMPLETION_BRIEF_COMMENTS=1 c-index-test -code-completion-at=%s:50:9 %s | FileCheck -check-prefix=CHECK-CC5 %s
|
|
// CHECK-CC5: {TypedText setThisRecord:}{Placeholder (id)}{{.*}}(brief comment: This is Record)
|
|
|
|
// RUN: env CINDEXTEST_COMPLETION_BRIEF_COMMENTS=1 c-index-test -code-completion-at=%s:51:12 %s | FileCheck -check-prefix=CHECK-CC6 %s
|
|
// CHECK-CC6: {TypedText GetterInClassExtension}{{.*}}(brief comment: This is PropertyInClassExtension)
|
|
|
|
@interface AnotherAppDelegate
|
|
/**
|
|
\brief This is ReadonlyProperty
|
|
*/
|
|
@property (getter = ReadonlyGetter) int MyProperty;
|
|
/**
|
|
\brief This is getter = ReadonlyGetter
|
|
*/
|
|
- (int) ReadonlyGetter;
|
|
@end
|
|
|
|
@implementation AnotherAppDelegate
|
|
- (int) PropertyInPrimaryClass {
|
|
self.ReadonlyGetter;
|
|
}
|
|
@end
|
|
// RUN: env CINDEXTEST_COMPLETION_BRIEF_COMMENTS=1 c-index-test -code-completion-at=%s:86:6 %s | FileCheck -check-prefix=CHECK-CC7 %s
|
|
// CHECK-CC7: {TypedText ReadonlyGetter}{{.*}}(brief comment: This is getter = ReadonlyGetter)
|
|
|