8ab3caf4d3
Since
[6163aa9](6163aa9679 (diff-3a7ef0bff7d2b73b4100de636f09ea68b72eda191b39c8091a6a1765d917c1a2)),
we have introduced an optimization that almost always destroys
TemplateIdAnnotations at the end of a function declaration. This doesn't
always work properly: a lambda within a default template argument could
also result in such deallocation and hence a use-after-free bug while
building a type constraint on the template parameter.
This patch adds another flag to the parser to tell apart cases when we
shouldn't do such cleanups eagerly. A bit complicated as it is, this retains
the optimization on a highly templated function with lots of generic lambdas.
Note the test doesn't always trigger a conspicuous bug/crash even with a
debug build. But a sanitizer build can detect them, I believe.
Fixes https://github.com/llvm/llvm-project/issues/67235
Fixes https://github.com/llvm/llvm-project/issues/89127
71 lines
1.7 KiB
C++
71 lines
1.7 KiB
C++
// RUN: %clang_cc1 -std=c++2a -x c++ %s -verify
|
|
|
|
namespace type
|
|
{
|
|
template<typename T>
|
|
concept C1 = true;
|
|
|
|
template<C1 T, C1 U = int>
|
|
using A = T[10];
|
|
|
|
using a = A<int>;
|
|
|
|
namespace ns {
|
|
template<typename T, int a = 0>
|
|
concept C2 = true;
|
|
}
|
|
|
|
template<ns::C2 T1, ::type::ns::C2 T2> requires (sizeof(T1) <= sizeof(T2))
|
|
struct B { };
|
|
|
|
using b = B<int, int>;
|
|
|
|
template<ns::C2... T1>
|
|
struct C { };
|
|
|
|
using c1 = C<char, char, char>;
|
|
using c2 = C<char, char, char, char>;
|
|
}
|
|
|
|
namespace non_type
|
|
{
|
|
template<int v>
|
|
concept C1 = true;
|
|
|
|
template<C1 v, C1 u = 0> // expected-error{{expected a type}} // expected-note{{declared here}}
|
|
// expected-error@-1 2{{concept named in type constraint is not a type concept}}
|
|
// expected-error@-2 {{expected ',' or '>' in template-parameter-list}}
|
|
int A = v; // expected-error{{'v' does not refer to a value}}
|
|
}
|
|
|
|
namespace temp
|
|
{
|
|
template<typename>
|
|
struct test1 { }; // expected-note{{template is declared here}}
|
|
|
|
template<template<typename> typename T>
|
|
concept C1 = true;
|
|
|
|
template<C1 TT, C1 UU = test1> // expected-error{{use of class template 'test1' requires template arguments}}
|
|
// expected-error@-1 2{{concept named in type constraint is not a type concept}}
|
|
using A = TT<int>; // expected-error{{expected ';' after alias declaration}}
|
|
}
|
|
|
|
namespace PR67235 {
|
|
|
|
template <class T>
|
|
concept C = true;
|
|
|
|
template <auto D>
|
|
struct S {};
|
|
|
|
// Don't destroy annotation 'C' at the end of the lambda; else we'll run into a
|
|
// use-after-free bug while constructing the type constraint 'C' on 'Default'.
|
|
template <typename Ret, C Default = decltype([] { return Ret(); })>
|
|
void func() {}
|
|
|
|
template <typename Ret, C Default = S<[] { return Ret(); }>>
|
|
void func2() {}
|
|
|
|
}
|