
Summary: Fixes PR41828. Before this, LLD always emitted SafeSEH chunks and defined __safe_se_handler_table & size. Now, /safeseh:no leaves those undefined. Additionally, we were checking for the safeseh @feat.00 flag in two places: once to emit errors, and once during safeseh table construction. The error was set up to be off by default, but safeseh is supposed to be on by default. I combined the two checks, so now LLD emits an error if an input object lacks @feat.00 and safeseh is enabled. This caused the majority of 32-bit LLD tests to fail, since many test input object files lack @feat.00 symbols. I explicitly added -safeseh:no to those tests to preserve behavior. Finally, LLD no longer sets IMAGE_DLL_CHARACTERISTICS_NO_SEH if any input file wasn't compiled for safeseh. Reviewers: mstorsjo, ruiu, thakis Reviewed By: ruiu, thakis Subscribers: llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D63570 llvm-svn: 366238
33 lines
893 B
ArmAsm
33 lines
893 B
ArmAsm
# REQUIRES: x86
|
|
# RUN: llvm-mc -triple i686-windows-msvc %s -o %t.obj -filetype=obj
|
|
# RUN: lld-link -safeseh:no %t.obj -out:%t.dll -dll -nodefaultlib -noentry -export:foo_std=bar_std -export:foo_fast=bar_fast
|
|
# RUN: llvm-nm %t.lib | FileCheck %s
|
|
|
|
# MSVC fudges the lookup of 'bar' to allow it to find the stdcall function
|
|
# _bar_std@8, and then exports _foo_std@8. Same for fastcall and other mangling
|
|
# schemes.
|
|
|
|
# CHECK: export-stdcall.s.tmp.dll:
|
|
# CHECK: 00000000 T @foo_fast@8
|
|
# CHECK: 00000000 T __imp_@foo_fast@8
|
|
|
|
# CHECK: export-stdcall.s.tmp.dll:
|
|
# CHECK: 00000000 T __imp__foo_std@8
|
|
# CHECK: 00000000 T _foo_std@8
|
|
|
|
.text
|
|
.def _bar_std@8; .scl 2; .type 32; .endef
|
|
.globl _bar_std@8
|
|
_bar_std@8:
|
|
movl 8(%esp), %eax
|
|
movl 4(%esp), %ecx
|
|
leal 42(%ecx,%eax), %eax
|
|
retl $8
|
|
|
|
.def @bar_fast@8; .scl 2; .type 32; .endef
|
|
.globl @bar_fast@8
|
|
@bar_fast@8:
|
|
leal 42(%ecx,%eax), %eax
|
|
retl
|
|
|