9ac5620cb8
This patch renames the "Initial" member of WasmLimits to the name used in the spec, "Minimum". In the core WebAssembly specification, the Limits data type has one required "min" member and one optional "max" member, indicating the minimum required size of the corresponding table or memory, and the maximum size, if any. Although the WebAssembly spec does instantiate locally-defined tables and memories with the initial size being equal to the minimum size, it can't impose such a requirement for imports. It doesn't make sense to require an initial size for a memory import, for example. The compiler can only sensibly express the minimum and maximum sizes. See https://github.com/WebAssembly/js-types/blob/master/proposals/js-types/Overview.md#naming-of-size-limits for a related discussion that agrees that the right name of "initial" is "minimum" when querying the type of a table or memory from JavaScript. (Of course it still makes sense for JS to speak in terms of an initial size when it explicitly instantiates memories and tables.) Differential Revision: https://reviews.llvm.org/D99186
25 lines
1.1 KiB
Plaintext
25 lines
1.1 KiB
Plaintext
RUN: llvm-mc -filetype=obj -triple=wasm32-unknown-unknown %p/Inputs/start.s -o %t.o
|
|
|
|
; Verify we can parse large integers such as when we ask for 2G of total
|
|
; memory.
|
|
RUN: wasm-ld %t.o -o %t1.wasm --max-memory=2147483648
|
|
RUN: obj2yaml %t1.wasm | FileCheck %s --check-prefixes=CHECK,CHECK-2G
|
|
|
|
; And also 4G of total memory
|
|
RUN: wasm-ld %t.o -o %t2.wasm --max-memory=4294967296
|
|
RUN: obj2yaml %t2.wasm | FileCheck %s --check-prefixes=CHECK,CHECK-4G
|
|
|
|
CHECK: - Type: MEMORY
|
|
CHECK-NEXT: Memories:
|
|
CHECK-NEXT: - Flags: [ HAS_MAX ]
|
|
CHECK-NEXT: Minimum: 0x2
|
|
CHECK-2G-NEXT: Maximum: 0x8000
|
|
CHECK-4G-NEXT: Maximum: 0x10000
|
|
|
|
; Test error for more than 4G of memory
|
|
RUN: not wasm-ld %t.o -o %t3.wasm --initial-memory=4295032832 2>&1 | FileCheck %s --check-prefix INIT-ERROR
|
|
RUN: not wasm-ld %t.o -o %t4.wasm --max-memory=4295032832 2>&1 | FileCheck %s --check-prefix MAX-ERROR
|
|
|
|
INIT-ERROR: initial memory too large, cannot be greater than 4294967296
|
|
MAX-ERROR: maximum memory too large, cannot be greater than 4294967296
|