
Second attempt at relanding the lldb-rpc-gen tool. This should fix 2 issues: - An assert that was hitting when building on Linux. The assert would hit in the server source emitter, specifically when attemping to determine the storage size for a return type is that is a pointer, but isn't a const char *, const char ** or void pointer. The assert would hit when attempting to generate SBAttachInfo::GetProcessPluginName, which returns a const char * (meaning it shouldn't have been in the code block for the assert at all). The reason that it was hitting the assert when generating this function is that lldb_rpc_gen::TypeIsConstCharPtr was returning false for this function even though it did return a const char *. This was happening because when checking the return type for a const char *, TypeIsConstCharPtr would only check that the underlying type was a signed char. This failed on Linux (but was fine on Darwin), as the underlying type also needs to be checked for being an unsigned char. - Cross compiling support The build for lldb-rpc-gen had no support for cross compiling and as such, the sources generated for lldb-rpc-gen would get compiled too early in phase 2 when cross compiling, before the Clang toolchain was built and this led to an error when trying to include stdlib files. This reland splits this build into 2 by building the tool first and then compiling the sources in the second stage of the cross-compiled build. Original PR Description: This commit upstreams the lldb-rpc-gen tool, a ClangTool that generates the LLDB RPC client and server interfaces. This tool, as well as LLDB RPC itself is built by default. If it needs to be disabled, put -DLLDB_BUILD_LLDBRPC=OFF in your CMake invocation. https://discourse.llvm.org/t/rfc-upstreaming-lldb-rpc/85804 Original PR Link: github.com/llvm/llvm-project/pull/138031
30 lines
842 B
CMake
30 lines
842 B
CMake
add_subdirectory(argdumper)
|
|
add_subdirectory(driver)
|
|
add_subdirectory(intel-features)
|
|
|
|
# We want lldb-test to be built only when it's needed,
|
|
# i.e. if a target requires it as dependency. The typical
|
|
# example is `check-lldb`. So, we pass EXCLUDE_FROM_ALL here.
|
|
add_subdirectory(lldb-test EXCLUDE_FROM_ALL)
|
|
add_subdirectory(lldb-fuzzer EXCLUDE_FROM_ALL)
|
|
|
|
add_lldb_tool_subdirectory(lldb-instr)
|
|
add_lldb_tool_subdirectory(lldb-dap)
|
|
if (LLDB_BUILD_LLDBRPC)
|
|
add_lldb_tool_subdirectory(lldb-rpc-gen)
|
|
endif()
|
|
if (LLDB_CAN_USE_LLDB_RPC_SERVER)
|
|
add_subdirectory(lldb-rpc)
|
|
endif()
|
|
|
|
if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
|
|
add_lldb_tool_subdirectory(darwin-debug)
|
|
if(NOT LLDB_USE_SYSTEM_DEBUGSERVER)
|
|
add_lldb_tool_subdirectory(debugserver)
|
|
endif()
|
|
endif()
|
|
|
|
if (LLDB_CAN_USE_LLDB_SERVER)
|
|
add_lldb_tool_subdirectory(lldb-server)
|
|
endif()
|