llvm-project/lldb/tools/lldb-dap/Handler/StepInRequestHandler.cpp
Ebuka Ezike 33fae08405
[lldb-dap] Forward any error from stepping. (#142652)
The current implementation hides any possible error from performing a
step command.

It makes it easier to know where an issue is from.
2025-06-03 23:40:00 +01:00

64 lines
2.5 KiB
C++

//===-- StepInRequestHandler.cpp ------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "DAP.h"
#include "EventHelper.h"
#include "LLDBUtils.h"
#include "Protocol/ProtocolRequests.h"
#include "Protocol/ProtocolTypes.h"
#include "RequestHandler.h"
using namespace llvm;
using namespace lldb;
using namespace lldb_dap::protocol;
namespace lldb_dap {
// The request resumes the given thread to step into a function/method and
// allows all other threads to run freely by resuming them. If the debug adapter
// supports single thread execution (see capability
// `supportsSingleThreadExecutionRequests`), setting the `singleThread` argument
// to true prevents other suspended threads from resuming. If the request cannot
// step into a target, `stepIn` behaves like the `next` request. The debug
// adapter first sends the response and then a `stopped` event (with reason
// `step`) after the step has completed. If there are multiple function/method
// calls (or other targets) on the source line, the argument `targetId` can be
// used to control into which target the `stepIn` should occur. The list of
// possible targets for a given source line can be retrieved via the
// `stepInTargets` request.
Error StepInRequestHandler::Run(const StepInArguments &args) const {
SBThread thread = dap.GetLLDBThread(args.threadId);
if (!thread.IsValid())
return make_error<DAPError>("invalid thread");
// Remember the thread ID that caused the resume so we can set the
// "threadCausedFocus" boolean value in the "stopped" events.
dap.focus_tid = thread.GetThreadID();
if (!SBDebugger::StateIsStoppedState(dap.target.GetProcess().GetState()))
return make_error<NotStoppedError>();
lldb::SBError error;
if (args.granularity == eSteppingGranularityInstruction) {
thread.StepInstruction(/*step_over=*/false, error);
return ToError(error);
}
std::string step_in_target;
auto it = dap.step_in_targets.find(args.targetId.value_or(0));
if (it != dap.step_in_targets.end())
step_in_target = it->second;
RunMode run_mode = args.singleThread ? eOnlyThisThread : eOnlyDuringStepping;
thread.StepInto(step_in_target.c_str(), LLDB_INVALID_LINE_NUMBER, error,
run_mode);
return ToError(error);
}
} // namespace lldb_dap