63074da25d
RFC https://discourse.llvm.org/t/rfc-dwarfdebug-fix-and-improve-handling-imported-entities-types-and-static-local-in-subprogram-and-lexical-block-scopes/68544 This patch moves the emission of global variables from `DwarfDebug::beginModule()` to `DwarfDebug::endModule()`. It has the following effects: 1. The order of debug entities in the resulting DWARF changes. 2. Currently, if a DISubprogram requires emission of both concrete out-of-line and inlined subprogram DIEs, and such a subprogram contains a static local variable, the DIE for the variable is emitted into the concrete out-of-line subprogram DIE. As a result, the variable is not available in debugger when breaking at the inlined function instance. It happens because static locals are emitted in `DwarfDebug::beginModule()`, but abstract DIEs for functions that are not completely inlined away are created only later during `DwarfDebug::endFunctionImpl()` calls. With this patch, DIEs for static local variables of subprograms that have both inlined and the concrete out-of-line instances are placed into abstract subprogram DIEs. They become visible in debugger when breaking at concrete out-of-line and inlined function instances. `llvm/test/DebugInfo/Generic/inlined-static-var.ll` illustrates that. 3. It will allow to simplify abstract subprogram DIEs creation by reverting https://github.com/llvm/llvm-project/pull/159104 later. This is needed to simplify DWARF emission in a context of proper support of function-local static variables which comes in the next patch (https://reviews.llvm.org/D144008), making all function-local entities handled in `DwarfDebug::endModuleImpl()`. Authored-by: Kristina Bessonova <kbessonova@accesssoftek.com> Co-authored-by: David Blaikie <dblaikie@gmail.com> Co-authored-by: Vladislav Dzhidzhoev <vdzhidzhoev@accesssoftek.com>
57 lines
2.4 KiB
LLVM
57 lines
2.4 KiB
LLVM
; RUN: llc < %s -filetype=obj -o %t
|
|
; RUN: llvm-dwarfdump -v %t | FileCheck %s
|
|
|
|
; C++ source to regenerate:
|
|
; enum __attribute__((enum_extensibility(open))) OpenEnum {
|
|
; oe1
|
|
; } oe;
|
|
;
|
|
; enum __attribute__((enum_extensibility(closed))) ClosedEnum {
|
|
; ce1
|
|
; } ce;
|
|
;
|
|
; $ clang++ -O0 -g debug-info-enum-kind.cpp -c
|
|
|
|
|
|
; CHECK: .debug_abbrev contents:
|
|
|
|
; CHECK: [[[ABBREV_IDX:[0-9]+]]] DW_TAG_enumeration_type DW_CHILDREN_yes
|
|
; CHECK: DW_AT_APPLE_enum_kind DW_FORM_data1
|
|
|
|
; CHECK: .debug_info contents:
|
|
|
|
; CHECK: DW_TAG_enumeration_type [[[ABBREV_IDX]]]
|
|
; CHECK-DAG: DW_AT_name {{.*}} string = "OpenEnum"
|
|
; CHECK-DAG: DW_AT_APPLE_enum_kind [DW_FORM_data1] (DW_APPLE_ENUM_KIND_Open)
|
|
|
|
; CHECK: DW_TAG_enumeration_type [[[ABBREV_IDX]]]
|
|
; CHECK-DAG: DW_AT_name {{.*}} string = "ClosedEnum"
|
|
; CHECK-DAG: DW_AT_APPLE_enum_kind [DW_FORM_data1] (DW_APPLE_ENUM_KIND_Closed)
|
|
|
|
source_filename = "enum.cpp"
|
|
target triple = "arm64-apple-macosx"
|
|
|
|
@oe = global i32 0, align 4, !dbg !0
|
|
@ce = global i32 0, align 4, !dbg !13
|
|
|
|
!llvm.dbg.cu = !{!2}
|
|
!llvm.module.flags = !{!15, !16}
|
|
|
|
!0 = !DIGlobalVariableExpression(var: !1, expr: !DIExpression())
|
|
!1 = distinct !DIGlobalVariable(name: "oe", scope: !2, file: !3, line: 3, type: !5, isLocal: false, isDefinition: true)
|
|
!2 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus_14, file: !3, producer: "clang version 21.0.0git", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !4, globals: !12, splitDebugInlining: false, nameTableKind: Apple, sysroot: "/")
|
|
!3 = !DIFile(filename: "enum.cpp", directory: "/tmp")
|
|
!4 = !{!5, !9}
|
|
!5 = !DICompositeType(tag: DW_TAG_enumeration_type, name: "OpenEnum", file: !3, line: 1, baseType: !6, size: 32, elements: !7, identifier: "_ZTS8OpenEnum", enumKind: DW_APPLE_ENUM_KIND_Open)
|
|
!6 = !DIBasicType(name: "unsigned int", size: 32, encoding: DW_ATE_unsigned)
|
|
!7 = !{!8}
|
|
!8 = !DIEnumerator(name: "oe1", value: 0, isUnsigned: true)
|
|
!9 = !DICompositeType(tag: DW_TAG_enumeration_type, name: "ClosedEnum", file: !3, line: 5, baseType: !6, size: 32, elements: !10, identifier: "_ZTS10ClosedEnum", enumKind: DW_APPLE_ENUM_KIND_Closed)
|
|
!10 = !{!11}
|
|
!11 = !DIEnumerator(name: "ce1", value: 0, isUnsigned: true)
|
|
!12 = !{!0, !13}
|
|
!13 = !DIGlobalVariableExpression(var: !14, expr: !DIExpression())
|
|
!14 = distinct !DIGlobalVariable(name: "ce", scope: !2, file: !3, line: 7, type: !9, isLocal: false, isDefinition: true)
|
|
!15 = !{i32 7, !"Dwarf Version", i32 5}
|
|
!16 = !{i32 2, !"Debug Info Version", i32 3}
|