bb7242477c
Dynamic relocations are expensive on ELF/Linux platforms because they are applied in userspace on process startup. Therefore, it is worth optimizing them to make PIE and PIC dylib builds faster. In +asserts builds (non-NDEBUG), nikic identified these schedule class name string pointers as the leading source of dynamic relocations. [1] This change uses llvm::StringTable and the StringToOffsetTable TableGen helper to turn the string pointers into 32-bit offsets into a separate character array. The number of dynamic relocations is reduced by ~60%: ❯ llvm-readelf --dyn-relocations lib/libLLVM.so | wc -l 381376 # before 155156 # after The test suite time is modestly affected, but I'm running on a shared noisy workstation VM with a ton of cores: https://gist.github.com/rnk/f38882c2fe2e63d0eb58b8fffeab69de Testing Time: 100.88s # before Testing Time: 78.50s. # after Testing Time: 96.25s. # before again I haven't used any fancy hyperfine/denoising tools, but I think the result is clearly visible and we should ship it. [1] https://gist.github.com/nikic/554f0a544ca15d5219788f1030f78c5a
48 lines
1.5 KiB
TableGen
48 lines
1.5 KiB
TableGen
// RUN: llvm-tblgen -gen-subtarget -I %p/../../include %s 2>&1 | FileCheck %s
|
|
// Check if it is valid MCSchedClassDesc if didn't have the resources.
|
|
|
|
include "llvm/Target/Target.td"
|
|
|
|
def MyTarget : Target;
|
|
|
|
let OutOperandList = (outs), InOperandList = (ins) in {
|
|
def Inst_A : Instruction;
|
|
def Inst_B : Instruction;
|
|
}
|
|
|
|
let CompleteModel = 0 in {
|
|
def SchedModel_A: SchedMachineModel;
|
|
def SchedModel_B: SchedMachineModel;
|
|
def SchedModel_C: SchedMachineModel;
|
|
}
|
|
|
|
// Inst_B didn't have the resoures, and it is invalid.
|
|
// CHECK: SchedModel_ASchedClasses[] = {
|
|
// CHECK: {DBGFIELD(/*Inst_A*/ 19) 1
|
|
// CHECK-NEXT: {DBGFIELD(/*Inst_B*/ 26) 8191
|
|
let SchedModel = SchedModel_A in {
|
|
def Write_A : SchedWriteRes<[]>;
|
|
def : InstRW<[Write_A], (instrs Inst_A)>;
|
|
}
|
|
|
|
// Inst_A didn't have the resoures, and it is invalid.
|
|
// CHECK: SchedModel_BSchedClasses[] = {
|
|
// CHECK: {DBGFIELD(/*Inst_A*/ 19) 8191
|
|
// CHECK-NEXT: {DBGFIELD(/*Inst_B*/ 26) 1
|
|
let SchedModel = SchedModel_B in {
|
|
def Write_B: SchedWriteRes<[]>;
|
|
def : InstRW<[Write_B], (instrs Inst_B)>;
|
|
}
|
|
|
|
// CHECK: SchedModel_CSchedClasses[] = {
|
|
// CHECK: {DBGFIELD(/*Inst_A*/ 19) 1
|
|
// CHECK-NEXT: {DBGFIELD(/*Inst_B*/ 26) 1
|
|
let SchedModel = SchedModel_C in {
|
|
def Write_C: SchedWriteRes<[]>;
|
|
def : InstRW<[Write_C], (instrs Inst_A, Inst_B)>;
|
|
}
|
|
|
|
def ProcessorA: ProcessorModel<"ProcessorA", SchedModel_A, []>;
|
|
def ProcessorB: ProcessorModel<"ProcessorB", SchedModel_B, []>;
|
|
def ProcessorC: ProcessorModel<"ProcessorC", SchedModel_C, []>;
|