Anshil Gandhi a89e766ca6
[IndVarSimplify] Add safety check for getTruncateExpr in genLoopLimit (#181296)
getTruncateExpr may not always return a SCEVAddRecExpr when truncating
loop bounds. Add a check to verify the result type before casting, and
bail out of the transformation if the cast would be invalid.

This prevents potential crashes from invalid casts when dealing with
complex loop bounds.

Co-authored by Michael Rowan

Resolves
[https://github.com/llvm/llvm-project/issues/153090](https://github.com/llvm/llvm-project/issues/153090)
2026-02-13 05:52:34 +00:00

150 lines
7.5 KiB
LLVM

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 6
; RUN: opt %s -passes="loop(loop-idiom,indvars,loop-deletion,loop-unroll-full)" -S | FileCheck %s
; REQUIRES: asserts
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128"
define void @loop_limit_test(i32 %conv5, i1 %cmp13, i1 %cmp20, i1 %cmp27, i1 %cmp34, i1 %cmp41) local_unnamed_addr {
; CHECK-LABEL: define void @loop_limit_test(
; CHECK-SAME: i32 [[CONV5:%.*]], i1 [[CMP13:%.*]], i1 [[CMP20:%.*]], i1 [[CMP27:%.*]], i1 [[CMP34:%.*]], i1 [[CMP41:%.*]]) local_unnamed_addr {
; CHECK-NEXT: [[ENTRY:.*:]]
; CHECK-NEXT: [[TMP0:%.*]] = add i32 [[CONV5]], 1
; CHECK-NEXT: [[TMP1:%.*]] = zext i32 [[TMP0]] to i64
; CHECK-NEXT: [[TMP2:%.*]] = zext i32 [[CONV5]] to i64
; CHECK-NEXT: br label %[[FOR_COND:.*]]
; CHECK: [[FOR_COND_LOOPEXIT:.*]]:
; CHECK-NEXT: br label %[[FOR_COND]]
; CHECK: [[FOR_COND]]:
; CHECK-NEXT: br label %[[FOR_COND2:.*]]
; CHECK: [[FOR_COND2]]:
; CHECK-NEXT: [[INDVARS_IV:%.*]] = phi i64 [ [[INDVARS_IV_NEXT:%.*]], %[[FOR_COND_CLEANUP14:.*]] ], [ 0, %[[FOR_COND]] ]
; CHECK-NEXT: [[CMP6:%.*]] = icmp samesign ult i64 [[INDVARS_IV]], [[TMP2]]
; CHECK-NEXT: br i1 [[CMP6]], label %[[FOR_COND9_PREHEADER:.*]], label %[[FOR_COND_LOOPEXIT]]
; CHECK: [[FOR_COND9_PREHEADER]]:
; CHECK-NEXT: br label %[[FOR_COND9:.*]]
; CHECK: [[FOR_COND9_LOOPEXIT:.*]]:
; CHECK-NEXT: br label %[[FOR_COND9]]
; CHECK: [[FOR_COND9]]:
; CHECK-NEXT: br i1 [[CMP13]], label %[[FOR_COND16_PREHEADER:.*]], label %[[FOR_COND_CLEANUP14]]
; CHECK: [[FOR_COND16_PREHEADER]]:
; CHECK-NEXT: br label %[[FOR_COND16:.*]]
; CHECK: [[FOR_COND_CLEANUP14]]:
; CHECK-NEXT: [[INDVARS_IV_NEXT]] = add nuw nsw i64 [[INDVARS_IV]], 1
; CHECK-NEXT: br label %[[FOR_COND2]]
; CHECK: [[FOR_COND16_LOOPEXIT:.*]]:
; CHECK-NEXT: br label %[[FOR_COND16]]
; CHECK: [[FOR_COND16]]:
; CHECK-NEXT: br i1 [[CMP20]], label %[[FOR_COND23_PREHEADER:.*]], label %[[FOR_COND9_LOOPEXIT]]
; CHECK: [[FOR_COND23_PREHEADER]]:
; CHECK-NEXT: br label %[[FOR_COND23:.*]]
; CHECK: [[FOR_COND23_LOOPEXIT:.*]]:
; CHECK-NEXT: br label %[[FOR_COND23]]
; CHECK: [[FOR_COND23]]:
; CHECK-NEXT: br i1 [[CMP27]], label %[[FOR_COND30_PREHEADER:.*]], label %[[FOR_COND16_LOOPEXIT]]
; CHECK: [[FOR_COND30_PREHEADER]]:
; CHECK-NEXT: br label %[[FOR_COND30:.*]]
; CHECK: [[FOR_COND30_LOOPEXIT_LOOPEXIT:.*]]:
; CHECK-NEXT: br label %[[FOR_COND30_LOOPEXIT:.*]]
; CHECK: [[FOR_COND30_LOOPEXIT]]:
; CHECK-NEXT: br label %[[FOR_COND30]]
; CHECK: [[FOR_COND30]]:
; CHECK-NEXT: br i1 [[CMP34]], label %[[FOR_COND37_PREHEADER:.*]], label %[[FOR_COND23_LOOPEXIT]]
; CHECK: [[FOR_COND37_PREHEADER]]:
; CHECK-NEXT: br label %[[FOR_COND37_PEEL_BEGIN:.*]]
; CHECK: [[FOR_COND37_PEEL_BEGIN]]:
; CHECK-NEXT: br label %[[FOR_COND37_PEEL:.*]]
; CHECK: [[FOR_COND37_PEEL]]:
; CHECK-NEXT: br i1 [[CMP41]], label %[[FOR_BODY43_PEEL:.*]], label %[[FOR_COND30_LOOPEXIT]]
; CHECK: [[FOR_BODY43_PEEL]]:
; CHECK-NEXT: [[CONV45_PEEL:%.*]] = zext i32 0 to i64
; CHECK-NEXT: [[CALL31_I_I_PEEL:%.*]] = load volatile i64, ptr null, align 8
; CHECK-NEXT: [[MUL79_I_I_PEEL:%.*]] = mul i64 [[CALL31_I_I_PEEL]], [[INDVARS_IV]]
; CHECK-NEXT: [[DOTIDX1_PEEL:%.*]] = add i64 [[CONV45_PEEL]], [[MUL79_I_I_PEEL]]
; CHECK-NEXT: [[SUB_PTR_LHS_CAST_PEEL:%.*]] = shl i64 [[DOTIDX1_PEEL]], 2
; CHECK-NEXT: [[SUB_PTR_DIV_PEEL:%.*]] = ashr exact i64 [[SUB_PTR_LHS_CAST_PEEL]], 1
; CHECK-NEXT: [[CMP55_PEEL:%.*]] = icmp sgt i64 0, 0
; CHECK-NEXT: call void @llvm.assume(i1 [[CMP55_PEEL]])
; CHECK-NEXT: br label %[[FOR_COND37_PEEL_NEXT:.*]]
; CHECK: [[FOR_COND37_PEEL_NEXT]]:
; CHECK-NEXT: br label %[[FOR_COND37_PEEL_NEXT1:.*]]
; CHECK: [[FOR_COND37_PEEL_NEXT1]]:
; CHECK-NEXT: br label %[[FOR_COND37_PREHEADER_PEEL_NEWPH:.*]]
; CHECK: [[FOR_COND37_PREHEADER_PEEL_NEWPH]]:
; CHECK-NEXT: br label %[[FOR_COND37:.*]]
; CHECK: [[FOR_COND37]]:
; CHECK-NEXT: [[OFFSET_619:%.*]] = phi i64 [ [[SUB_PTR_DIV:%.*]], %[[FOR_BODY43:.*]] ], [ [[SUB_PTR_DIV_PEEL]], %[[FOR_COND37_PREHEADER_PEEL_NEWPH]] ]
; CHECK-NEXT: br i1 [[CMP41]], label %[[FOR_BODY43]], label %[[FOR_COND30_LOOPEXIT_LOOPEXIT]]
; CHECK: [[FOR_BODY43]]:
; CHECK-NEXT: [[CALL31_I_I:%.*]] = load volatile i64, ptr null, align 8
; CHECK-NEXT: [[ADD33_I_I:%.*]] = add i64 [[INDVARS_IV]], [[CALL31_I_I]]
; CHECK-NEXT: [[MUL42_I_I:%.*]] = mul i64 [[TMP1]], [[ADD33_I_I]]
; CHECK-NEXT: [[ADD43_I_I:%.*]] = add i64 [[MUL42_I_I]], 1
; CHECK-NEXT: [[MUL52_I_I:%.*]] = mul i64 [[TMP1]], [[ADD43_I_I]]
; CHECK-NEXT: [[ADD53_I_I:%.*]] = add i64 [[MUL52_I_I]], 1
; CHECK-NEXT: [[MUL62_I_I:%.*]] = mul i64 [[TMP1]], [[ADD53_I_I]]
; CHECK-NEXT: [[ADD63_I_I:%.*]] = add i64 [[MUL62_I_I]], 1
; CHECK-NEXT: [[MUL72_I_I:%.*]] = mul i64 [[INDVARS_IV]], [[ADD63_I_I]]
; CHECK-NEXT: [[MUL79_I_I:%.*]] = mul i64 [[CALL31_I_I]], [[MUL72_I_I]]
; CHECK-NEXT: [[DOTIDX1:%.*]] = add i64 [[TMP1]], [[MUL79_I_I]]
; CHECK-NEXT: [[SUB_PTR_LHS_CAST:%.*]] = shl i64 [[DOTIDX1]], 2
; CHECK-NEXT: [[SUB_PTR_DIV]] = ashr exact i64 [[SUB_PTR_LHS_CAST]], 1
; CHECK-NEXT: [[CMP55:%.*]] = icmp sgt i64 [[OFFSET_619]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[CMP55]])
; CHECK-NEXT: br label %[[FOR_COND37]], !llvm.loop [[LOOP0:![0-9]+]]
;
entry:
br label %for.cond
for.cond: ; preds = %for.cond2, %entry
br label %for.cond2
for.cond2: ; preds = %for.cond.cleanup14, %for.cond
%i5.0 = phi i32 [ 0, %for.cond ], [ %inc70, %for.cond.cleanup14 ]
%cmp6 = icmp ult i32 %i5.0, %conv5
br i1 %cmp6, label %for.cond9, label %for.cond
for.cond9: ; preds = %for.cond16, %for.cond2
br i1 %cmp13, label %for.cond16, label %for.cond.cleanup14
for.cond.cleanup14: ; preds = %for.cond9
%inc70 = add i32 %i5.0, 1
br label %for.cond2
for.cond16: ; preds = %for.cond23, %for.cond9
br i1 %cmp20, label %for.cond23, label %for.cond9
for.cond23: ; preds = %for.cond30, %for.cond16
br i1 %cmp27, label %for.cond30, label %for.cond16
for.cond30: ; preds = %for.cond37, %for.cond23
br i1 %cmp34, label %for.cond37, label %for.cond23
for.cond37: ; preds = %for.body43, %for.cond30
%i0.018 = phi i32 [ %inc, %for.body43 ], [ 0, %for.cond30 ]
%offset.619 = phi i64 [ %sub.ptr.div, %for.body43 ], [ 0, %for.cond30 ]
br i1 %cmp41, label %for.body43, label %for.cond30
for.body43: ; preds = %for.cond37
%conv45 = zext i32 %i0.018 to i64
%conv50 = zext i32 %i5.0 to i64
%call31.i.i = load volatile i64, ptr null, align 8
%add33.i.i = add i64 %conv50, %call31.i.i
%mul42.i.i = mul i64 %conv45, %add33.i.i
%add43.i.i = add i64 %mul42.i.i, 1
%mul52.i.i = mul i64 %conv45, %add43.i.i
%add53.i.i = add i64 %mul52.i.i, 1
%mul62.i.i = mul i64 %conv45, %add53.i.i
%add63.i.i = add i64 %mul62.i.i, 1
%mul72.i.i = mul i64 %conv50, %add63.i.i
%mul79.i.i = mul i64 %call31.i.i, %mul72.i.i
%.idx1 = add i64 %conv45, %mul79.i.i
%sub.ptr.lhs.cast = shl i64 %.idx1, 2
%sub.ptr.div = ashr exact i64 %sub.ptr.lhs.cast, 1
%cmp55 = icmp sgt i64 %offset.619, 0
call void @llvm.assume(i1 %cmp55)
%inc = add i32 %conv5, 1
br label %for.cond37
}
declare void @llvm.assume(i1 noundef)