d2d469eb79
`llvm.wasm.throw` intrinsic can throw but it was not invokable. Not sure
what the rationale was when it was first written that way, but I think
at least in Emscripten's C++ exception support with the Wasm port of
libunwind, `__builtin_wasm_throw`, which is lowered down to
`llvm.wasm.rethrow`, is used only within `_Unwind_RaiseException`, which
is an one-liner and thus does not need an `invoke`:
720e97f76d/system/lib/libunwind/src/Unwind-wasm.c (L69)
(`_Unwind_RaiseException` is called by `__cxa_throw`, which is generated
by the `throw` C++ keyword)
But this does not address other direct uses of the builtin in C++, whose
use I'm not sure about but is not prohibited. Also other language
frontends may need to use the builtin in different functions, which has
`try`-`catch`es or destructors.
This makes `llvm.wasm.throw` invokable in the backend. To do that, this
adds a custom lowering routine to `SelectionDAGBuilder::visitInvoke`,
like we did for `llvm.wasm.rethrow`.
This does not generate `invoke`s for `__builtin_wasm_throw` yet, which
will be done by a follow-up PR.
Addresses #124710.
80 lines
1.8 KiB
LLVM
80 lines
1.8 KiB
LLVM
; RUN: not llvm-as < %s -o /dev/null 2>&1 | FileCheck %s
|
|
|
|
; PR1042
|
|
define i32 @foo() {
|
|
; CHECK: The unwind destination does not have an exception handling instruction
|
|
%A = invoke i32 @foo( )
|
|
to label %L unwind label %L ; <i32> [#uses=1]
|
|
L: ; preds = %0, %0
|
|
ret i32 %A
|
|
}
|
|
|
|
; PR1042
|
|
define i32 @bar() {
|
|
br i1 false, label %L1, label %L2
|
|
L1: ; preds = %0
|
|
%A = invoke i32 @bar( )
|
|
to label %L unwind label %L ; <i32> [#uses=1]
|
|
L2: ; preds = %0
|
|
br label %L
|
|
L: ; preds = %L2, %L1, %L1
|
|
; CHECK: The unwind destination does not have an exception handling instruction
|
|
ret i32 %A
|
|
}
|
|
|
|
|
|
declare i32 @__gxx_personality_v0(...)
|
|
declare void @llvm.donothing()
|
|
declare void @llvm.trap()
|
|
declare i8 @llvm.expect.i8(i8,i8)
|
|
declare i32 @fn(ptr)
|
|
|
|
define void @f1() personality ptr @__gxx_personality_v0 {
|
|
entry:
|
|
; OK
|
|
invoke void @llvm.donothing()
|
|
to label %conta unwind label %contb
|
|
|
|
conta:
|
|
ret void
|
|
|
|
contb:
|
|
%0 = landingpad { ptr, i32 }
|
|
filter [0 x ptr] zeroinitializer
|
|
ret void
|
|
}
|
|
|
|
define i8 @f2() personality ptr @__gxx_personality_v0 {
|
|
entry:
|
|
; CHECK: Cannot invoke an intrinsic other than donothing, patchpoint, statepoint, coro_resume, coro_destroy, clang.arc.attachedcall or wasm.(re)throw
|
|
invoke void @llvm.trap()
|
|
to label %cont unwind label %lpad
|
|
|
|
cont:
|
|
ret i8 3
|
|
|
|
lpad:
|
|
%0 = landingpad { ptr, i32 }
|
|
filter [0 x ptr] zeroinitializer
|
|
ret i8 2
|
|
}
|
|
|
|
define i32 @f3() {
|
|
entry:
|
|
; CHECK: Cannot take the address of an intrinsic
|
|
%call = call i32 @fn(ptr @llvm.expect.i8)
|
|
ret i32 %call
|
|
}
|
|
|
|
define void @f4() personality ptr @__gxx_personality_v0 {
|
|
entry:
|
|
invoke void @llvm.donothing()
|
|
to label %cont unwind label %cont
|
|
|
|
cont:
|
|
; CHECK: Block containing LandingPadInst must be jumped to only by the unwind edge of an invoke.
|
|
%0 = landingpad { ptr, i32 }
|
|
filter [0 x ptr] zeroinitializer
|
|
ret void
|
|
}
|