6f659b0060
Report the range in diagnostics, in addition to the location
in case the range helps disambiguate a little in chained `->`
expressions.
```
b->a->f->x = 1;
^~~~~~~
```
instead of just:
```
b->a->f->x = 1;
^
```
As a followup we should probably also report the location/range
of an `->` if that operator is used. Like:
```
b->a->f->x = 1;
^~
```
69 lines
2.8 KiB
C++
69 lines
2.8 KiB
C++
//===--- UncheckedOptionalAccessCheck.cpp - clang-tidy --------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "UncheckedOptionalAccessCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include "clang/ASTMatchers/ASTMatchers.h"
|
|
#include "clang/Analysis/FlowSensitive/DataflowAnalysis.h"
|
|
#include "clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h"
|
|
#include "clang/Basic/SourceLocation.h"
|
|
#include "llvm/ADT/SmallVector.h"
|
|
#include "llvm/Support/Error.h"
|
|
|
|
namespace clang::tidy::bugprone {
|
|
using ast_matchers::MatchFinder;
|
|
using dataflow::UncheckedOptionalAccessDiagnoser;
|
|
using dataflow::UncheckedOptionalAccessDiagnostic;
|
|
using dataflow::UncheckedOptionalAccessModel;
|
|
|
|
static constexpr llvm::StringLiteral FuncID("fun");
|
|
|
|
void UncheckedOptionalAccessCheck::registerMatchers(MatchFinder *Finder) {
|
|
using namespace ast_matchers;
|
|
|
|
auto HasOptionalCallDescendant = hasDescendant(callExpr(callee(cxxMethodDecl(
|
|
ofClass(UncheckedOptionalAccessModel::optionalClassDecl())))));
|
|
Finder->addMatcher(
|
|
decl(anyOf(functionDecl(unless(isExpansionInSystemHeader()),
|
|
// FIXME: Remove the filter below when lambdas are
|
|
// well supported by the check.
|
|
unless(hasDeclContext(cxxRecordDecl(isLambda()))),
|
|
hasBody(HasOptionalCallDescendant)),
|
|
cxxConstructorDecl(hasAnyConstructorInitializer(
|
|
withInitializer(HasOptionalCallDescendant)))))
|
|
.bind(FuncID),
|
|
this);
|
|
}
|
|
|
|
void UncheckedOptionalAccessCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
if (Result.SourceManager->getDiagnostics().hasUncompilableErrorOccurred())
|
|
return;
|
|
|
|
const auto *FuncDecl = Result.Nodes.getNodeAs<FunctionDecl>(FuncID);
|
|
if (FuncDecl->isTemplated())
|
|
return;
|
|
|
|
UncheckedOptionalAccessDiagnoser Diagnoser(ModelOptions);
|
|
// FIXME: Allow user to set the (defaulted) SAT iterations max for
|
|
// `diagnoseFunction` with config options.
|
|
if (llvm::Expected<llvm::SmallVector<UncheckedOptionalAccessDiagnostic>>
|
|
Diags = dataflow::diagnoseFunction<UncheckedOptionalAccessModel,
|
|
UncheckedOptionalAccessDiagnostic>(
|
|
*FuncDecl, *Result.Context, Diagnoser))
|
|
for (const UncheckedOptionalAccessDiagnostic &Diag : *Diags) {
|
|
diag(Diag.Range.getBegin(), "unchecked access to optional value")
|
|
<< Diag.Range;
|
|
}
|
|
else
|
|
llvm::consumeError(Diags.takeError());
|
|
}
|
|
|
|
} // namespace clang::tidy::bugprone
|