0642cd768b
This patch removes all of the Set.* methods from Status. This cleanup is part of a series of patches that make it harder use the anti-pattern of keeping a long-lives Status object around and updating it while dropping any errors it contains on the floor. This patch is largely NFC, the more interesting next steps this enables is to: 1. remove Status.Clear() 2. assert that Status::operator=() never overwrites an error 3. remove Status::operator=() Note that step (2) will bring 90% of the benefits for users, and step (3) will dramatically clean up the error handling code in various places. In the end my goal is to convert all APIs that are of the form ` ResultTy DoFoo(Status& error) ` to ` llvm::Expected<ResultTy> DoFoo() ` How to read this patch? The interesting changes are in Status.h and Status.cpp, all other changes are mostly ` perl -pi -e 's/\.SetErrorString/ = Status::FromErrorString/g' $(git grep -l SetErrorString lldb/source) ` plus the occasional manual cleanup.
120 lines
3.7 KiB
C++
120 lines
3.7 KiB
C++
//===-- BreakpointID.cpp --------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include <cstdio>
|
|
#include <optional>
|
|
|
|
#include "lldb/Breakpoint/Breakpoint.h"
|
|
#include "lldb/Breakpoint/BreakpointID.h"
|
|
#include "lldb/Utility/Status.h"
|
|
#include "lldb/Utility/Stream.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
BreakpointID::BreakpointID(break_id_t bp_id, break_id_t loc_id)
|
|
: m_break_id(bp_id), m_location_id(loc_id) {}
|
|
|
|
BreakpointID::~BreakpointID() = default;
|
|
|
|
static llvm::StringRef g_range_specifiers[] = {"-", "to", "To", "TO"};
|
|
|
|
// Tells whether or not STR is valid to use between two strings representing
|
|
// breakpoint IDs, to indicate a range of breakpoint IDs. This is broken out
|
|
// into a separate function so that we can easily change or add to the format
|
|
// for specifying ID ranges at a later date.
|
|
|
|
bool BreakpointID::IsRangeIdentifier(llvm::StringRef str) {
|
|
return llvm::is_contained(g_range_specifiers, str);
|
|
}
|
|
|
|
bool BreakpointID::IsValidIDExpression(llvm::StringRef str) {
|
|
return BreakpointID::ParseCanonicalReference(str).has_value();
|
|
}
|
|
|
|
llvm::ArrayRef<llvm::StringRef> BreakpointID::GetRangeSpecifiers() {
|
|
return llvm::ArrayRef(g_range_specifiers);
|
|
}
|
|
|
|
void BreakpointID::GetDescription(Stream *s, lldb::DescriptionLevel level) {
|
|
if (level == eDescriptionLevelVerbose)
|
|
s->Printf("%p BreakpointID:", static_cast<void *>(this));
|
|
|
|
if (m_break_id == LLDB_INVALID_BREAK_ID)
|
|
s->PutCString("<invalid>");
|
|
else if (m_location_id == LLDB_INVALID_BREAK_ID)
|
|
s->Printf("%i", m_break_id);
|
|
else
|
|
s->Printf("%i.%i", m_break_id, m_location_id);
|
|
}
|
|
|
|
void BreakpointID::GetCanonicalReference(Stream *s, break_id_t bp_id,
|
|
break_id_t loc_id) {
|
|
if (bp_id == LLDB_INVALID_BREAK_ID)
|
|
s->PutCString("<invalid>");
|
|
else if (loc_id == LLDB_INVALID_BREAK_ID)
|
|
s->Printf("%i", bp_id);
|
|
else
|
|
s->Printf("%i.%i", bp_id, loc_id);
|
|
}
|
|
|
|
std::optional<BreakpointID>
|
|
BreakpointID::ParseCanonicalReference(llvm::StringRef input) {
|
|
break_id_t bp_id;
|
|
break_id_t loc_id = LLDB_INVALID_BREAK_ID;
|
|
|
|
if (input.empty())
|
|
return std::nullopt;
|
|
|
|
// If it doesn't start with an integer, it's not valid.
|
|
if (input.consumeInteger(0, bp_id))
|
|
return std::nullopt;
|
|
|
|
// period is optional, but if it exists, it must be followed by a number.
|
|
if (input.consume_front(".")) {
|
|
if (input.consumeInteger(0, loc_id))
|
|
return std::nullopt;
|
|
}
|
|
|
|
// And at the end, the entire string must have been consumed.
|
|
if (!input.empty())
|
|
return std::nullopt;
|
|
|
|
return BreakpointID(bp_id, loc_id);
|
|
}
|
|
|
|
bool BreakpointID::StringIsBreakpointName(llvm::StringRef str, Status &error) {
|
|
error.Clear();
|
|
if (str.empty())
|
|
{
|
|
error = Status::FromErrorString("Empty breakpoint names are not allowed");
|
|
return false;
|
|
}
|
|
|
|
// First character must be a letter or _
|
|
if (!isalpha(str[0]) && str[0] != '_')
|
|
{
|
|
error =
|
|
Status::FromErrorStringWithFormatv("Breakpoint names must start with a "
|
|
"character or underscore: {0}",
|
|
str);
|
|
return false;
|
|
}
|
|
|
|
// Cannot contain ., -, or space.
|
|
if (str.find_first_of(".- ") != llvm::StringRef::npos) {
|
|
error =
|
|
Status::FromErrorStringWithFormatv("Breakpoint names cannot contain "
|
|
"'.' or '-' or spaces: \"{0}\"",
|
|
str);
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|