38818b60c5
Use deduction guides instead of helper functions.
The only non-automatic changes have been:
1. ArrayRef(some_uint8_pointer, 0) needs to be changed into ArrayRef(some_uint8_pointer, (size_t)0) to avoid an ambiguous call with ArrayRef((uint8_t*), (uint8_t*))
2. CVSymbol sym(makeArrayRef(symStorage)); needed to be rewritten as CVSymbol sym{ArrayRef(symStorage)}; otherwise the compiler is confused and thinks we have a (bad) function prototype. There was a few similar situation across the codebase.
3. ADL doesn't seem to work the same for deduction-guides and functions, so at some point the llvm namespace must be explicitly stated.
4. The "reference mode" of makeArrayRef(ArrayRef<T> &) that acts as no-op is not supported (a constructor cannot achieve that).
Per reviewers' comment, some useless makeArrayRef have been removed in the process.
This is a follow-up to https://reviews.llvm.org/D140896 that introduced
the deduction guides.
Differential Revision: https://reviews.llvm.org/D140955
36 lines
1.3 KiB
C++
36 lines
1.3 KiB
C++
//===- DebugSymbolRVASubsection.cpp ---------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/DebugInfo/CodeView/DebugSymbolRVASubsection.h"
|
|
#include "llvm/ADT/ArrayRef.h"
|
|
#include "llvm/DebugInfo/CodeView/CodeView.h"
|
|
#include "llvm/Support/BinaryStreamReader.h"
|
|
#include "llvm/Support/BinaryStreamWriter.h"
|
|
#include <cstdint>
|
|
|
|
using namespace llvm;
|
|
using namespace llvm::codeview;
|
|
|
|
DebugSymbolRVASubsectionRef::DebugSymbolRVASubsectionRef()
|
|
: DebugSubsectionRef(DebugSubsectionKind::CoffSymbolRVA) {}
|
|
|
|
Error DebugSymbolRVASubsectionRef::initialize(BinaryStreamReader &Reader) {
|
|
return Reader.readArray(RVAs, Reader.bytesRemaining() / sizeof(uint32_t));
|
|
}
|
|
|
|
DebugSymbolRVASubsection::DebugSymbolRVASubsection()
|
|
: DebugSubsection(DebugSubsectionKind::CoffSymbolRVA) {}
|
|
|
|
Error DebugSymbolRVASubsection::commit(BinaryStreamWriter &Writer) const {
|
|
return Writer.writeArray(ArrayRef(RVAs));
|
|
}
|
|
|
|
uint32_t DebugSymbolRVASubsection::calculateSerializedSize() const {
|
|
return RVAs.size() * sizeof(uint32_t);
|
|
}
|