25b9696b61
This commit releases a checker that was developed to a stable level in
the Ericsson-internal fork of Clang Static Analyzer.
Note that the functionality of this checker overlaps with
core.UndefinedBinaryOperatorResult ("UBOR"), but there are several
differences between them:
(1) UBOR is only triggered when the constant folding performed by the
Clang Static Analyzer engine determines that the value of a binary
operator expression is undefined; this checker can report issues where
the operands are not constants.
(2) UBOR has unrelated checks for handling other binary operators, this
checker only examines bitwise shifts.
(3) This checker has a Pedantic flag and by default does not report
expressions (e.g. -2 << 2) that're undefined by the standard but
consistently supported in practice.
(4) UBOR exhibits buggy behavior in code that involves cast expressions,
e.g.
void foo(unsigned short s) {
if (s == 2) {
(void) ((unsigned int) s) << 16;
}
}
Later it would be good to eliminate this overlap (perhaps by deprecating
and then eliminating the bitwise shift handling in UBOR), but in my
opinion that belongs to separate commits.
Differential Revision: https://reviews.llvm.org/D156312
Co-authored-by: Endre Fulop <endre.fulop@sigmatechnology.se>
43 lines
1.7 KiB
C
43 lines
1.7 KiB
C
// RUN: %clang_analyze_cc1 -analyzer-checker=core.BitwiseShift \
|
|
// RUN: -analyzer-config core.BitwiseShift:Pedantic=true \
|
|
// RUN: -analyzer-checker=debug.ExprInspection \
|
|
// RUN: -analyzer-config eagerly-assume=false \
|
|
// RUN: -verify=expected,c \
|
|
// RUN: -triple x86_64-pc-linux-gnu -x c %s \
|
|
// RUN: -Wno-shift-count-negative -Wno-shift-negative-value \
|
|
// RUN: -Wno-shift-count-overflow -Wno-shift-overflow \
|
|
// RUN: -Wno-shift-sign-overflow
|
|
//
|
|
// RUN: %clang_analyze_cc1 -analyzer-checker=core.BitwiseShift \
|
|
// RUN: -analyzer-config core.BitwiseShift:Pedantic=true \
|
|
// RUN: -analyzer-checker=debug.ExprInspection \
|
|
// RUN: -analyzer-config eagerly-assume=false \
|
|
// RUN: -verify=expected,cxx \
|
|
// RUN: -triple x86_64-pc-linux-gnu -x c++ -std=c++14 %s \
|
|
// RUN: -Wno-shift-count-negative -Wno-shift-negative-value \
|
|
// RUN: -Wno-shift-count-overflow -Wno-shift-overflow \
|
|
// RUN: -Wno-shift-sign-overflow
|
|
|
|
// Tests for validating the state updates provided by the BitwiseShift checker.
|
|
// These clang_analyzer_value() tests are in a separate file because
|
|
// debug.ExprInspection repeats each 'warning' with an superfluous 'note', so
|
|
// note level output (-analyzer-output=text) is not enabled in this file.
|
|
|
|
void clang_analyzer_value(int);
|
|
void clang_analyzer_eval(int);
|
|
|
|
int state_update_generic(int left, int right) {
|
|
int x = left << right;
|
|
clang_analyzer_value(left); // expected-warning {{32s:{ [0, 2147483647] } }}
|
|
clang_analyzer_value(right); // expected-warning {{32s:{ [0, 31] } }}
|
|
return x;
|
|
}
|
|
|
|
int state_update_exact_shift(int arg) {
|
|
int x = 65535 << arg;
|
|
clang_analyzer_value(arg);
|
|
// c-warning@-1 {{32s:{ [0, 15] } }}
|
|
// cxx-warning@-2 {{32s:{ [0, 16] } }}
|
|
return x;
|
|
}
|