56e241a07f
There are currently a few checkers that don't fill in the bug report's "decl-with-issue" field (typically a function in which the bug is found). The new attribute `[[clang::suppress]]` uses decl-with-issue to reduce the size of the suppression source range map so that it didn't need to do that for the entire translation unit. I'm already seeing a few problems with this approach so I'll probably redesign it in some point as it looks like a premature optimization. Not only checkers shouldn't be required to pass decl-with-issue (consider clang-tidy checkers that never had such notion), but also it's not necessarily uniquely determined (consider leak suppressions at allocation site). For now I'm adding a simple stop-gap solution that falls back to building the suppression map for the entire TU whenever decl-with-issue isn't specified. Which won't happen in the default setup because luckily all default checkers do provide decl-with-issue. --------- Co-authored-by: Balazs Benics <benicsbalazs@gmail.com>
125 lines
3.0 KiB
C++
125 lines
3.0 KiB
C++
// RUN: %clang_analyze_cc1 -verify %s \
|
|
// RUN: -analyzer-checker=alpha.clone.CloneChecker \
|
|
// RUN: -analyzer-config alpha.clone.CloneChecker:ReportNormalClones=false \
|
|
// RUN: -analyzer-config alpha.clone.CloneChecker:MinimumCloneComplexity=10
|
|
|
|
// Tests finding a suspicious clone that references local variables.
|
|
|
|
void log();
|
|
|
|
int max(int a, int b) {
|
|
log();
|
|
if (a > b)
|
|
return a;
|
|
return b; // expected-note{{Similar code using 'b' here}}
|
|
}
|
|
|
|
int maxClone(int x, int y, int z) {
|
|
log();
|
|
if (x > y)
|
|
return x;
|
|
return z; // expected-warning{{Potential copy-paste error; did you really mean to use 'z' here?}}
|
|
}
|
|
|
|
// Test that the checker works with [[clang::suppress]].
|
|
int max_suppressed(int a, int b) {
|
|
log();
|
|
if (a > b)
|
|
return a;
|
|
|
|
// This [[clang::suppress]] doesn't suppress anything but we need it here
|
|
// because otherwise the other function won't count as a perfect clone.
|
|
// FIXME: The checker should probably skip the attribute entirely
|
|
// when detecting clones. Otherwise warnings will still get suppressed,
|
|
// but for a completely wrong reason.
|
|
[[clang::suppress]]
|
|
return b; // no-note
|
|
}
|
|
|
|
int maxClone_suppressed(int x, int y, int z) {
|
|
log();
|
|
if (x > y)
|
|
return x;
|
|
[[clang::suppress]]
|
|
return z; // no-warning
|
|
}
|
|
|
|
|
|
// Tests finding a suspicious clone that references global variables.
|
|
|
|
struct mutex {
|
|
bool try_lock();
|
|
void unlock();
|
|
};
|
|
|
|
mutex m1;
|
|
mutex m2;
|
|
int i;
|
|
|
|
void busyIncrement() {
|
|
while (true) {
|
|
if (m1.try_lock()) {
|
|
++i;
|
|
m1.unlock(); // expected-note{{Similar code using 'm1' here}}
|
|
if (i > 1000) {
|
|
return;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
void faultyBusyIncrement() {
|
|
while (true) {
|
|
if (m1.try_lock()) {
|
|
++i;
|
|
m2.unlock(); // expected-warning{{Potential copy-paste error; did you really mean to use 'm2' here?}}
|
|
if (i > 1000) {
|
|
return;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests that we provide two suggestions in cases where two fixes are possible.
|
|
|
|
int foo(int a, int b, int c) {
|
|
a += b + c;
|
|
b /= a + b;
|
|
c -= b * a; // expected-warning{{Potential copy-paste error; did you really mean to use 'b' here?}}
|
|
return c;
|
|
}
|
|
|
|
int fooClone(int a, int b, int c) {
|
|
a += b + c;
|
|
b /= a + b;
|
|
c -= a * a; // expected-note{{Similar code using 'a' here}}
|
|
return c;
|
|
}
|
|
|
|
|
|
// Tests that for clone groups with a many possible suspicious clone pairs, at
|
|
// most one warning per clone group is generated and every relevant clone is
|
|
// reported through either a warning or a note.
|
|
|
|
long bar1(long a, long b, long c, long d) {
|
|
c = a - b;
|
|
c = c / d * a;
|
|
d = b * b - c; // expected-warning{{Potential copy-paste error; did you really mean to use 'b' here?}}
|
|
return d;
|
|
}
|
|
|
|
long bar2(long a, long b, long c, long d) {
|
|
c = a - b;
|
|
c = c / d * a;
|
|
d = c * b - c; // expected-note{{Similar code using 'c' here}} \
|
|
// expected-warning{{Potential copy-paste error; did you really mean to use 'c' here?}}
|
|
return d;
|
|
}
|
|
|
|
long bar3(long a, long b, long c, long d) {
|
|
c = a - b;
|
|
c = c / d * a;
|
|
d = a * b - c; // expected-note{{Similar code using 'a' here}}
|
|
return d;
|
|
}
|