b02d970b43
We observed a failed assert in overloaded compound-assignment operator resolution: ``` Assertion failed: (Result.isInvalid() && "C++ binary operator overloading is missing candidates!"), function CreateOverloadedBinOp, file SemaOverload.cpp, line 13944. ... frame #4: clang` clang::Sema::CreateOverloadedBinOp(..., Opc=BO_OrAssign, ..., PerformADL=true, AllowRewrittenCandidates=false, ...) at SemaOverload.cpp:13943 frame #5: clang` BuildOverloadedBinOp(..., Opc=BO_OrAssign, ...) at SemaExpr.cpp:15228 frame #6: clang` clang::Sema::BuildBinOp(..., Opc=BO_OrAssign, ...) at SemaExpr.cpp:15330 frame #7: clang` clang::Sema::ActOnBinOp(..., Kind=pipeequal, ...) at SemaExpr.cpp:15187 frame #8: clang` clang::Parser::ParseRHSOfBinaryExpression(..., MinPrec=Assignment) at ParseExpr.cpp:629 frame #9: clang` clang::Parser::ParseAssignmentExpression(..., isTypeCast=NotTypeCast) at ParseExpr.cpp:176 frame #10: clang` clang::Parser::ParseExpression(... isTypeCast=NotTypeCast) at ParseExpr.cpp:124 frame #11: clang` clang::Parser::ParseExprStatement(...) at ParseStmt.cpp:464 ``` A simple reproducer is: ``` _Atomic unsigned an_atomic_uint; enum { an_enum_value = 1 }; void enum1() { an_atomic_uint += an_enum_value; } ``` This patch fixes the issue by generating builtin operator overloads for (volatile) _Atomic types. Reviewed By: aaron.ballman Differential Revision: https://reviews.llvm.org/D125349
56 lines
1.5 KiB
C++
56 lines
1.5 KiB
C++
// RUN: %clang_cc1 -std=gnu++11 -emit-llvm -triple=x86_64-linux-gnu -o - %s | FileCheck %s
|
|
|
|
_Atomic unsigned an_atomic_uint;
|
|
|
|
enum { an_enum_value = 1 };
|
|
|
|
// CHECK-LABEL: define {{.*}}void @_Z5enum1v()
|
|
void enum1() {
|
|
an_atomic_uint += an_enum_value;
|
|
// CHECK: atomicrmw add ptr
|
|
}
|
|
|
|
// CHECK-LABEL: define {{.*}}void @_Z5enum2v()
|
|
void enum2() {
|
|
an_atomic_uint |= an_enum_value;
|
|
// CHECK: atomicrmw or ptr
|
|
}
|
|
|
|
// CHECK-LABEL: define {{.*}}void @_Z5enum3RU7_Atomicj({{.*}})
|
|
void enum3(_Atomic unsigned &an_atomic_uint_param) {
|
|
an_atomic_uint_param += an_enum_value;
|
|
// CHECK: atomicrmw add ptr
|
|
}
|
|
|
|
// CHECK-LABEL: define {{.*}}void @_Z5enum4RU7_Atomicj({{.*}})
|
|
void enum4(_Atomic unsigned &an_atomic_uint_param) {
|
|
an_atomic_uint_param |= an_enum_value;
|
|
// CHECK: atomicrmw or ptr
|
|
}
|
|
|
|
volatile _Atomic unsigned an_volatile_atomic_uint;
|
|
|
|
// CHECK-LABEL: define {{.*}}void @_Z5enum5v()
|
|
void enum5() {
|
|
an_volatile_atomic_uint += an_enum_value;
|
|
// CHECK: atomicrmw add ptr
|
|
}
|
|
|
|
// CHECK-LABEL: define {{.*}}void @_Z5enum6v()
|
|
void enum6() {
|
|
an_volatile_atomic_uint |= an_enum_value;
|
|
// CHECK: atomicrmw or ptr
|
|
}
|
|
|
|
// CHECK-LABEL: define {{.*}}void @_Z5enum7RVU7_Atomicj({{.*}})
|
|
void enum7(volatile _Atomic unsigned &an_volatile_atomic_uint_param) {
|
|
an_volatile_atomic_uint_param += an_enum_value;
|
|
// CHECK: atomicrmw add ptr
|
|
}
|
|
|
|
// CHECK-LABEL: define {{.*}}void @_Z5enum8RVU7_Atomicj({{.*}})
|
|
void enum8(volatile _Atomic unsigned &an_volatile_atomic_uint_param) {
|
|
an_volatile_atomic_uint_param |= an_enum_value;
|
|
// CHECK: atomicrmw or ptr
|
|
}
|