0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
128 lines
5.4 KiB
C
128 lines
5.4 KiB
C
// RUN: %clang_cc1 -std=c99 -fsyntax-only -verify -pedantic %s
|
|
// RUN: not %clang_cc1 -E %s 2>&1 | grep 'blonk.c:92:2: error: ABC'
|
|
// RUN: not %clang_cc1 -E %s 2>&1 | grep 'blonk.c:93:2: error: DEF'
|
|
// RUN: not %clang_cc1 -E %s 2>&1 | grep 'line-directive.c:11:2: error: MAIN7'
|
|
// RUN: not %clang_cc1 -E %s 2>&1 | grep 'enter-1:118:2: error: ENTER1'
|
|
// RUN: not %clang_cc1 -E %s 2>&1 | grep 'main:121:2: error: MAIN2'
|
|
|
|
// expected-error@+1{{cannot pop empty include stack}}
|
|
# 20 "" 2
|
|
|
|
// a push/pop before any other line control
|
|
# 10 "enter-0" 1 // expected-warning {{this style of line directive is a GNU extension}}
|
|
# 11 "" 2 // pop to main file: expected-warning {{this style of line directive is a GNU extension}}
|
|
#error MAIN7
|
|
// expected-error@-1{{MAIN7}}
|
|
|
|
#line 'a' // expected-error {{#line directive requires a positive integer argument}}
|
|
#line 0 // expected-warning {{#line directive with zero argument is a GNU extension}}
|
|
#line 00 // expected-warning {{#line directive with zero argument is a GNU extension}}
|
|
#line 2147483648 // expected-warning {{C requires #line number to be less than 2147483648, allowed as extension}}
|
|
#line 42 // ok
|
|
#line 42 'a' // expected-error {{invalid filename for #line directive}}
|
|
#line 42 "foo/bar/baz.h" // ok
|
|
|
|
|
|
// #line directives expand macros.
|
|
#define A 42 "foo"
|
|
#line A
|
|
|
|
# 42 // expected-warning {{this style of line directive is a GNU extension}}
|
|
# 42 "foo" // expected-warning {{this style of line directive is a GNU extension}}
|
|
# 42 "foo" 2 // expected-error {{invalid line marker flag '2': cannot pop empty include stack}}
|
|
// The next two lines do not get diagnosed because they are considered to be
|
|
// within the system header, where diagnostics are suppressed.
|
|
# 42 "foo" 1 3 // enter
|
|
# 42 "foo" 2 3 // exit
|
|
# 42 "foo" 2 3 4 // expected-error {{invalid line marker flag '2': cannot pop empty include stack}}
|
|
# 42 "foo" 3 4 // expected-warning {{this style of line directive is a GNU extension}}
|
|
|
|
# 'a' // expected-error {{invalid preprocessing directive}}
|
|
# 42 'f' // expected-error {{invalid filename for line marker directive}}
|
|
# 42 1 3 // expected-error {{invalid filename for line marker directive}}
|
|
# 42 "foo" 3 1 // expected-error {{invalid flag line marker directive}}
|
|
# 42 "foo" 42 // expected-error {{invalid flag line marker directive}}
|
|
# 42 "foo" 1 2 // expected-error {{invalid flag line marker directive}}
|
|
# 42a33 // expected-error {{GNU line marker directive requires a simple digit sequence}}
|
|
|
|
// These are checked by the RUN line.
|
|
#line 92 "blonk.c"
|
|
#error ABC
|
|
#error DEF
|
|
// expected-error@-2 {{ABC}}
|
|
#line 150
|
|
// expected-error@-3 {{DEF}}
|
|
|
|
|
|
// Verify that linemarker diddling of the system header flag works.
|
|
|
|
# 192 "glomp.h" // not a system header.: expected-warning {{this style of line directive is a GNU extension}}
|
|
typedef int x; // expected-note {{previous definition is here}}
|
|
typedef int x; // expected-warning {{redefinition of typedef 'x' is a C11 feature}}
|
|
|
|
# 192 "glomp.h" 3 // System header.
|
|
typedef int y; // ok
|
|
typedef int y; // ok
|
|
|
|
typedef int q; // q is in system header.
|
|
|
|
#line 42 "blonk.h" // doesn't change system headerness.
|
|
|
|
typedef int z; // ok
|
|
typedef int z; // ok
|
|
|
|
# 97 // doesn't change system headerness.
|
|
|
|
typedef int z1; // ok
|
|
typedef int z1; // ok
|
|
|
|
# 42 "blonk.h" // DOES change system headerness.
|
|
|
|
typedef int w; // expected-note {{previous definition is here}}
|
|
typedef int w; // expected-warning {{redefinition of typedef 'w' is a C11 feature}}
|
|
|
|
typedef int q; // original definition in system header, should not diagnose.
|
|
|
|
// This should not produce an "extra tokens at end of #line directive" warning,
|
|
// because #line is allowed to contain expanded tokens.
|
|
#define EMPTY()
|
|
#line 2 "foo.c" EMPTY( )
|
|
#line 2 "foo.c" NONEMPTY( ) // expected-warning{{extra tokens at end of #line directive}}
|
|
|
|
// PR3940
|
|
#line 0xf // expected-error {{#line directive requires a simple digit sequence}}
|
|
#line 42U // expected-error {{#line directive requires a simple digit sequence}}
|
|
|
|
|
|
// Line markers are digit strings interpreted as decimal numbers, this is
|
|
// 10, not 8.
|
|
#line 010 // expected-warning {{#line directive interprets number as decimal, not octal}}
|
|
extern int array[__LINE__ == 10 ? 1:-1];
|
|
|
|
# 020 // expected-warning {{GNU line marker directive interprets number as decimal, not octal}} expected-warning {{this style of line directive is a GNU extension}}
|
|
extern int array_gnuline[__LINE__ == 20 ? 1:-1];
|
|
|
|
/* PR3917 */
|
|
#line 41
|
|
extern char array2[\
|
|
_\
|
|
_LINE__ == 42 ? 1: -1]; /* line marker is location of first _ */
|
|
|
|
# 51 // expected-warning {{this style of line directive is a GNU extension}}
|
|
extern char array2_gnuline[\
|
|
_\
|
|
_LINE__ == 52 ? 1: -1]; /* line marker is location of first _ */
|
|
|
|
#line 0 "line-directive.c" // expected-warning {{#line directive with zero argument is a GNU extension}}
|
|
undefined t; // expected-error {{unknown type name 'undefined'}}
|
|
|
|
# 115 "main" // expected-warning {{this style of line directive is a GNU extension}}
|
|
# 116 "enter-1" 1 // expected-warning {{this style of line directive is a GNU extension}}
|
|
# 117 "enter-2" 1 // expected-warning {{this style of line directive is a GNU extension}}
|
|
# 118 "" 2 // pop to enter-1: expected-warning {{this style of line directive is a GNU extension}}
|
|
#error ENTER1
|
|
// expected-error@-1{{ENTER1}}
|
|
# 121 "" 2 // pop to "main": expected-warning {{this style of line directive is a GNU extension}}
|
|
#error MAIN2
|
|
// expected-error@-1{{MAIN2}}
|