91cdd35008
This is a major change on how we represent nested name qualifications in the AST. * The nested name specifier itself and how it's stored is changed. The prefixes for types are handled within the type hierarchy, which makes canonicalization for them super cheap, no memory allocation required. Also translating a type into nested name specifier form becomes a no-op. An identifier is stored as a DependentNameType. The nested name specifier gains a lightweight handle class, to be used instead of passing around pointers, which is similar to what is implemented for TemplateName. There is still one free bit available, and this handle can be used within a PointerUnion and PointerIntPair, which should keep bit-packing aficionados happy. * The ElaboratedType node is removed, all type nodes in which it could previously apply to can now store the elaborated keyword and name qualifier, tail allocating when present. * TagTypes can now point to the exact declaration found when producing these, as opposed to the previous situation of there only existing one TagType per entity. This increases the amount of type sugar retained, and can have several applications, for example in tracking module ownership, and other tools which care about source file origins, such as IWYU. These TagTypes are lazily allocated, in order to limit the increase in AST size. This patch offers a great performance benefit. It greatly improves compilation time for [stdexec](https://github.com/NVIDIA/stdexec). For one datapoint, for `test_on2.cpp` in that project, which is the slowest compiling test, this patch improves `-c` compilation time by about 7.2%, with the `-fsyntax-only` improvement being at ~12%. This has great results on compile-time-tracker as well:  This patch also further enables other optimziations in the future, and will reduce the performance impact of template specialization resugaring when that lands. It has some other miscelaneous drive-by fixes. About the review: Yes the patch is huge, sorry about that. Part of the reason is that I started by the nested name specifier part, before the ElaboratedType part, but that had a huge performance downside, as ElaboratedType is a big performance hog. I didn't have the steam to go back and change the patch after the fact. There is also a lot of internal API changes, and it made sense to remove ElaboratedType in one go, versus removing it from one type at a time, as that would present much more churn to the users. Also, the nested name specifier having a different API avoids missing changes related to how prefixes work now, which could make existing code compile but not work. How to review: The important changes are all in `clang/include/clang/AST` and `clang/lib/AST`, with also important changes in `clang/lib/Sema/TreeTransform.h`. The rest and bulk of the changes are mostly consequences of the changes in API. PS: TagType::getDecl is renamed to `getOriginalDecl` in this patch, just for easier to rebasing. I plan to rename it back after this lands. Fixes #136624 Fixes https://github.com/llvm/llvm-project/issues/43179 Fixes https://github.com/llvm/llvm-project/issues/68670 Fixes https://github.com/llvm/llvm-project/issues/92757
367 lines
18 KiB
C++
367 lines
18 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++11 -pedantic -triple=x86_64-linux-gnu -Wno-invalid-utf8
|
||
|
||
int f(); // expected-note {{declared here}}
|
||
|
||
static_assert(f(), "f"); // expected-error {{static assertion expression is not an integral constant expression}} expected-note {{non-constexpr function 'f' cannot be used in a constant expression}}
|
||
static_assert(true, "true is not false");
|
||
static_assert(false, "false is false"); // expected-error {{static assertion failed: false is false}}
|
||
|
||
void g() {
|
||
static_assert(false, "false is false"); // expected-error {{static assertion failed: false is false}}
|
||
}
|
||
|
||
class C {
|
||
static_assert(false, "false is false"); // expected-error {{static assertion failed: false is false}}
|
||
};
|
||
|
||
template<int N> struct T {
|
||
static_assert(N == 2, "N is not 2!"); // expected-error {{static assertion failed due to requirement '1 == 2': N is not 2!}}
|
||
};
|
||
|
||
T<1> t1; // expected-note {{in instantiation of template class 'T<1>' requested here}}
|
||
T<2> t2;
|
||
|
||
template<typename T> struct S {
|
||
static_assert(sizeof(T) > sizeof(char), "Type not big enough!"); // expected-error {{static assertion failed due to requirement 'sizeof(char) > sizeof(char)': Type not big enough!}} \
|
||
// expected-note {{1 > 1}}
|
||
};
|
||
|
||
S<char> s1; // expected-note {{in instantiation of template class 'S<char>' requested here}}
|
||
S<int> s2;
|
||
|
||
static_assert(false, L"\xFFFFFFFF"); // expected-warning {{encoding prefix 'L' on an unevaluated string literal has no effect and is incompatible with c++2c}} \
|
||
// expected-error {{invalid escape sequence '\xFFFFFFFF' in an unevaluated string literal}} \
|
||
// expected-error {{hex escape sequence out of range}}
|
||
static_assert(false, u"\U000317FF"); // expected-warning {{encoding prefix 'u' on an unevaluated string literal has no effect and is incompatible with c++2c}} \
|
||
// expected-error {{static assertion failed}}
|
||
|
||
static_assert(false, u8"Ω"); // expected-warning {{encoding prefix 'u8' on an unevaluated string literal has no effect and is incompatible with c++2c}} \
|
||
// expected-error {{static assertion failed: Ω}}
|
||
static_assert(false, L"\u1234"); // expected-warning {{encoding prefix 'L' on an unevaluated string literal has no effect and is incompatible with c++2c}} \
|
||
// expected-error {{static assertion failed: ሴ}}
|
||
|
||
static_assert(false, L"\x1ff" // expected-warning {{encoding prefix 'L' on an unevaluated string literal has no effect and is incompatible with c++2c}} \
|
||
// expected-error {{hex escape sequence out of range}} \
|
||
// expected-error {{invalid escape sequence '\x1ff' in an unevaluated string literal}}
|
||
"0\x123" // expected-error {{invalid escape sequence '\x123' in an unevaluated string literal}}
|
||
"fx\xfffff" // expected-error {{invalid escape sequence '\xfffff' in an unevaluated string literal}}
|
||
"goop");
|
||
|
||
static_assert(false, "\'\"\?\\\a\b\f\n\r\t\v"); // expected-error {{'"?\<U+0007><U+0008>}}
|
||
static_assert(true, "\xFF"); // expected-error {{invalid escape sequence '\xFF' in an unevaluated string literal}}
|
||
static_assert(true, "\123"); // expected-error {{invalid escape sequence '\123' in an unevaluated string literal}}
|
||
static_assert(true, "\pOh no, a Pascal string!"); // expected-warning {{unknown escape sequence '\p'}} \
|
||
// expected-error {{invalid escape sequence '\p' in an unevaluated string literal}}
|
||
static_assert(false, R"(a
|
||
\tb
|
||
c
|
||
)"); // expected-error@-3 {{static assertion failed: a\n\tb\nc\n}}
|
||
|
||
static_assert(false, "\u0080\u0081\u0082\u0083\u0099\u009A\u009B\u009C\u009D\u009E\u009F");
|
||
// expected-error@-1 {{static assertion failed: <U+0080><U+0081><U+0082><U+0083><U+0099><U+009A><U+009B><U+009C><U+009D><U+009E><U+009F>}}
|
||
|
||
//! Contains RTL/LTR marks
|
||
static_assert(false, "\u200Eabc\u200Fdef\u200Fgh"); // expected-error {{static assertion failed: abcdefgh}}
|
||
|
||
//! Contains ZWJ/regional indicators
|
||
static_assert(false, "🏳️🌈 🏴 🇪🇺"); // expected-error {{static assertion failed: 🏳️🌈 🏴 🇪🇺}}
|
||
|
||
template<typename T> struct AlwaysFails {
|
||
// Only give one error here.
|
||
static_assert(false, ""); // expected-error 2{{static assertion failed}}
|
||
};
|
||
AlwaysFails<int> alwaysFails; // expected-note {{instantiation}}
|
||
AlwaysFails<double> alwaysFails2; // expected-note {{instantiation}}
|
||
|
||
|
||
template<typename T> struct StaticAssertProtected {
|
||
static_assert(__is_literal(T), ""); // expected-error {{static assertion failed}}
|
||
static constexpr T t = {}; // no error here
|
||
};
|
||
struct X { ~X(); };
|
||
StaticAssertProtected<int> sap1;
|
||
StaticAssertProtected<X> sap2; // expected-note {{instantiation}}
|
||
|
||
static_assert(true); // expected-warning {{C++17 extension}}
|
||
static_assert(false); // expected-error-re {{failed{{$}}}} expected-warning {{extension}}
|
||
|
||
|
||
// Diagnostics for static_assert with multiple conditions
|
||
template<typename T> struct first_trait {
|
||
static const bool value = false;
|
||
};
|
||
|
||
template<>
|
||
struct first_trait<X> {
|
||
static const bool value = true;
|
||
};
|
||
|
||
template<typename T> struct second_trait {
|
||
static const bool value = false;
|
||
};
|
||
|
||
static_assert(first_trait<X>::value && second_trait<X>::value, "message"); // expected-error{{static assertion failed due to requirement 'second_trait<X>::value': message}}
|
||
|
||
namespace std {
|
||
|
||
template <class Tp, Tp v>
|
||
struct integral_constant {
|
||
static const Tp value = v;
|
||
typedef Tp value_type;
|
||
typedef integral_constant type;
|
||
constexpr operator value_type() const noexcept { return value; }
|
||
constexpr value_type operator()() const noexcept { return value; }
|
||
};
|
||
|
||
template <class Tp, Tp v>
|
||
const Tp integral_constant<Tp, v>::value;
|
||
|
||
typedef integral_constant<bool, true> true_type;
|
||
typedef integral_constant<bool, false> false_type;
|
||
|
||
template <class Tp>
|
||
struct is_const : public false_type {};
|
||
template <class Tp>
|
||
struct is_const<Tp const> : public true_type {};
|
||
|
||
// We do not define is_same in terms of integral_constant to check that both implementations are supported.
|
||
template <typename T, typename U>
|
||
struct is_same {
|
||
static const bool value = false;
|
||
};
|
||
|
||
template <typename T>
|
||
struct is_same<T, T> {
|
||
static const bool value = true;
|
||
};
|
||
|
||
} // namespace std
|
||
|
||
struct ExampleTypes {
|
||
explicit ExampleTypes(int);
|
||
using T = int;
|
||
using U = float;
|
||
};
|
||
|
||
static_assert(std::is_same<ExampleTypes::T, ExampleTypes::U>::value, "message");
|
||
// expected-error@-1{{static assertion failed due to requirement 'std::is_same<int, float>::value': message}}
|
||
static_assert(std::is_const<ExampleTypes::T>::value, "message");
|
||
// expected-error@-1{{static assertion failed due to requirement 'std::is_const<int>::value': message}}
|
||
static_assert(!std::is_const<const ExampleTypes::T>::value, "message");
|
||
// expected-error@-1{{static assertion failed due to requirement '!std::is_const<const int>::value': message}}
|
||
static_assert(!(std::is_const<const ExampleTypes::T>::value), "message");
|
||
// expected-error@-1{{static assertion failed due to requirement '!(std::is_const<const int>::value)': message}}
|
||
static_assert(std::is_const<const ExampleTypes::T>::value == false, "message");
|
||
// expected-error@-1{{static assertion failed due to requirement 'std::is_const<const int>::value == false': message}}
|
||
static_assert(!(std::is_const<const ExampleTypes::T>::value == true), "message");
|
||
// expected-error@-1{{static assertion failed due to requirement '!(std::is_const<const int>::value == true)': message}}
|
||
static_assert(std::is_const<ExampleTypes::T>(), "message");
|
||
// expected-error@-1{{static assertion failed due to requirement 'std::is_const<int>()': message}}
|
||
static_assert(!(std::is_const<const ExampleTypes::T>()()), "message");
|
||
// expected-error@-1{{static assertion failed due to requirement '!(std::is_const<const int>()())': message}}
|
||
static_assert(std::is_same<decltype(std::is_const<const ExampleTypes::T>()), int>::value, "message");
|
||
// expected-error@-1{{static assertion failed due to requirement 'std::is_same<std::is_const<const int>, int>::value': message}}
|
||
static_assert(std::is_const<decltype(ExampleTypes::T(3))>::value, "message");
|
||
// expected-error@-1{{static assertion failed due to requirement 'std::is_const<int>::value': message}}
|
||
static_assert(std::is_const<decltype(ExampleTypes::T())>::value, "message");
|
||
// expected-error@-1{{static assertion failed due to requirement 'std::is_const<int>::value': message}}
|
||
static_assert(std::is_const<decltype(ExampleTypes(3))>::value, "message");
|
||
// expected-error@-1{{static assertion failed due to requirement 'std::is_const<ExampleTypes>::value': message}}
|
||
|
||
struct BI_tag {};
|
||
struct RAI_tag : BI_tag {};
|
||
struct MyIterator {
|
||
using tag = BI_tag;
|
||
};
|
||
struct MyContainer {
|
||
using iterator = MyIterator;
|
||
};
|
||
template <class Container>
|
||
void foo() {
|
||
static_assert(std::is_same<RAI_tag, typename Container::iterator::tag>::value, "message");
|
||
// expected-error@-1{{static assertion failed due to requirement 'std::is_same<RAI_tag, BI_tag>::value': message}}
|
||
}
|
||
template void foo<MyContainer>();
|
||
// expected-note@-1{{in instantiation of function template specialization 'foo<MyContainer>' requested here}}
|
||
|
||
namespace ns {
|
||
template <typename T, int v>
|
||
struct NestedTemplates1 {
|
||
struct NestedTemplates2 {
|
||
template <typename U>
|
||
struct NestedTemplates3 : public std::is_same<T, U> {};
|
||
};
|
||
};
|
||
} // namespace ns
|
||
|
||
template <typename T, typename U, int a>
|
||
void foo2() {
|
||
// FIXME: Here the template keyword is dropped because the failed condition
|
||
// for a static assert is always printed with canonical types.
|
||
static_assert(::ns::NestedTemplates1<T, a>::NestedTemplates2::template NestedTemplates3<U>::value, "message");
|
||
// expected-error@-1{{static assertion failed due to requirement 'ns::NestedTemplates1<int, 3>::NestedTemplates2::NestedTemplates3<float>::value': message}}
|
||
}
|
||
template void foo2<int, float, 3>();
|
||
// expected-note@-1{{in instantiation of function template specialization 'foo2<int, float, 3>' requested here}}
|
||
|
||
template <class T>
|
||
void foo3(T t) {
|
||
static_assert(std::is_const<T>::value, "message");
|
||
// expected-error-re@-1{{static assertion failed due to requirement 'std::is_const<(lambda at {{.*}}static-assert.cpp:{{[0-9]*}}:{{[0-9]*}})>::value': message}}
|
||
static_assert(std::is_const<decltype(t)>::value, "message");
|
||
// expected-error-re@-1{{static assertion failed due to requirement 'std::is_const<(lambda at {{.*}}static-assert.cpp:{{[0-9]*}}:{{[0-9]*}})>::value': message}}
|
||
}
|
||
void callFoo3() {
|
||
foo3([]() {});
|
||
// expected-note@-1{{in instantiation of function template specialization 'foo3<(lambda at }}
|
||
}
|
||
|
||
template <class T>
|
||
void foo4(T t) {
|
||
static_assert(std::is_const<typename T::iterator>::value, "message");
|
||
// expected-error@-1{{type 'int' cannot be used prior to '::' because it has no members}}
|
||
}
|
||
void callFoo4() { foo4(42); }
|
||
// expected-note@-1{{in instantiation of function template specialization 'foo4<int>' requested here}}
|
||
|
||
static_assert(42, "message");
|
||
static_assert(42.0, "message"); // expected-warning {{implicit conversion from 'double' to 'bool' changes value from 42 to true}}
|
||
constexpr int *p = 0;
|
||
static_assert(p, "message"); // expected-error {{static assertion failed}}
|
||
|
||
struct NotBool {
|
||
} notBool;
|
||
constexpr NotBool constexprNotBool;
|
||
static_assert(notBool, "message"); // expected-error {{value of type 'struct NotBool' is not contextually convertible to 'bool'}}
|
||
static_assert(constexprNotBool, "message"); // expected-error {{value of type 'const NotBool' is not contextually convertible to 'bool'}}
|
||
|
||
static_assert(1 , "") // expected-error {{expected ';' after 'static_assert'}}
|
||
|
||
namespace DependentAlwaysFalse {
|
||
template <typename Ty>
|
||
struct S {
|
||
static_assert(false); // expected-error{{static assertion failed}} \
|
||
// expected-warning {{C++17 extension}}
|
||
};
|
||
|
||
template <typename Ty>
|
||
struct T {
|
||
static_assert(false, "test"); // expected-error{{static assertion failed: test}}
|
||
};
|
||
|
||
int f() {
|
||
S<double> s; //expected-note {{in instantiation of template class 'DependentAlwaysFalse::S<double>' requested here}}
|
||
T<double> t; //expected-note {{in instantiation of template class 'DependentAlwaysFalse::T<double>' requested here}}
|
||
}
|
||
}
|
||
|
||
namespace Diagnostics {
|
||
/// No notes for literals.
|
||
static_assert(false, ""); // expected-error {{failed}}
|
||
static_assert(1.0 > 2.0, ""); // expected-error {{failed}}
|
||
static_assert('c' == 'd', ""); // expected-error {{failed}}
|
||
static_assert(1 == 2, ""); // expected-error {{failed}}
|
||
|
||
/// Simple things are ignored.
|
||
static_assert(1 == (-(1)), ""); //expected-error {{failed}}
|
||
|
||
/// Chars are printed as chars.
|
||
constexpr char getChar() {
|
||
return 'c';
|
||
}
|
||
static_assert(getChar() == 'a', ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to ''c' (0x63, 99) == 'a' (0x61, 97)'}}
|
||
static_assert((char)9 == '\x61', ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to ''\t' (0x09, 9) == 'a' (0x61, 97)'}}
|
||
static_assert((char)10 == '\0', ""); // expected-error {{failed}} \
|
||
// expected-note {{n' (0x0A, 10) == '<U+0000>' (0x00, 0)'}}
|
||
// The note above is intended to match "evaluates to '\n' (0x0A, 10) == '<U+0000>' (0x00, 0)'", but if we write it as it is,
|
||
// the "\n" cannot be consumed by the diagnostic consumer.
|
||
static_assert((signed char)10 == (char)-123, ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to '10 == '<85>' (0x85, -123)'}}
|
||
static_assert((char)-4 == (unsigned char)-8, ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to ''<FC>' (0xFC, -4) == 248'}}
|
||
static_assert((char)-128 == (char)-123, ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to ''<80>' (0x80, -128) == '<85>' (0x85, -123)'}}
|
||
static_assert('\xA0' == (char)'\x20', ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to ''<A0>' (0xA0, -96) == ' ' (0x20, 32)'}}
|
||
static_assert((char16_t)L'ゆ' == L"C̵̭̯̠̎͌ͅť̺"[1], ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to 'u'ゆ' (0x3086, 12422) == L'̵' (0x335, 821)'}}
|
||
static_assert(L"＼／"[1] == u'\xFFFD', ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to 'L'／' (0xFF0F, 65295) == u'<27>' (0xFFFD, 65533)'}}
|
||
static_assert(L"⚾"[0] == U'🌍', ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to 'L'⚾' (0x26BE, 9918) == U'🌍' (0x1F30D, 127757)'}}
|
||
static_assert(U"\a"[0] == (wchar_t)9, ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to 'U'\a' (0x07, 7) == L'\t' (0x09, 9)'}}
|
||
static_assert(L"§"[0] == U'Ö', ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to 'L'§' (0xA7, 167) == U'Ö' (0xD6, 214)'}}
|
||
|
||
/// Bools are printed as bools.
|
||
constexpr bool invert(bool b) {
|
||
return !b;
|
||
}
|
||
|
||
static_assert(invert(true) || invert(true), ""); // expected-error {{static assertion failed due to requirement 'invert(true) || invert(true)'}}
|
||
static_assert(invert(true) == invert(false), ""); // expected-error {{static assertion failed due to requirement 'invert(true) == invert(false)'}} \
|
||
// expected-note {{evaluates to 'false == true'}}
|
||
static_assert(true && false, ""); // expected-error {{static assertion failed due to requirement 'true && false'}}
|
||
static_assert(invert(true) || invert(true) || false, ""); // expected-error {{static assertion failed due to requirement 'invert(true) || invert(true) || false'}}
|
||
static_assert((true && invert(true)) || false, ""); // expected-error {{static assertion failed due to requirement '(true && invert(true)) || false'}}
|
||
static_assert(true && invert(false) && invert(true), ""); // expected-error {{static assertion failed due to requirement 'invert(true)'}}
|
||
|
||
/// No notes here since we compare a bool expression with a bool literal.
|
||
static_assert(invert(true) == true, ""); // expected-error {{failed}}
|
||
|
||
#pragma clang diagnostic push
|
||
#pragma clang diagnostic ignored "-Wc99-extensions"
|
||
constexpr _Complex float com = {5,6};
|
||
constexpr _Complex float com2 = {1, 9};
|
||
static_assert(com == com2, ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to '(5 + 6i) == (1 + 9i)'}}
|
||
#pragma clang diagnostic pop
|
||
|
||
#define CHECK_4(x) ((x) == 4)
|
||
#define A_IS_B (a == b)
|
||
static_assert(CHECK_4(5), ""); // expected-error {{failed}}
|
||
|
||
constexpr int a = 4;
|
||
constexpr int b = 5;
|
||
static_assert(CHECK_4(a) && A_IS_B, ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to '4 == 5'}}
|
||
|
||
static_assert(
|
||
false, // expected-error {{static assertion failed}}
|
||
""
|
||
);
|
||
|
||
static_assert(
|
||
true && false, // expected-error {{static assertion failed due to requirement 'true && false'}}
|
||
""
|
||
);
|
||
|
||
static_assert(
|
||
// with a comment here
|
||
true && false, // expected-error {{static assertion failed due to requirement 'true && false'}}
|
||
""
|
||
);
|
||
|
||
static_assert(
|
||
// with a comment here
|
||
(true && // expected-error {{static assertion failed due to requirement '(true && false) || false'}}
|
||
false)
|
||
|| false,
|
||
""
|
||
);
|
||
|
||
static_assert(1 + 1 != 2, ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to '2 != 2'}}
|
||
static_assert(1 - 1 == 2, ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to '0 == 2'}}
|
||
static_assert(1 * 1 == 2, ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to '1 == 2'}}
|
||
static_assert(1 / 1 == 2, ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to '1 == 2'}}
|
||
static_assert(1 << 3 != 8, ""); // expected-error {{failed}} \
|
||
// expected-note {{evaluates to '8 != 8'}}
|
||
}
|