a29afb754f
HLSL allows implicit conversions to truncate vectors to scalar pr-values. These conversions are scored as vector truncations and should warn appropriately. This change allows forming a truncation cast to a pr-value, but not an l-value. Truncating a vector to a scalar is performed by loading the first element of the vector and disregarding the remaining elements. Fixes #102964
103 lines
6.8 KiB
HLSL
103 lines
6.8 KiB
HLSL
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -fnative-half-type -finclude-default-header -fsyntax-only -Wconversion %s -DERROR=1 -verify
|
|
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -fnative-half-type -finclude-default-header -ast-dump %s | FileCheck %s
|
|
|
|
// Case 1: Prefer conversion over exact match truncation.
|
|
|
|
void Half4Float2(float2 D);
|
|
void Half4Float2(half4 D);
|
|
|
|
void Case1(float4 F, double4 D) {
|
|
// CHECK: CallExpr {{.*}} 'void'
|
|
// CHECK-NEXT: ImplicitCastExpr {{.*}} 'void (*)(half4)' <FunctionToPointerDecay>
|
|
// CHECK-NEXT: DeclRefExpr {{.*}} 'void (half4)' lvalue Function {{.*}} 'Half4Float2' 'void (half4)'
|
|
Half4Float2(F); // expected-warning{{implicit conversion loses floating-point precision: 'float4' (aka 'vector<float, 4>') to 'vector<half, 4>' (vector of 4 'half' values)}}
|
|
}
|
|
|
|
// Case 2: Prefer promotions over conversions when truncating.
|
|
void Half2Double2(double2 D);
|
|
void Half2Double2(half2 H);
|
|
|
|
void Case2(float4 F) {
|
|
// CHECK: CallExpr {{.*}} 'void'
|
|
// CHECK-NEXT: ImplicitCastExpr {{.*}} 'void (*)(double2)' <FunctionToPointerDecay>
|
|
// CHECK-NEXT: DeclRefExpr {{.*}} 'void (double2)' lvalue Function {{.*}} 'Half2Double2' 'void (double2)'
|
|
Half2Double2(F); // expected-warning{{implicit conversion truncates vector: 'float4' (aka 'vector<float, 4>') to 'vector<double, 2>' (vector of 2 'double' values)}}
|
|
}
|
|
|
|
// Case 3: Allow truncation down to vector<T,1> or T.
|
|
void Half(half H);
|
|
void Float(float F);
|
|
void Double(double D);
|
|
|
|
void Half1(half1 H);
|
|
void Float1(float1 F);
|
|
void Double1(double1 D);
|
|
|
|
void Case3(half3 H, float3 F, double3 D) {
|
|
Half(H); // expected-warning{{implicit conversion turns vector to scalar: 'half3' (aka 'vector<half, 3>') to 'half'}}
|
|
Half(F); // expected-warning{{implicit conversion turns vector to scalar: 'float3' (aka 'vector<float, 3>') to 'half'}}
|
|
Half(D); // expected-warning{{implicit conversion turns vector to scalar: 'double3' (aka 'vector<double, 3>') to 'half'}}
|
|
|
|
Float(H); // expected-warning{{implicit conversion turns vector to scalar: 'half3' (aka 'vector<half, 3>') to 'float'}}
|
|
Float(F); // expected-warning{{implicit conversion turns vector to scalar: 'float3' (aka 'vector<float, 3>') to 'float'}}
|
|
Float(D); // expected-warning{{implicit conversion turns vector to scalar: 'double3' (aka 'vector<double, 3>') to 'float'}}
|
|
|
|
Double(H); // expected-warning{{implicit conversion turns vector to scalar: 'half3' (aka 'vector<half, 3>') to 'double'}}
|
|
Double(F); // expected-warning{{implicit conversion turns vector to scalar: 'float3' (aka 'vector<float, 3>') to 'double'}}
|
|
Double(D); // expected-warning{{implicit conversion turns vector to scalar: 'double3' (aka 'vector<double, 3>') to 'double'}}
|
|
|
|
Half1(H); // expected-warning{{implicit conversion truncates vector: 'half3' (aka 'vector<half, 3>') to 'vector<half, 1>' (vector of 1 'half' value)}}
|
|
Half1(F); // expected-warning{{implicit conversion truncates vector: 'float3' (aka 'vector<float, 3>') to 'vector<half, 1>' (vector of 1 'half' value)}} expected-warning{{implicit conversion loses floating-point precision: 'float3' (aka 'vector<float, 3>') to 'vector<half, 1>' (vector of 1 'half' value)}}
|
|
Half1(D); // expected-warning{{implicit conversion truncates vector: 'double3' (aka 'vector<double, 3>') to 'vector<half, 1>' (vector of 1 'half' value)}} expected-warning{{implicit conversion loses floating-point precision: 'double3' (aka 'vector<double, 3>') to 'vector<half, 1>' (vector of 1 'half' value)}}
|
|
|
|
Float1(H); // expected-warning{{implicit conversion truncates vector: 'half3' (aka 'vector<half, 3>') to 'vector<float, 1>' (vector of 1 'float' value)}}
|
|
Float1(F); // expected-warning{{implicit conversion truncates vector: 'float3' (aka 'vector<float, 3>') to 'vector<float, 1>' (vector of 1 'float' value)}}
|
|
Float1(D); // expected-warning{{implicit conversion truncates vector: 'double3' (aka 'vector<double, 3>') to 'vector<float, 1>' (vector of 1 'float' value)}} expected-warning{{implicit conversion loses floating-point precision: 'double3' (aka 'vector<double, 3>') to 'vector<float, 1>' (vector of 1 'float' value)}}
|
|
|
|
Double1(H); // expected-warning{{implicit conversion truncates vector: 'half3' (aka 'vector<half, 3>') to 'vector<double, 1>' (vector of 1 'double' value)}}
|
|
Double1(F); // expected-warning{{implicit conversion truncates vector: 'float3' (aka 'vector<float, 3>') to 'vector<double, 1>' (vector of 1 'double' value)}}
|
|
Double1(D); // expected-warning{{implicit conversion truncates vector: 'double3' (aka 'vector<double, 3>') to 'vector<double, 1>' (vector of 1 'double' value)}}
|
|
}
|
|
|
|
|
|
#if ERROR
|
|
// Case 3: Two promotions or two conversions are ambiguous.
|
|
void Float2Double2(double2 D); // expected-note{{candidate function}}
|
|
void Float2Double2(float2 D); // expected-note{{candidate function}}
|
|
|
|
void Half2Float2(float2 D); // expected-note{{candidate function}}
|
|
void Half2Float2(half2 D); // expected-note{{candidate function}}
|
|
|
|
void Half2Half3(half3 D); // expected-note{{candidate function}} expected-note{{candidate function}} expected-note{{candidate function}}
|
|
void Half2Half3(half2 D); // expected-note{{candidate function}} expected-note{{candidate function}} expected-note{{candidate function}}
|
|
|
|
void Double2Double3(double3 D); // expected-note{{candidate function}} expected-note{{candidate function}} expected-note{{candidate function}}
|
|
void Double2Double3(double2 D); // expected-note{{candidate function}} expected-note{{candidate function}} expected-note{{candidate function}}
|
|
|
|
void Half4Float4Double2(double2 D);
|
|
void Half4Float4Double2(float4 D); // expected-note{{candidate function}}
|
|
void Half4Float4Double2(half4 D); // expected-note{{candidate function}}
|
|
|
|
void Case1(half4 H, float4 F, double4 D) {
|
|
Half4Float4Double2(D); // expected-error {{call to 'Half4Float4Double2' is ambiguous}}
|
|
|
|
Float2Double2(H); // expected-error {{call to 'Float2Double2' is ambiguous}}
|
|
|
|
Half2Float2(D); // expected-error {{call to 'Half2Float2' is ambiguous}}
|
|
|
|
Half2Half3(H); // expected-error {{call to 'Half2Half3' is ambiguous}}
|
|
Half2Half3(F); // expected-error {{call to 'Half2Half3' is ambiguous}}
|
|
Half2Half3(D); // expected-error {{call to 'Half2Half3' is ambiguous}}
|
|
Half2Half3(H.xyz);
|
|
Half2Half3(F.xyz); // expected-warning {{implicit conversion loses floating-point precision: 'vector<float, 3>' (vector of 3 'float' values) to 'vector<half, 3>' (vector of 3 'half' values)}}
|
|
Half2Half3(D.xyz); // expected-warning {{implicit conversion loses floating-point precision: 'vector<double, 3>' (vector of 3 'double' values) to 'vector<half, 3>' (vector of 3 'half' values)}}
|
|
|
|
Double2Double3(H); // expected-error {{call to 'Double2Double3' is ambiguous}}
|
|
Double2Double3(F); // expected-error {{call to 'Double2Double3' is ambiguous}}
|
|
Double2Double3(D); // expected-error {{call to 'Double2Double3' is ambiguous}}
|
|
Double2Double3(D.xyz);
|
|
Double2Double3(F.xyz);
|
|
Double2Double3(H.xyz);
|
|
}
|
|
#endif
|