0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
96 lines
2.5 KiB
Objective-C
96 lines
2.5 KiB
Objective-C
// RUN: %clang_cc1 -triple x86_64-apple-darwin11 -fsyntax-only -fobjc-arc -fblocks -verify -Wno-objc-root-class %s
|
|
|
|
typedef struct dispatch_queue_s *dispatch_queue_t;
|
|
|
|
typedef void (^dispatch_block_t)(void);
|
|
|
|
void dispatch_async(dispatch_queue_t queue, dispatch_block_t block);
|
|
|
|
extern __attribute__((visibility("default"))) struct dispatch_queue_s _dispatch_main_q;
|
|
|
|
@interface SwitchBlockCrashAppDelegate
|
|
- (void)pageLeft;
|
|
- (void)pageRight;;
|
|
@end
|
|
|
|
@implementation SwitchBlockCrashAppDelegate
|
|
|
|
- (void)choose:(int)button {
|
|
switch (button) {
|
|
case 0:
|
|
dispatch_async((&_dispatch_main_q), ^{ [self pageLeft]; }); // expected-note 3 {{jump enters lifetime of block which strongly captures a variable}}
|
|
break;
|
|
case 2: // expected-error {{cannot jump}}
|
|
dispatch_async((&_dispatch_main_q), ^{ [self pageRight]; }); // expected-note 2 {{jump enters lifetime of block which strongly captures a variable}}
|
|
break;
|
|
case 3: // expected-error {{cannot jump}}
|
|
{
|
|
dispatch_async((&_dispatch_main_q), ^{ [self pageRight]; });
|
|
break;
|
|
}
|
|
case 4: // expected-error {{cannot jump}}
|
|
break;
|
|
}
|
|
|
|
__block SwitchBlockCrashAppDelegate *captured_block_obj;
|
|
switch (button) {
|
|
case 10:
|
|
{
|
|
dispatch_async((&_dispatch_main_q), ^{ [self pageLeft]; });
|
|
break;
|
|
}
|
|
case 12:
|
|
if (button)
|
|
dispatch_async((&_dispatch_main_q), ^{ [captured_block_obj pageRight]; });
|
|
break;
|
|
case 13:
|
|
while (button)
|
|
dispatch_async((&_dispatch_main_q), ^{ [self pageRight]; });
|
|
break;
|
|
case 14:
|
|
break;
|
|
}
|
|
|
|
switch (button) {
|
|
case 10:
|
|
{
|
|
dispatch_async((&_dispatch_main_q), ^{ [self pageLeft]; });
|
|
break;
|
|
}
|
|
case 12:
|
|
if (button)
|
|
dispatch_async((&_dispatch_main_q), ^{ [self pageRight]; });
|
|
switch (button) {
|
|
case 0:
|
|
{
|
|
dispatch_async((&_dispatch_main_q), ^{ [self pageLeft]; });
|
|
break;
|
|
}
|
|
case 4:
|
|
break;
|
|
}
|
|
break;
|
|
case 13:
|
|
while (button)
|
|
dispatch_async((&_dispatch_main_q), ^{ [self pageRight]; });
|
|
break;
|
|
case 14:
|
|
break;
|
|
}
|
|
}
|
|
- (void)pageLeft {}
|
|
- (void)pageRight {}
|
|
@end
|
|
|
|
int test2(id obj, int state) { // expected-note {{jump enters lifetime of block}} FIXME: weird location
|
|
switch (state) {
|
|
case 0:
|
|
(void) ^{ (void) obj; };
|
|
return 0;
|
|
|
|
default: // expected-error {{cannot jump}}
|
|
return 1;
|
|
}
|
|
}
|
|
|