0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
80 lines
1.8 KiB
Objective-C
80 lines
1.8 KiB
Objective-C
// RUN: %clang_cc1 -fsyntax-only -verify %s
|
|
|
|
#define nil ((void*) 0)
|
|
|
|
@interface A
|
|
@property int x;
|
|
@end
|
|
|
|
@interface B : A
|
|
@end
|
|
|
|
// Basic checks...
|
|
id f0(int cond, id a, void *b) {
|
|
return cond ? a : b;
|
|
}
|
|
A *f0_a(int cond, A *a, void *b) {
|
|
return cond ? a : b;
|
|
}
|
|
|
|
id f1(int cond, id a) {
|
|
return cond ? a : nil;
|
|
}
|
|
A *f1_a(int cond, A *a) {
|
|
return cond ? a : nil;
|
|
}
|
|
|
|
void *f1_const_a(int x, void *p, const A * q) {
|
|
void *r = x ? p : q; // expected-warning{{initializing 'void *' with an expression of type 'const void *' discards qualifiers}}
|
|
return r;
|
|
}
|
|
|
|
// Check interaction with qualified id
|
|
|
|
@protocol P0 @end
|
|
|
|
id f2(int cond, id<P0> a, void *b) {
|
|
return cond ? a : b;
|
|
}
|
|
|
|
id f3(int cond, id<P0> a) {
|
|
return cond ? a : nil;
|
|
}
|
|
|
|
// Check that result actually has correct type.
|
|
|
|
// Using properties is one way to find the compiler internal type of a
|
|
// conditional expression. Simple assignment doesn't work because if
|
|
// the type is id then it can be implicitly promoted.
|
|
@protocol P1
|
|
@property int x;
|
|
@end
|
|
|
|
int f5(int cond, id<P1> a, id<P1> b) {
|
|
return (cond ? a : b).x;
|
|
}
|
|
int f5_a(int cond, A *a, A *b) {
|
|
return (cond ? a : b).x;
|
|
}
|
|
int f5_b(int cond, A *a, B *b) {
|
|
return (cond ? a : b).x;
|
|
}
|
|
|
|
int f6(int cond, id<P1> a, void *b) {
|
|
// This should result in something with id type, currently.
|
|
return (cond ? a : b).x; // expected-error {{member reference base type 'void *' is not a structure or union}}
|
|
}
|
|
|
|
int f7(int cond, id<P1> a) {
|
|
return (cond ? a : nil).x;
|
|
}
|
|
|
|
int f8(int cond, id<P1> a, A *b) {
|
|
return a == b; // expected-warning {{comparison of distinct pointer types ('id<P1>' and 'A *')}}
|
|
}
|
|
|
|
int f9(int cond, id<P1> a, A *b) {
|
|
return (cond ? a : b).x; // expected-warning {{incompatible operand types ('id<P1>' and 'A *')}} \
|
|
expected-error {{property 'x' not found on object of type 'id'}}
|
|
}
|