Aaron Ballman 0f1c1be196 [clang] Remove rdar links; NFC
We have a new policy in place making links to private resources
something we try to avoid in source and test files. Normally, we'd
organically switch to the new policy rather than make a sweeping change
across a project. However, Clang is in a somewhat special circumstance
currently: recently, I've had several new contributors run into rdar
links around test code which their patch was changing the behavior of.
This turns out to be a surprisingly bad experience, especially for
newer folks, for a handful of reasons: not understanding what the link
is and feeling intimidated by it, wondering whether their changes are
actually breaking something important to a downstream in some way,
having to hunt down strangers not involved with the patch to impose on
them for help, accidental pressure from asking for potentially private
IP to be made public, etc. Because folks run into these links entirely
by chance (through fixing bugs or working on new features), there's not
really a set of problematic links to focus on -- all of the links have
basically the same potential for causing these problems. As a result,
this is an omnibus patch to remove all such links.

This was not a mechanical change; it was done by manually searching for
rdar, radar, radr, and other variants to find all the various
problematic links. From there, I tried to retain or reword the
surrounding comments so that we would lose as little context as
possible. However, because most links were just a plain link with no
supporting context, the majority of the changes are simple removals.

Differential Review: https://reviews.llvm.org/D158071
2023-08-28 12:13:42 -04:00

51 lines
1.6 KiB
Objective-C

// RUN: %clang_cc1 -fsyntax-only -verify -fobjc-exceptions -Wno-objc-root-class %s
void test1(void) {
void *xyzzy = 0;
void *p = @xyzzy; // expected-error {{unexpected '@' in program}}
}
// This previously triggered a crash because the class has not been defined.
@implementation RDar7495713 (rdar_7495713_cat) // expected-error{{cannot find interface declaration for 'RDar7495713'}}
- (id) rdar_7495713 {
__PRETTY_FUNCTION__; // expected-warning{{expression result unused}}
}
@end
// This previously triggered a crash because a ';' was expected after the @throw statement.
void foo(void) {
@throw (id)0 // expected-error{{expected ';' after @throw}}
}
@class NSView;
@implementation IBFillView(IBFillViewIntegration) // expected-error {{cannot find interface declaration for 'IBFillView'}}
- (NSView *)ibDesignableContentView {
[Cake lie]; // expected-error {{undeclared}}
return self;
}
@end
@interface I
@end
@interface I2
@end
@implementation I // expected-note {{started here}}
-(void) foo {}
@implementation I2 // expected-error {{missing '@end'}}
-(void) foo2 {}
@end
@end // expected-error {{'@end' must appear in an Objective-C context}}
@class ForwardBase;
@implementation SomeI : ForwardBase // expected-error {{cannot find interface declaration for 'ForwardBase', superclass of 'SomeI'}} \
// expected-warning {{cannot find interface declaration for 'SomeI'}}
-(void)meth {}
@end
@interface I3
__attribute__((unavailable)) @interface I4 @end // expected-error {{Objective-C declarations may only appear in global scope}}
@end