Raphael Isemann 7de7fe5d0e [lldb] Don't ask for QOS_CLASS_UNSPECIFIED queue in TestQueues
TestQueues is curiously failing for me as my queue for QOS_CLASS_UNSPECIFIED
is named "Utility" and not "User Initiated" or "Default". While debugging, this
I noticed that this test isn't actually using this API right from what I understand. The API documentation
for `dispatch_get_global_queue` specifies for the parameter: "You may specify the value
QOS_CLASS_USER_INTERACTIVE, QOS_CLASS_USER_INITIATED, QOS_CLASS_UTILITY, or QOS_CLASS_BACKGROUND."

QOS_CLASS_UNSPECIFIED isn't listed as one of the supported values. swift-corelibs-libdispatch
even checks for this value and returns a DISPATCH_BAD_INPUT. The
libdispatch shipped on macOS seems to also check for QOS_CLASS_UNSPECIFIED and seems to
instead cause a "client crash", but somehow this doesn't trigger in this test and instead we just
get whatever queue

This patch just removes that part of the test as it appears the code is just incorrect.

Reviewed By: jasonmolenda

Differential Revision: https://reviews.llvm.org/D86211
2020-08-25 20:13:33 +02:00

146 lines
4.4 KiB
C

#include <stdatomic.h>
#include <string.h>
#include <unistd.h>
#include <dispatch/dispatch.h>
#include <pthread.h>
atomic_int finished_enqueueing_work = 0;
atomic_int thread_count = 0;
void
doing_the_work_1(void *in)
{
// This is only counted once because the first job in the queue
// starves all the others.
atomic_fetch_add(&thread_count, 1);
while (1)
sleep (1);
}
void
submit_work_1a(void *in)
{
dispatch_queue_t *work_performer_1 = (dispatch_queue_t*) in;
dispatch_async_f (*work_performer_1, NULL, doing_the_work_1);
dispatch_async_f (*work_performer_1, NULL, doing_the_work_1);
}
void
submit_work_1b(void *in)
{
dispatch_queue_t *work_performer_1 = (dispatch_queue_t*) in;
dispatch_async_f (*work_performer_1, NULL, doing_the_work_1);
dispatch_async_f (*work_performer_1, NULL, doing_the_work_1);
atomic_fetch_add(&thread_count, 1);
while (1)
sleep (1);
}
void
doing_the_work_2(void *in)
{
atomic_fetch_add(&thread_count, 1);
while (1)
sleep (1);
}
void
submit_work_2(void *in)
{
dispatch_queue_t *work_performer_2 = (dispatch_queue_t*) in;
int i = 0;
while (i++ < 5000)
{
dispatch_async_f (*work_performer_2, NULL, doing_the_work_2);
dispatch_async_f (*work_performer_2, NULL, doing_the_work_2);
}
atomic_fetch_add(&finished_enqueueing_work, 1);
}
void
doing_the_work_3(void *in)
{
// This counts four times, since the queue is marked as CONCURRENT.
atomic_fetch_add(&thread_count, 1);
while (1)
sleep (1);
}
void
submit_work_3(void *in)
{
dispatch_queue_t *work_performer_3 = (dispatch_queue_t*) in;
dispatch_async_f (*work_performer_3, NULL, doing_the_work_3);
dispatch_async_f (*work_performer_3, NULL, doing_the_work_3);
dispatch_async_f (*work_performer_3, NULL, doing_the_work_3);
dispatch_async_f (*work_performer_3, NULL, doing_the_work_3);
}
void
stopper ()
{
while (1)
sleep (1);
}
int main (int argc, const char **argv)
{
dispatch_queue_t work_submittor_1 = dispatch_queue_create ("com.apple.work_submittor_1", DISPATCH_QUEUE_SERIAL);
dispatch_queue_t work_submittor_2 = dispatch_queue_create ("com.apple.work_submittor_and_quit_2", DISPATCH_QUEUE_SERIAL);
dispatch_queue_t work_submittor_3 = dispatch_queue_create ("com.apple.work_submittor_3", DISPATCH_QUEUE_SERIAL);
dispatch_queue_t work_performer_1 = dispatch_queue_create ("com.apple.work_performer_1", DISPATCH_QUEUE_SERIAL);
dispatch_queue_t work_performer_2 = dispatch_queue_create ("com.apple.work_performer_2", DISPATCH_QUEUE_SERIAL);
dispatch_queue_t work_performer_3 = dispatch_queue_create ("com.apple.work_performer_3", DISPATCH_QUEUE_CONCURRENT);
dispatch_async_f (work_submittor_1, (void*) &work_performer_1, submit_work_1a);
dispatch_async_f (work_submittor_1, (void*) &work_performer_1, submit_work_1b);
dispatch_async_f (work_submittor_2, (void*) &work_performer_2, submit_work_2);
dispatch_async_f (work_submittor_3, (void*) &work_performer_3, submit_work_3);
// Spin up threads with each of the different libdispatch QoS values.
dispatch_async (dispatch_get_global_queue(QOS_CLASS_USER_INITIATED, 0), ^{
pthread_setname_np ("user initiated QoS");
atomic_fetch_add(&thread_count, 1);
while (1)
sleep (10);
});
dispatch_async (dispatch_get_global_queue(QOS_CLASS_USER_INTERACTIVE, 0), ^{
pthread_setname_np ("user interactive QoS");
atomic_fetch_add(&thread_count, 1);
while (1)
sleep (10);
});
dispatch_async (dispatch_get_global_queue(QOS_CLASS_DEFAULT, 0), ^{
pthread_setname_np ("default QoS");
atomic_fetch_add(&thread_count, 1);
while (1)
sleep (10);
});
dispatch_async (dispatch_get_global_queue(QOS_CLASS_UTILITY, 0), ^{
pthread_setname_np ("utility QoS");
atomic_fetch_add(&thread_count, 1);
while (1)
sleep (10);
});
dispatch_async (dispatch_get_global_queue(QOS_CLASS_BACKGROUND, 0), ^{
pthread_setname_np ("background QoS");
atomic_fetch_add(&thread_count, 1);
while (1)
sleep (10);
});
// Unfortunately there is no pthread_barrier on darwin.
while ((atomic_load(&thread_count) < 12) || (finished_enqueueing_work == 0))
sleep (1);
stopper ();
}