8b3af63b89
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
64 lines
1.8 KiB
C++
64 lines
1.8 KiB
C++
//===-- OsLogger.cpp --------------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "OsLogger.h"
|
|
#include <Availability.h>
|
|
|
|
#if (LLDB_USE_OS_LOG) && (__MAC_OS_X_VERSION_MAX_ALLOWED >= 101200)
|
|
|
|
#include <os/log.h>
|
|
|
|
#include "DNBDefs.h"
|
|
#include "DNBLog.h"
|
|
|
|
#define LLDB_OS_LOG_MAX_BUFFER_LENGTH 256
|
|
|
|
namespace {
|
|
// Darwin os_log logging callback that can be registered with
|
|
// DNBLogSetLogCallback
|
|
void DarwinLogCallback(void *baton, uint32_t flags, const char *format,
|
|
va_list args) {
|
|
if (format == nullptr)
|
|
return;
|
|
|
|
static os_log_t g_logger;
|
|
if (!g_logger) {
|
|
g_logger = os_log_create("com.apple.dt.lldb", "debugserver");
|
|
if (!g_logger)
|
|
return;
|
|
}
|
|
|
|
os_log_type_t log_type;
|
|
if (flags & DNBLOG_FLAG_FATAL)
|
|
log_type = OS_LOG_TYPE_FAULT;
|
|
else if (flags & DNBLOG_FLAG_ERROR)
|
|
log_type = OS_LOG_TYPE_ERROR;
|
|
else if (flags & DNBLOG_FLAG_WARNING)
|
|
log_type = OS_LOG_TYPE_DEFAULT;
|
|
else if (flags & DNBLOG_FLAG_VERBOSE)
|
|
log_type = OS_LOG_TYPE_DEBUG;
|
|
else
|
|
log_type = OS_LOG_TYPE_DEFAULT;
|
|
|
|
// This code is unfortunate. os_log* only takes static strings, but
|
|
// our current log API isn't set up to make use of that style.
|
|
char buffer[LLDB_OS_LOG_MAX_BUFFER_LENGTH];
|
|
vsnprintf(buffer, sizeof(buffer), format, args);
|
|
os_log_with_type(g_logger, log_type, "%{public}s", buffer);
|
|
}
|
|
}
|
|
|
|
DNBCallbackLog OsLogger::GetLogFunction() { return DarwinLogCallback; }
|
|
|
|
#else
|
|
|
|
DNBCallbackLog OsLogger::GetLogFunction() { return nullptr; }
|
|
|
|
#endif
|
|
|