67d3ef74b3
This PR continues https://github.com/llvm/llvm-project/pull/101732 changes in virtual register processing aimed to improve correctness of emitted MIR between passes from the perspective of MachineVerifier. Namely, the following changes are introduced: * register classes (lib/Target/SPIRV/SPIRVRegisterInfo.td) and instruction patterns (lib/Target/SPIRV/SPIRVInstrInfo.td) are corrected and simplified (by removing unnecessary sophisticated options) -- e.g., this PR gets rid of duplicating 32/64 bits patterns, removes ANYID register class and simplifies definition of the rest of register classes, * hardcoded LLT scalar types in passes before instruction selection are corrected -- the goal is to have correct bit width before instruction selection, and use 64 bits registers for pattern matching in the instruction selection pass; 32-bit registers remain where they are described in such terms by SPIR-V specification (like, for example, creation of virtual registers for scope/mem semantics operands), * rework virtual register type/class assignment for calls/builtins lowering, * a series of minor changes to fix validity of emitted code between passes: - ensure that that bitcast changes the type, - fix the pattern for instruction selection for OpExtInst, - simplify inline asm operands usage, - account for arbitrary integer sizes / update legalizer rules; * add '-verify-machineinstrs' to existed test cases. See also https://github.com/llvm/llvm-project/issues/88129 that this PR may resolve. This PR fixes a great number of issues reported by MachineVerifier and, as a result, reduces a number of failed test cases for the mode with expensive checks set on from ~200 to ~57.
26 lines
909 B
LLVM
26 lines
909 B
LLVM
; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
|
|
|
|
;; Debug info:
|
|
; CHECK: OpName %[[#FOO:]] "foo"
|
|
|
|
;; Types:
|
|
; CHECK: %[[#VOID:]] = OpTypeVoid
|
|
; CHECK: %[[#FN:]] = OpTypeFunction %[[#VOID]]
|
|
|
|
;; Functions:
|
|
; CHECK: %[[#FOO]] = OpFunction %[[#VOID]] None %[[#FN]]
|
|
; CHECK-NOT: OpFunctionParameter
|
|
;; NOTE: In 2.4, it isn't explicitly written that a function always has a least
|
|
;; one block. In fact, 2.4.11 seems to imply that there are at least two
|
|
;; blocks in functions with a body, but that doesn't make much sense.
|
|
;; However, in order to distinguish between function declaration and
|
|
;; definition, a function needs at least one block, hence why this test
|
|
;; expects one OpLabel + OpReturn.
|
|
; CHECK: OpLabel
|
|
; CHECK: OpReturn
|
|
; CHECK-NOT: OpLabel
|
|
; CHECK: OpFunctionEnd
|
|
define void @foo() {
|
|
ret void
|
|
}
|