f9c98068c8
This PR contains changes in virtual register processing aimed to improve correctness of emitted MIR between passes from the perspective of MachineVerifier. This potentially helps to detect previously missed flaws in code emission and harden the test suite. As a measure of correctness and usefulness of this PR we may use a mode with expensive checks set on, and MachineVerifier reports problems in the test suite. In order to satisfy Machine Verifier requirements to MIR correctness not only a rework of usage of virtual registers' types and classes is required, but also corrections into pre-legalizer and instruction selection logics. Namely, the following changes are introduced: * scalar virtual registers have proper bit width, * detect register class by SPIR-V type, * add a superclass for id virtual register classes, * fix Tablegen rules used for instruction selection, * fixes of minor existed issues (missed flag for proper representation of a null constant for OpenCL vs. HLSL, wrong usage of integer virtual registers as a synonym of any non-type virtual register).
33 lines
1.7 KiB
LLVM
33 lines
1.7 KiB
LLVM
; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s -o - -filetype=obj | spirv-val %}
|
|
|
|
; CHECK: OpDecorate %[[#ID:]] LinkageAttributes "imageSampler" Export
|
|
; CHECK: %[[#ID]] = OpVariable %[[#]] UniformConstant %[[#]]
|
|
|
|
@imageSampler = addrspace(2) constant i32 36, align 4
|
|
|
|
define spir_kernel void @sample_kernel(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 0) %input, ptr addrspace(1) nocapture %xOffsets, ptr addrspace(1) nocapture %yOffsets, ptr addrspace(1) nocapture %results) {
|
|
%1 = tail call spir_func i64 @_Z13get_global_idj(i32 0)
|
|
%2 = trunc i64 %1 to i32
|
|
%3 = tail call spir_func i64 @_Z13get_global_idj(i32 1)
|
|
%4 = trunc i64 %3 to i32
|
|
%5 = tail call spir_func i32 @_Z15get_image_width11ocl_image2d(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 0) %input)
|
|
%6 = mul nsw i32 %4, %5
|
|
%7 = add nsw i32 %6, %2
|
|
%8 = sitofp i32 %2 to float
|
|
%9 = insertelement <2 x float> undef, float %8, i32 0
|
|
%10 = sitofp i32 %4 to float
|
|
%11 = insertelement <2 x float> %9, float %10, i32 1
|
|
%12 = tail call spir_func <4 x float> @_Z11read_imagef11ocl_image2d11ocl_samplerDv2_f(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 0) %input, i32 36, <2 x float> %11)
|
|
%13 = sext i32 %7 to i64
|
|
%14 = getelementptr inbounds <4 x float>, ptr addrspace(1) %results, i64 %13
|
|
store <4 x float> %12, ptr addrspace(1) %14, align 16
|
|
ret void
|
|
}
|
|
|
|
declare spir_func i64 @_Z13get_global_idj(i32)
|
|
|
|
declare spir_func i32 @_Z15get_image_width11ocl_image2d(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 0))
|
|
|
|
declare spir_func <4 x float> @_Z11read_imagef11ocl_image2d11ocl_samplerDv2_f(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 0), i32, <2 x float>)
|