da6424c9e3
On X86-64, LLVM currently generates the same DWARF debug info for `call rax` and `call [rax]`; in both cases, the generated DWARF claims that the call goes to address RAX. This bug occurs because the X86 machine instructions CALL64r and CALL64m both receive register operands, but those register operands have different semantics. To fix it, change DwarfDebug::constructCallSiteEntryDIEs() to validate the callee operand's semantics (`OperandType`) and make sure it is not semantically describing a memory location. This fix will result in less DW_TAG_call_site and DW_AT_call_target entries being generated. There is an existing test in dwarf-callsite-related-attrs.ll that asserts the broken behavior; remove the broken check, and instead add a new test dwarf-callsite-related-attrs-indirect.ll that checks behavior for indirect calls. The existing test xray-custom-log.ll is validating something even more broken: It checks the debug info generated by a PATCHABLE_EVENT_CALL. `TII->getCalleeOperand()` assumes that the first argument of a call instruction is always the destination, but the first argument of PATCHABLE_EVENT_CALL is instead the event structure; and so we were emitting debug info claiming the callee was stored in a register that actually contains some kind of xray event descriptor, and the test validates that this happens. I am breaking and deleting this test. I guess the intent there might have been to validate that we emit debuginfo referencing the target of the direct call that LLVM emits (which we don't do)? But I'm not sure.
108 lines
4.0 KiB
LLVM
108 lines
4.0 KiB
LLVM
; RUN: llc -mtriple=x86_64 < %s | FileCheck %s
|
|
; RUN: llc -mtriple=x86_64 -relocation-model=pic < %s | FileCheck %s --check-prefix=PIC
|
|
|
|
define i32 @customevent() nounwind "function-instrument"="xray-always" !dbg !1 {
|
|
%eventptr = alloca i8
|
|
%eventsize = alloca i64
|
|
store i64 3, ptr %eventsize
|
|
%val = load i64, ptr %eventsize
|
|
call void @llvm.xray.customevent(ptr %eventptr, i64 %val), !dbg !8
|
|
; CHECK-LABEL: Lxray_event_sled_0:
|
|
; CHECK: .byte 0xeb, 0x0f
|
|
; CHECK-NEXT: pushq %rdi
|
|
; CHECK-NEXT: pushq %rsi
|
|
; CHECK-NEXT: movq %rcx, %rdi
|
|
; CHECK-NEXT: movq %rax, %rsi
|
|
; CHECK-NEXT: callq __xray_CustomEvent
|
|
; CHECK-NEXT: popq %rsi
|
|
; CHECK-NEXT: popq %rdi
|
|
|
|
; PIC-LABEL: Lxray_event_sled_0:
|
|
; PIC: .byte 0xeb, 0x0f
|
|
; PIC-NEXT: pushq %rdi
|
|
; PIC-NEXT: pushq %rsi
|
|
; PIC-NEXT: movq %rcx, %rdi
|
|
; PIC-NEXT: movq %rax, %rsi
|
|
; PIC-NEXT: callq __xray_CustomEvent@PLT
|
|
; PIC-NEXT: popq %rsi
|
|
; PIC-NEXT: popq %rdi
|
|
ret i32 0
|
|
}
|
|
; CHECK-LABEL: xray_instr_map
|
|
; CHECK-LABEL: Lxray_sleds_start0:
|
|
; CHECK: .quad {{.*}}xray_event_sled_0
|
|
|
|
define i32 @typedevent() nounwind "function-instrument"="xray-always" !dbg !2 {
|
|
%eventptr = alloca i8
|
|
%eventsize = alloca i64
|
|
%eventtype = alloca i64
|
|
store i64 6, ptr %eventtype
|
|
%type = load i64, ptr %eventtype
|
|
store i64 3, ptr %eventsize
|
|
%val = load i64, ptr %eventsize
|
|
call void @llvm.xray.typedevent(i64 %type, ptr %eventptr, i64 %val), !dbg !9
|
|
; CHECK-LABEL: Lxray_typed_event_sled_0:
|
|
; CHECK: .byte 0xeb, 0x14
|
|
; CHECK-NEXT: pushq %rdi
|
|
; CHECK-NEXT: pushq %rsi
|
|
; CHECK-NEXT: pushq %rdx
|
|
; CHECK-NEXT: movq %rdx, %rdi
|
|
; CHECK-NEXT: movq %rcx, %rsi
|
|
; CHECK-NEXT: movq %rax, %rdx
|
|
; CHECK-NEXT: callq __xray_TypedEvent
|
|
; CHECK-NEXT: popq %rdx
|
|
; CHECK-NEXT: popq %rsi
|
|
; CHECK-NEXT: popq %rdi
|
|
|
|
; PIC-LABEL: Lxray_typed_event_sled_0:
|
|
; PIC: .byte 0xeb, 0x14
|
|
; PIC-NEXT: pushq %rdi
|
|
; PIC-NEXT: pushq %rsi
|
|
; PIC-NEXT: pushq %rdx
|
|
; PIC-NEXT: movq %rdx, %rdi
|
|
; PIC-NEXT: movq %rcx, %rsi
|
|
; PIC-NEXT: movq %rax, %rdx
|
|
; PIC-NEXT: callq __xray_TypedEvent@PLT
|
|
; PIC-NEXT: popq %rdx
|
|
; PIC-NEXT: popq %rsi
|
|
; PIC-NEXT: popq %rdi
|
|
ret i32 0
|
|
}
|
|
; CHECK-LABEL: xray_instr_map
|
|
; CHECK-LABEL: Lxray_sleds_start1:
|
|
; CHECK: .quad {{.*}}xray_typed_event_sled_0
|
|
|
|
; Verify that custom event calls are done with proper stack alignment,
|
|
; even in leaf functions.
|
|
@leaf_func.event_id = internal constant i32 1, align 4
|
|
define void @leaf_func() "function-instrument"="xray-always" "frame-pointer"="none" nounwind {
|
|
; CHECK-LABEL: leaf_func:
|
|
; CHECK-NEXT: .Lfunc_begin2:
|
|
; CHECK: pushq %rax
|
|
; CHECK: movl $leaf_func.event_id, %eax
|
|
; CHECK-NEXT: movl $4, %ecx
|
|
; CHECK-NEXT: .p2align 1
|
|
; CHECK-NEXT: .Lxray_event_sled_1:
|
|
call void @llvm.xray.customevent(ptr @leaf_func.event_id, i64 4)
|
|
ret void
|
|
}
|
|
|
|
declare void @llvm.xray.customevent(ptr, i64)
|
|
declare void @llvm.xray.typedevent(i64, ptr, i64)
|
|
|
|
!llvm.dbg.cu = !{!7}
|
|
!llvm.module.flags = !{!10, !11}
|
|
|
|
!1 = distinct !DISubprogram(name: "customevent", scope: !3, file: !3, line: 1, type: !4, scopeLine: 1, flags: DIFlagPrototyped | DIFlagAllCallsDescribed, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !7)
|
|
!2 = distinct !DISubprogram(name: "typedevent", scope: !3, file: !3, line: 3, type: !4, scopeLine: 3, flags: DIFlagPrototyped | DIFlagAllCallsDescribed, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !7)
|
|
!3 = !DIFile(filename: "a.c", directory: "/tmp")
|
|
!4 = !DISubroutineType(types: !5)
|
|
!5 = !{!6}
|
|
!6 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
|
|
!7 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus_14, file: !3, producer: "clang version 12.0.0", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug)
|
|
!8 = !DILocation(line: 2, column: 3, scope: !1)
|
|
!9 = !DILocation(line: 4, column: 3, scope: !2)
|
|
|
|
!10 = !{i32 7, !"Dwarf Version", i32 5}
|
|
!11 = !{i32 2, !"Debug Info Version", i32 3}
|