5013c81b78
The global ctor evaluator tries to evalute function calls where the call function type and function type do not match, by performing bitcasts. This currently causes a crash when calling a void function with non-void return type. I've opted to remove this functionality entirely rather than fixing this specific case. With opaque pointers, there shouldn't be a legitimate use case for this anymore, as we don't need to look through pointer type casts. Doing other bitcasts is very iffy because it ignores ABI considerations. We should at least leave adjusting the signatures to make them line up to InstCombine (which also does some iffy things, but is at least somewhat more constrained). Fixes https://github.com/llvm/llvm-project/issues/118725.
52 lines
1.5 KiB
LLVM
52 lines
1.5 KiB
LLVM
; Check that we do not try to evaluate function calls with signature
|
|
; mismatches.
|
|
; RUN: opt -passes=globalopt,instcombine %s -S -o - | FileCheck %s
|
|
|
|
; CHECK: @_q = dso_local global %struct.Q zeroinitializer
|
|
; CHECK: @llvm.global_ctors
|
|
|
|
source_filename = "main.cpp"
|
|
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-none-linux-gnu"
|
|
|
|
%struct.Q = type { i32 }
|
|
|
|
$_ZN1QC2Ev = comdat any
|
|
|
|
@_q = dso_local global %struct.Q zeroinitializer, align 4
|
|
@llvm.global_ctors = appending global [1 x { i32, ptr, ptr }] [{ i32, ptr, ptr } { i32 65535, ptr @_GLOBAL__sub_I_main.cpp, ptr null }]
|
|
|
|
define internal void @__cxx_global_var_init() section ".text.startup" {
|
|
call void @_ZN1QC2Ev(ptr @_q)
|
|
ret void
|
|
}
|
|
|
|
define linkonce_odr dso_local void @_ZN1QC2Ev(ptr) unnamed_addr #1 comdat align 2 {
|
|
%2 = alloca ptr, align 8
|
|
store ptr %0, ptr %2, align 8
|
|
%3 = load ptr, ptr %2, align 8
|
|
%4 = call i32 @fmodf(float 0x40091EB860000000, float 2.000000e+00)
|
|
store i32 %4, ptr %3, align 4
|
|
ret void
|
|
}
|
|
|
|
define dso_local i32 @main(i32, ptr) {
|
|
%3 = alloca i32, align 4
|
|
%4 = alloca i32, align 4
|
|
%5 = alloca ptr, align 8
|
|
store i32 0, ptr %3, align 4
|
|
store i32 %0, ptr %4, align 4
|
|
store ptr %1, ptr %5, align 8
|
|
%6 = load i32, ptr @_q, align 4
|
|
ret i32 %6
|
|
}
|
|
|
|
; Function Attrs: nounwind
|
|
declare dso_local float @fmodf(float, float)
|
|
|
|
; Function Attrs: noinline uwtable
|
|
define internal void @_GLOBAL__sub_I_main.cpp() section ".text.startup" {
|
|
call void @__cxx_global_var_init()
|
|
ret void
|
|
}
|