094572701d
This patch makes the final major change of the RemoveDIs project, changing the default IR output from debug intrinsics to debug records. This is expected to break a large number of tests: every single one that tests for uses or declarations of debug intrinsics and does not explicitly disable writing records. If this patch has broken your downstream tests (or upstream tests on a configuration I wasn't able to run): 1. If you need to immediately unblock a build, pass `--write-experimental-debuginfo=false` to LLVM's option processing for all failing tests (remember to use `-mllvm` for clang/flang to forward arguments to LLVM). 2. For most test failures, the changes are trivial and mechanical, enough that they can be done by script; see the migration guide for a guide on how to do this: https://llvm.org/docs/RemoveDIsDebugInfo.html#test-updates 3. If any tests fail for reasons other than FileCheck check lines that need updating, such as assertion failures, that is most likely a real bug with this patch and should be reported as such. For more information, see the recent PSA: https://discourse.llvm.org/t/psa-ir-output-changing-from-debug-intrinsics-to-debug-records/79578
112 lines
4.4 KiB
LLVM
112 lines
4.4 KiB
LLVM
; RUN: opt %s -passes=instcombine -S | FileCheck %s
|
|
|
|
; Test sinking of dbg.values when instcombine sinks associated instructions.
|
|
|
|
declare void @llvm.dbg.value(metadata, metadata, metadata)
|
|
|
|
; This GEP is sunk, but can be folded into a DIExpression. Check that it
|
|
; gets folded. The dbg.value should be duplicated in the block its sunk
|
|
; into, to maximise liveness.
|
|
;
|
|
; CHECK-LABEL: define i32 @foo(ptr
|
|
; CHECK: #dbg_value(ptr %a, !{{[0-9]+}},
|
|
; CHECK-SAME: !DIExpression(DW_OP_plus_uconst, 4, DW_OP_stack_value),
|
|
; CHECK-NEXT: br label %sink1
|
|
|
|
define i32 @foo(ptr %a) !dbg !7 {
|
|
entry:
|
|
%gep = getelementptr i32, ptr %a, i32 1
|
|
call void @llvm.dbg.value(metadata ptr %gep, metadata !16, metadata !12), !dbg !15
|
|
br label %sink1
|
|
|
|
sink1:
|
|
; CHECK-LABEL: sink1:
|
|
; CHECK: #dbg_value(ptr %gep,
|
|
; CHECK-SAME: !{{[0-9]+}}, !DIExpression(),
|
|
; CHECK-NEXT: load
|
|
%0 = load i32, ptr %gep, align 4, !dbg !15
|
|
ret i32 %0, !dbg !15
|
|
}
|
|
|
|
; In this example the GEP cannot (yet) be salvaged. Check that not only is the
|
|
; dbg.value sunk, but an undef dbg.value is left to terminate any earlier
|
|
; value range.
|
|
|
|
; CHECK-LABEL: define i32 @bar(
|
|
; CHECK: #dbg_value(ptr poison,
|
|
; CHECK-NEXT: br label %sink2
|
|
|
|
define i32 @bar(ptr %a, i32 %b) !dbg !70 {
|
|
entry:
|
|
%gep = getelementptr <vscale x 4 x i32>, ptr %a, i32 %b
|
|
call void @llvm.dbg.value(metadata ptr %gep, metadata !73, metadata !12), !dbg !74
|
|
br label %sink2
|
|
|
|
sink2:
|
|
; CHECK-LABEL: sink2:
|
|
; CHECK: #dbg_value(ptr %gep,
|
|
; CHECK-SAME: !{{[0-9]+}}, !DIExpression(),
|
|
; CHECK-NEXT: load
|
|
; CHECK-NEXT: extractelement
|
|
; CHECK-NEXT: ret
|
|
%0 = load <vscale x 4 x i32>, ptr %gep
|
|
%extract = extractelement <vscale x 4 x i32> %0, i32 1
|
|
ret i32 %extract
|
|
}
|
|
|
|
; This GEP is sunk, and has multiple debug uses in the same block. Check that
|
|
; only the last use is cloned into the sunk block, and that both of the
|
|
; original dbg.values are salvaged.
|
|
;
|
|
; CHECK-LABEL: define i32 @baz(ptr
|
|
; CHECK: #dbg_value(ptr %a, !{{[0-9]+}},
|
|
; CHECK-SAME: !DIExpression(DW_OP_plus_uconst, 4, DW_OP_stack_value),
|
|
; CHECK-NEXT: #dbg_value(ptr %a, !{{[0-9]+}},
|
|
; CHECK-SAME: !DIExpression(DW_OP_plus_uconst, 9, DW_OP_stack_value),
|
|
; CHECK-NEXT: br label %sink1
|
|
|
|
define i32 @baz(ptr %a) !dbg !80 {
|
|
entry:
|
|
%gep = getelementptr i32, ptr %a, i32 1
|
|
call void @llvm.dbg.value(metadata ptr %gep, metadata !83, metadata !12), !dbg !84
|
|
call void @llvm.dbg.value(metadata ptr %gep, metadata !83, metadata !DIExpression(DW_OP_plus_uconst, 5)), !dbg !85
|
|
br label %sink1
|
|
|
|
sink1:
|
|
; CHECK-LABEL: sink1:
|
|
; CHECK: #dbg_value(ptr %gep,
|
|
; CHECK-SAME: !{{[0-9]+}}, !DIExpression(DW_OP_plus_uconst, 5),
|
|
; CHECK-NEXT: load
|
|
%0 = load i32, ptr %gep, align 4, !dbg !85
|
|
ret i32 %0, !dbg !85
|
|
}
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!3, !4, !5}
|
|
!llvm.ident = !{!6}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug)
|
|
!1 = !DIFile(filename: "a.c", directory: ".")
|
|
!2 = !{}
|
|
!3 = !{i32 2, !"Dwarf Version", i32 4}
|
|
!4 = !{i32 2, !"Debug Info Version", i32 3}
|
|
!5 = !{i32 1, !"PIC Level", i32 2}
|
|
!6 = !{!"clang"}
|
|
!7 = distinct !DISubprogram(name: "foo", scope: !1, file: !1, line: 2, type: !8, isLocal: false, isDefinition: true, scopeLine: 3, flags: DIFlagPrototyped, isOptimized: false, unit: !0, retainedNodes: !2)
|
|
!8 = !DISubroutineType(types: !9)
|
|
!9 = !{!10, !10}
|
|
!10 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
|
|
!11 = !DILocalVariable(name: "j", scope: !7, file: !1, line: 2, type: !10)
|
|
!12 = !DIExpression()
|
|
!15 = !DILocation(line: 5, column: 3, scope: !7)
|
|
!16 = !DILocalVariable(name: "h", scope: !7, file: !1, line: 4, type: !10)
|
|
!70 = distinct !DISubprogram(name: "bar", scope: !1, file: !1, line: 2, type: !71, isLocal: false, isDefinition: true, scopeLine: 3, flags: DIFlagPrototyped, isOptimized: false, unit: !0, retainedNodes: !2)
|
|
!71 = !DISubroutineType(types: !72)
|
|
!72 = !{!10, !10, !10}
|
|
!73 = !DILocalVariable(name: "k", scope: !70, file: !1, line: 2, type: !10)
|
|
!74 = !DILocation(line: 5, column: 3, scope: !70)
|
|
!80 = distinct !DISubprogram(name: "baz", scope: !1, file: !1, line: 2, type: !8, isLocal: false, isDefinition: true, scopeLine: 3, flags: DIFlagPrototyped, isOptimized: false, unit: !0, retainedNodes: !2)
|
|
!83 = !DILocalVariable(name: "l", scope: !80, file: !1, line: 2, type: !10)
|
|
!84 = !DILocation(line: 5, column: 3, scope: !80)
|
|
!85 = !DILocation(line: 6, column: 3, scope: !80)
|