Nikita Popov d9a5aa8e2d
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
Change all the cstval_pred_ty based PatternMatch helpers (things like
m_AllOnes and m_Zero) to only allow poison elements inside vector
splats, not undef elements.

Historically, we used to represent non-demanded elements in vectors
using undef. Nowadays, we use poison instead. As such, I believe that
support for undef in vector splats is no longer useful.

At the same time, while poison splat elements are pretty much always
safe to ignore, this is not generally the case for undef elements. We
have existing miscompiles in our tests due to this (see the
masked-merge-*.ll tests changed here) and it's easy to miss such cases
in the future, now that we write tests using poison instead of undef
elements.

I think overall, keeping support for undef elements no longer makes
sense, and we should drop it. Once this is done consistently, I think we
may also consider allowing poison in m_APInt by default, as doing that
change is much less risky than doing the same with undef.

This change involves a substantial amount of test changes. For most
tests, I've just replaced undef with poison, as I don't think there is
value in retaining both. For some tests (where the distinction between
undef and poison is important), I've duplicated tests.
2024-04-17 18:22:05 +09:00

245 lines
6.8 KiB
LLVM

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -passes=instcombine -S | FileCheck %s
define i1 @oeq_self(double %arg) {
; CHECK-LABEL: @oeq_self(
; CHECK-NEXT: [[TMP:%.*]] = fcmp ord double [[ARG:%.*]], 0.000000e+00
; CHECK-NEXT: ret i1 [[TMP]]
;
%tmp = fcmp oeq double %arg, %arg
ret i1 %tmp
}
; PR1111 - https://bugs.llvm.org/show_bug.cgi?id=1111
define i1 @une_self(double %x) {
; CHECK-LABEL: @une_self(
; CHECK-NEXT: [[TMP:%.*]] = fcmp uno double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: ret i1 [[TMP]]
;
%tmp = fcmp une double %x, %x
ret i1 %tmp
}
; When just checking for a NaN (ORD/UNO), canonicalize constants.
; Float/double are alternated for additional coverage.
define i1 @ord_zero(float %x) {
; CHECK-LABEL: @ord_zero(
; CHECK-NEXT: [[F:%.*]] = fcmp ord float [[X:%.*]], 0.000000e+00
; CHECK-NEXT: ret i1 [[F]]
;
%f = fcmp ord float %x, 0.0
ret i1 %f
}
define i1 @ord_nonzero(double %x) {
; CHECK-LABEL: @ord_nonzero(
; CHECK-NEXT: [[F:%.*]] = fcmp ord double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: ret i1 [[F]]
;
%f = fcmp ord double %x, 3.0
ret i1 %f
}
define i1 @ord_self(float %x) {
; CHECK-LABEL: @ord_self(
; CHECK-NEXT: [[F:%.*]] = fcmp ord float [[X:%.*]], 0.000000e+00
; CHECK-NEXT: ret i1 [[F]]
;
%f = fcmp ord float %x, %x
ret i1 %f
}
define i1 @uno_zero(double %x) {
; CHECK-LABEL: @uno_zero(
; CHECK-NEXT: [[F:%.*]] = fcmp uno double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: ret i1 [[F]]
;
%f = fcmp uno double %x, 0.0
ret i1 %f
}
define i1 @uno_nonzero(float %x) {
; CHECK-LABEL: @uno_nonzero(
; CHECK-NEXT: [[F:%.*]] = fcmp uno float [[X:%.*]], 0.000000e+00
; CHECK-NEXT: ret i1 [[F]]
;
%f = fcmp uno float %x, 3.0
ret i1 %f
}
define i1 @uno_self(double %x) {
; CHECK-LABEL: @uno_self(
; CHECK-NEXT: [[F:%.*]] = fcmp uno double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: ret i1 [[F]]
;
%f = fcmp uno double %x, %x
ret i1 %f
}
define <2 x i1> @ord_zero_vec(<2 x double> %x) {
; CHECK-LABEL: @ord_zero_vec(
; CHECK-NEXT: [[F:%.*]] = fcmp ord <2 x double> [[X:%.*]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[F]]
;
%f = fcmp ord <2 x double> %x, zeroinitializer
ret <2 x i1> %f
}
define <2 x i1> @ord_nonzero_vec(<2 x float> %x) {
; CHECK-LABEL: @ord_nonzero_vec(
; CHECK-NEXT: [[F:%.*]] = fcmp ord <2 x float> [[X:%.*]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[F]]
;
%f = fcmp ord <2 x float> %x, <float 3.0, float 5.0>
ret <2 x i1> %f
}
define <2 x i1> @ord_self_vec(<2 x double> %x) {
; CHECK-LABEL: @ord_self_vec(
; CHECK-NEXT: [[F:%.*]] = fcmp ord <2 x double> [[X:%.*]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[F]]
;
%f = fcmp ord <2 x double> %x, %x
ret <2 x i1> %f
}
define <2 x i1> @uno_zero_vec(<2 x float> %x) {
; CHECK-LABEL: @uno_zero_vec(
; CHECK-NEXT: [[F:%.*]] = fcmp uno <2 x float> [[X:%.*]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[F]]
;
%f = fcmp uno <2 x float> %x, zeroinitializer
ret <2 x i1> %f
}
define <2 x i1> @uno_nonzero_vec(<2 x double> %x) {
; CHECK-LABEL: @uno_nonzero_vec(
; CHECK-NEXT: [[F:%.*]] = fcmp uno <2 x double> [[X:%.*]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[F]]
;
%f = fcmp uno <2 x double> %x, <double 3.0, double 5.0>
ret <2 x i1> %f
}
define <2 x i1> @uno_self_vec(<2 x float> %x) {
; CHECK-LABEL: @uno_self_vec(
; CHECK-NEXT: [[F:%.*]] = fcmp uno <2 x float> [[X:%.*]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[F]]
;
%f = fcmp uno <2 x float> %x, %x
ret <2 x i1> %f
}
; If a scalar constant is NaN in any of the above tests, it would have been eliminated by InstSimplify.
; If a vector has a NaN element, we don't do anything with it.
define <2 x i1> @uno_vec_with_nan(<2 x double> %x) {
; CHECK-LABEL: @uno_vec_with_nan(
; CHECK-NEXT: [[F:%.*]] = fcmp uno <2 x double> [[X:%.*]], <double 3.000000e+00, double 0x7FF00000FFFFFFFF>
; CHECK-NEXT: ret <2 x i1> [[F]]
;
%f = fcmp uno <2 x double> %x, <double 3.0, double 0x7FF00000FFFFFFFF>
ret <2 x i1> %f
}
define <2 x i1> @uno_vec_with_poison(<2 x double> %x) {
; CHECK-LABEL: @uno_vec_with_poison(
; CHECK-NEXT: [[F:%.*]] = fcmp uno <2 x double> [[X:%.*]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[F]]
;
%f = fcmp uno <2 x double> %x, <double 3.0, double poison>
ret <2 x i1> %f
}
define <2 x i1> @ord_vec_with_poison(<2 x double> %x) {
; CHECK-LABEL: @ord_vec_with_poison(
; CHECK-NEXT: [[F:%.*]] = fcmp ord <2 x double> [[X:%.*]], <double 0.000000e+00, double poison>
; CHECK-NEXT: ret <2 x i1> [[F]]
;
%f = fcmp ord <2 x double> %x, <double 0.0, double poison>
ret <2 x i1> %f
}
; TODO: This could be handled in InstSimplify.
define i1 @nnan_ops_to_fcmp_ord(float %x, float %y) {
; CHECK-LABEL: @nnan_ops_to_fcmp_ord(
; CHECK-NEXT: ret i1 true
;
%mul = fmul nnan float %x, %y
%div = fdiv nnan float %x, %y
%cmp = fcmp ord float %mul, %div
ret i1 %cmp
}
; TODO: This could be handled in InstSimplify.
define i1 @nnan_ops_to_fcmp_uno(float %x, float %y) {
; CHECK-LABEL: @nnan_ops_to_fcmp_uno(
; CHECK-NEXT: ret i1 false
;
%mul = fmul nnan float %x, %y
%div = fdiv nnan float %x, %y
%cmp = fcmp uno float %mul, %div
ret i1 %cmp
}
; TODO: For any predicate/type/FMF, comparison to -0.0 is the same as comparison to +0.0.
define i1 @negative_zero_oeq(float %x) {
; CHECK-LABEL: @negative_zero_oeq(
; CHECK-NEXT: [[R:%.*]] = fcmp oeq float [[X:%.*]], 0.000000e+00
; CHECK-NEXT: ret i1 [[R]]
;
%r = fcmp oeq float %x, -0.0
ret i1 %r
}
define i1 @negative_zero_oge(double %x) {
; CHECK-LABEL: @negative_zero_oge(
; CHECK-NEXT: [[R:%.*]] = fcmp nnan oge double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: ret i1 [[R]]
;
%r = fcmp nnan oge double %x, -0.0
ret i1 %r
}
define i1 @negative_zero_uge(half %x) {
; CHECK-LABEL: @negative_zero_uge(
; CHECK-NEXT: [[R:%.*]] = fcmp fast uge half [[X:%.*]], 0xH0000
; CHECK-NEXT: ret i1 [[R]]
;
%r = fcmp fast uge half %x, -0.0
ret i1 %r
}
define <2 x i1> @negative_zero_olt_vec(<2 x float> %x) {
; CHECK-LABEL: @negative_zero_olt_vec(
; CHECK-NEXT: [[R:%.*]] = fcmp reassoc ninf olt <2 x float> [[X:%.*]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[R]]
;
%r = fcmp reassoc ninf olt <2 x float> %x, <float -0.0, float -0.0>
ret <2 x i1> %r
}
define <2 x i1> @negative_zero_une_vec_poison(<2 x double> %x) {
; CHECK-LABEL: @negative_zero_une_vec_poison(
; CHECK-NEXT: [[R:%.*]] = fcmp nnan une <2 x double> [[X:%.*]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[R]]
;
%r = fcmp nnan une <2 x double> %x, <double -0.0, double poison>
ret <2 x i1> %r
}
define <2 x i1> @negative_zero_ule_vec_mixed(<2 x float> %x) {
; CHECK-LABEL: @negative_zero_ule_vec_mixed(
; CHECK-NEXT: [[R:%.*]] = fcmp ule <2 x float> [[X:%.*]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[R]]
;
%r = fcmp ule <2 x float> %x, <float 0.0, float -0.0>
ret <2 x i1> %r
}