d9a5aa8e2d
Change all the cstval_pred_ty based PatternMatch helpers (things like m_AllOnes and m_Zero) to only allow poison elements inside vector splats, not undef elements. Historically, we used to represent non-demanded elements in vectors using undef. Nowadays, we use poison instead. As such, I believe that support for undef in vector splats is no longer useful. At the same time, while poison splat elements are pretty much always safe to ignore, this is not generally the case for undef elements. We have existing miscompiles in our tests due to this (see the masked-merge-*.ll tests changed here) and it's easy to miss such cases in the future, now that we write tests using poison instead of undef elements. I think overall, keeping support for undef elements no longer makes sense, and we should drop it. Once this is done consistently, I think we may also consider allowing poison in m_APInt by default, as doing that change is much less risky than doing the same with undef. This change involves a substantial amount of test changes. For most tests, I've just replaced undef with poison, as I don't think there is value in retaining both. For some tests (where the distinction between undef and poison is important), I've duplicated tests.
106 lines
3.0 KiB
LLVM
106 lines
3.0 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
|
|
; RUN: opt < %s -passes=instcombine -S | FileCheck %s
|
|
|
|
; Fold
|
|
; (-1 u/ %x) u< %y
|
|
; to
|
|
; @llvm.umul.with.overflow(%x, %y) + extractvalue
|
|
|
|
define i1 @t0_basic(i8 %x, i8 %y) {
|
|
; CHECK-LABEL: @t0_basic(
|
|
; CHECK-NEXT: [[MUL:%.*]] = call { i8, i1 } @llvm.umul.with.overflow.i8(i8 [[X:%.*]], i8 [[Y:%.*]])
|
|
; CHECK-NEXT: [[MUL_OV:%.*]] = extractvalue { i8, i1 } [[MUL]], 1
|
|
; CHECK-NEXT: ret i1 [[MUL_OV]]
|
|
;
|
|
%t0 = udiv i8 -1, %x
|
|
%r = icmp ult i8 %t0, %y
|
|
ret i1 %r
|
|
}
|
|
|
|
define <2 x i1> @t1_vec(<2 x i8> %x, <2 x i8> %y) {
|
|
; CHECK-LABEL: @t1_vec(
|
|
; CHECK-NEXT: [[MUL:%.*]] = call { <2 x i8>, <2 x i1> } @llvm.umul.with.overflow.v2i8(<2 x i8> [[X:%.*]], <2 x i8> [[Y:%.*]])
|
|
; CHECK-NEXT: [[MUL_OV:%.*]] = extractvalue { <2 x i8>, <2 x i1> } [[MUL]], 1
|
|
; CHECK-NEXT: ret <2 x i1> [[MUL_OV]]
|
|
;
|
|
%t0 = udiv <2 x i8> <i8 -1, i8 -1>, %x
|
|
%r = icmp ult <2 x i8> %t0, %y
|
|
ret <2 x i1> %r
|
|
}
|
|
|
|
define <3 x i1> @t2_vec_poison(<3 x i8> %x, <3 x i8> %y) {
|
|
; CHECK-LABEL: @t2_vec_poison(
|
|
; CHECK-NEXT: [[MUL:%.*]] = call { <3 x i8>, <3 x i1> } @llvm.umul.with.overflow.v3i8(<3 x i8> [[X:%.*]], <3 x i8> [[Y:%.*]])
|
|
; CHECK-NEXT: [[MUL_OV:%.*]] = extractvalue { <3 x i8>, <3 x i1> } [[MUL]], 1
|
|
; CHECK-NEXT: ret <3 x i1> [[MUL_OV]]
|
|
;
|
|
%t0 = udiv <3 x i8> <i8 -1, i8 poison, i8 -1>, %x
|
|
%r = icmp ult <3 x i8> %t0, %y
|
|
ret <3 x i1> %r
|
|
}
|
|
|
|
declare i8 @gen8()
|
|
|
|
define i1 @t3_commutative(i8 %x) {
|
|
; CHECK-LABEL: @t3_commutative(
|
|
; CHECK-NEXT: [[Y:%.*]] = call i8 @gen8()
|
|
; CHECK-NEXT: [[MUL:%.*]] = call { i8, i1 } @llvm.umul.with.overflow.i8(i8 [[X:%.*]], i8 [[Y]])
|
|
; CHECK-NEXT: [[MUL_OV:%.*]] = extractvalue { i8, i1 } [[MUL]], 1
|
|
; CHECK-NEXT: ret i1 [[MUL_OV]]
|
|
;
|
|
%t0 = udiv i8 -1, %x
|
|
%y = call i8 @gen8()
|
|
%r = icmp ugt i8 %y, %t0 ; swapped
|
|
ret i1 %r
|
|
}
|
|
|
|
; Negative tests
|
|
|
|
declare void @use8(i8)
|
|
|
|
define i1 @n4_extrause(i8 %x, i8 %y) {
|
|
; CHECK-LABEL: @n4_extrause(
|
|
; CHECK-NEXT: [[T0:%.*]] = udiv i8 -1, [[X:%.*]]
|
|
; CHECK-NEXT: call void @use8(i8 [[T0]])
|
|
; CHECK-NEXT: [[R:%.*]] = icmp ult i8 [[T0]], [[Y:%.*]]
|
|
; CHECK-NEXT: ret i1 [[R]]
|
|
;
|
|
%t0 = udiv i8 -1, %x
|
|
call void @use8(i8 %t0)
|
|
%r = icmp ult i8 %t0, %y
|
|
ret i1 %r
|
|
}
|
|
|
|
define i1 @n5_not_negone(i8 %x, i8 %y) {
|
|
; CHECK-LABEL: @n5_not_negone(
|
|
; CHECK-NEXT: [[T0:%.*]] = udiv i8 -2, [[X:%.*]]
|
|
; CHECK-NEXT: [[R:%.*]] = icmp ult i8 [[T0]], [[Y:%.*]]
|
|
; CHECK-NEXT: ret i1 [[R]]
|
|
;
|
|
%t0 = udiv i8 -2, %x ; not -1
|
|
%r = icmp ult i8 %t0, %y
|
|
ret i1 %r
|
|
}
|
|
|
|
define i1 @n6_wrong_pred0(i8 %x, i8 %y) {
|
|
; CHECK-LABEL: @n6_wrong_pred0(
|
|
; CHECK-NEXT: [[T0:%.*]] = udiv i8 -1, [[X:%.*]]
|
|
; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[T0]], [[Y:%.*]]
|
|
; CHECK-NEXT: ret i1 [[R]]
|
|
;
|
|
%t0 = udiv i8 -1, %x
|
|
%r = icmp ule i8 %t0, %y ; not ult
|
|
ret i1 %r
|
|
}
|
|
|
|
define i1 @n6_wrong_pred1(i8 %x, i8 %y) {
|
|
; CHECK-LABEL: @n6_wrong_pred1(
|
|
; CHECK-NEXT: [[T0:%.*]] = udiv i8 -1, [[X:%.*]]
|
|
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[T0]], [[Y:%.*]]
|
|
; CHECK-NEXT: ret i1 [[R]]
|
|
;
|
|
%t0 = udiv i8 -1, %x
|
|
%r = icmp ugt i8 %t0, %y ; not ult
|
|
ret i1 %r
|
|
}
|